From 719c3b5ec84547e7f8491ab8306811f2d4f4aba7 Mon Sep 17 00:00:00 2001 From: Zambom Date: Mon, 21 Aug 2017 23:40:39 -0300 Subject: [PATCH] Avoiding non-student to access goals submit screen after update specifications --- goals/views.py | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/goals/views.py b/goals/views.py index 452b2d7..e0e0a65 100644 --- a/goals/views.py +++ b/goals/views.py @@ -972,14 +972,17 @@ class UpdateView(LoginRequiredMixin, LogMixin, generic.UpdateView): def get_success_url(self): messages.success(self.request, _('The Goals specification for the topic %s was updated successfully!')%(self.object.topic.name)) - success_url = reverse_lazy('goals:submit', kwargs = {'slug': self.object.slug}) + if has_subject_permissions(self.request.user, self.object.topic.subject): + success_url = reverse_lazy('goals:view', kwargs = {'slug': self.object.slug}) + else: + success_url = reverse_lazy('goals:submit', kwargs = {'slug': self.object.slug}) - if self.object.show_window: - self.request.session['resources'] = {} - self.request.session['resources']['new_page'] = True - self.request.session['resources']['new_page_url'] = reverse('goals:window_submit', kwargs = {'slug': self.object.slug}) + if self.object.show_window: + self.request.session['resources'] = {} + self.request.session['resources']['new_page'] = True + self.request.session['resources']['new_page_url'] = reverse('goals:window_submit', kwargs = {'slug': self.object.slug}) - success_url = reverse_lazy('subjects:view', kwargs = {'slug': self.object.topic.subject.slug}) + success_url = reverse_lazy('subjects:view', kwargs = {'slug': self.object.topic.subject.slug}) return success_url -- libgit2 0.21.2