diff --git a/lib/noosfero/api/helpers.rb b/lib/noosfero/api/helpers.rb index 6f4ab7a..f741bda 100644 --- a/lib/noosfero/api/helpers.rb +++ b/lib/noosfero/api/helpers.rb @@ -217,7 +217,7 @@ raise ArgumentError, "Environment api_captcha_settings private_key not defined" if d[:private_key].nil? raise ArgumentError, "Environment api_captcha_settings version not defined" unless d[:version] == 1 || d[:version] == 2 raise ArgumentError, "Environment api_captcha_settings verify_uri not defined" if d[:verify_uri].nil? - if d[:version] == 1 + if d[:version] == 1 return verify_recaptcha_v1(remote_ip, d[:private_key], d[:verify_uri], params[:recaptcha_challenge_field], params[:recaptcha_response_field]) end if d[:version] == 2 diff --git a/test/unit/api/helpers_test.rb b/test/unit/api/helpers_test.rb index b51201a..1217741 100644 --- a/test/unit/api/helpers_test.rb +++ b/test/unit/api/helpers_test.rb @@ -161,6 +161,20 @@ class APIHelpersTest < ActiveSupport::TestCase assert_nil make_conditions_with_parameter[:type] end + should 'do not test captcha when there are no settings' do + environment = Environment.new + assert test_captcha("127.0.0.1", {}, environment) + end + + should 'do not test captcha when captcha is disabled on settings' do + environment = Environment.new + environment.api_captcha_settings = { + enabled: false, + } + assert test_captcha("127.0.0.1", {}, environment) + end + + should 'fail display recaptcha v1' do environment = Environment.new environment.api_captcha_settings = { -- libgit2 0.21.2