From dde55d70a3fd97357cb226ef0f94afeb7b3ee9af Mon Sep 17 00:00:00 2001 From: Victor Costa Date: Thu, 8 Jan 2015 18:56:54 -0300 Subject: [PATCH] Avoid loop in person notification job --- app/models/person_notifier.rb | 8 ++++++-- test/unit/person_notifier_test.rb | 12 ++++++++++++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/app/models/person_notifier.rb b/app/models/person_notifier.rb index cd5b3e7..63a9476 100644 --- a/app/models/person_notifier.rb +++ b/app/models/person_notifier.rb @@ -59,8 +59,12 @@ class PersonNotifier end def failure(job) - person = Person.find(person_id) - person.notifier.dispatch_notification_mail + begin + person = Person.find(person_id) + person.notifier.dispatch_notification_mail + rescue + Rails.logger.error "PersonNotifier::NotifyJob: Cannot recover from failure" + end end end diff --git a/test/unit/person_notifier_test.rb b/test/unit/person_notifier_test.rb index 8495e72..98c012b 100644 --- a/test/unit/person_notifier_test.rb +++ b/test/unit/person_notifier_test.rb @@ -225,6 +225,18 @@ class PersonNotifierTest < ActiveSupport::TestCase assert !jobs.select {|j| !j.failed? && j.last_error.nil? }.empty? end + should 'do not raise errors in NotifyJob failure to avoid loop' do + Delayed::Worker.max_attempts = 1 + Delayed::Job.enqueue(PersonNotifier::NotifyJob.new(@member.id)) + + PersonNotifier.any_instance.stubs(:notify).raises('error') + PersonNotifier.any_instance.stubs(:dispatch_notification_mail).raises('error') + + process_delayed_job_queue + jobs = PersonNotifier::NotifyJob.find(@member.id) + assert jobs.select {|j| !j.failed? && j.last_error.nil? }.empty? + end + private def notify -- libgit2 0.21.2