diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/Ignore.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/Ignore.java index 498742f..d83e0e9 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/Ignore.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/Ignore.java @@ -42,7 +42,7 @@ import static java.lang.annotation.RetentionPolicy.RUNTIME; import java.lang.annotation.Retention; import java.lang.annotation.Target; -@Target(FIELD) +@Target(FIELD) @Retention(RUNTIME) public @interface Ignore { } diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/ManagedOperation.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/ManagedOperation.java index f31e2dc..2c28e1c 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/ManagedOperation.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/ManagedOperation.java @@ -47,24 +47,28 @@ import javax.enterprise.util.Nonbinding; import br.gov.frameworkdemoiselle.DemoiselleException; /** - *

Indicates that a method is a managed operation, meaning you can manage some aspect of the application by calling it from a external management client.

- *

This annotation can't be used together with {@link ManagedProperty}, doing so will throw a {@link DemoiselleException}.

+ *

+ * Indicates that a method is a managed operation, meaning you can manage some aspect of the application by + * calling it from a external management client. + *

+ *

+ * This annotation can't be used together with {@link ManagedProperty}, doing so will throw a + * {@link DemoiselleException}. + *

* * @author SERPRO - * */ @Documented -@Target({ElementType.METHOD}) +@Target({ ElementType.METHOD }) @Retention(RetentionPolicy.RUNTIME) public @interface ManagedOperation { - + /** - * Description that will be used to publish the operation to clients. - * Defaults to an empty description. + * Description that will be used to publish the operation to clients. Defaults to an empty description. */ @Nonbinding String description() default ""; - + /** * Type of operation. Defaults to {@link OperationType#UNKNOWN}. */ diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/ManagedProperty.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/ManagedProperty.java index 7589345..4d46eb0 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/ManagedProperty.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/ManagedProperty.java @@ -45,57 +45,65 @@ import java.lang.annotation.Target; import javax.enterprise.util.Nonbinding; /** - *

Indicates that a field must be exposed as a property to management clients.

- *

The property will be writable if there's a public setter method - * declared for the field and readable if there's a getter method. You can override this behaviour by passing a value - * to the {@link #accessLevel()} property.

- *

It's a runtime error to annotate a field with no getter and no setter method.

- *

It's also a runtime error to declare a field as a property and one or both of it's getter and setter - * methods as an operation using the {@link ManagedOperation} annotation.

+ *

+ * Indicates that a field must be exposed as a property to management clients. + *

+ *

+ * The property will be writable if there's a public setter method declared for the field and readable if there's a + * getter method. You can override this behaviour by passing a value to the {@link #accessLevel()} property. + *

+ *

+ * It's a runtime error to annotate a field with no getter and no setter method. + *

+ *

+ * It's also a runtime error to declare a field as a property and one or both of it's getter and setter methods as an + * operation using the {@link ManagedOperation} annotation. + *

* * @author SERPRO - * */ @Documented -@Target({ElementType.FIELD}) +@Target({ ElementType.FIELD }) @Retention(RetentionPolicy.RUNTIME) public @interface ManagedProperty { - + /** * @return The description of this property exposed to management clients. */ @Nonbinding String description() default ""; - + @Nonbinding ManagedPropertyAccess accessLevel() default ManagedPropertyAccess.DEFAULT; - + /** - *

Access level of a managed property.

- * - *

These values only affect access via external management clients, the application is still able to inject and use the normal visibility of the property - * by Java standards.

+ *

+ * Access level of a managed property. + *

+ *

+ * These values only affect access via external management clients, the application is still able to inject and use + * the normal visibility of the property by Java standards. + *

* * @author serpro - * */ - enum ManagedPropertyAccess{ - + enum ManagedPropertyAccess { + /** * Restricts a property to be only readable even if a setter method exists. */ READ_ONLY - + /** * Restricts a property to be only writeable even if a getter method exists. */ - ,WRITE_ONLY - + , WRITE_ONLY + /** - * Says that the read or write access will - * be determined by the presence of a getter method (getProperty()) or setter method (setProperty(propertyValue)) for a property. + * Says that the read or write access will be determined by the presence of a getter method + * (getProperty()) or setter method (setProperty(propertyValue)) for a property. */ - ,DEFAULT; + , DEFAULT; } } diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/OperationParameter.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/OperationParameter.java index c010568..b35e6c8 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/OperationParameter.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/OperationParameter.java @@ -45,29 +45,31 @@ import java.lang.annotation.Target; import javax.enterprise.util.Nonbinding; /** - *

Optional annotation to write additional detail about an operation's parameter.

- *

This annotation is ignored for non-operation methods.

+ *

+ * Optional annotation to write additional detail about an operation's parameter. + *

+ *

+ * This annotation is ignored for non-operation methods. + *

* * @author SERPRO - * */ @Documented -@Target({ElementType.PARAMETER}) +@Target({ ElementType.PARAMETER }) @Retention(RetentionPolicy.RUNTIME) public @interface OperationParameter { - + /** * Name that will be used to publish this operation's parameter to clients. */ @Nonbinding String name(); - + /** - * Optional description that will be used to publish this operation's parameter to clients. - * Defaults to an empty description. + * Optional description that will be used to publish this operation's parameter to clients. Defaults to an empty + * description. */ @Nonbinding String description() default ""; - } diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/OperationType.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/OperationType.java index 2df9ea4..f6d257c 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/OperationType.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/annotation/OperationType.java @@ -38,52 +38,50 @@ package br.gov.frameworkdemoiselle.annotation; import javax.management.MBeanOperationInfo; - /** - *

Define the operation type for an operation inside a ManagementController class.

- * - *

This is an optional annotation and it's significanse will change based on the management extension - * used. Most extensions will just publish this information to the client so it can better show to the user the inner - * workings of the annotated operation.

- * + *

+ * Define the operation type for an operation inside a ManagementController class. + *

+ *

+ * This is an optional annotation and it's significanse will change based on the management extension used. Most + * extensions will just publish this information to the client so it can better show to the user the inner workings of + * the annotated operation. + *

* * @author SERPRO - * */ public enum OperationType { - + /** - * ManagedOperation is write-only, it causes the application - * to change some of it's behaviour but doesn't return any kind of information + * ManagedOperation is write-only, it causes the application to change some of it's behaviour but doesn't return any + * kind of information */ - ACTION(MBeanOperationInfo.ACTION) - , + ACTION(MBeanOperationInfo.ACTION), /** * ManagedOperation is read-only, it will operate over data provided by the application and return some information, * but will not change the application in any way. */ - INFO(MBeanOperationInfo.INFO) - , + INFO(MBeanOperationInfo.INFO), /** - * ManagedOperation is read-write, it will both change the way the application work and return some information regarding - * the result of the operation. + * ManagedOperation is read-write, it will both change the way the application work and return some information + * regarding the result of the operation. */ - ACTION_INFO(MBeanOperationInfo.ACTION_INFO) - , + ACTION_INFO(MBeanOperationInfo.ACTION_INFO), /** - * The effect of calling this operation is unknown. This is the default type and if this type is assigned to an operation, - * the user must rely on the {@link ManagedOperation#description()} attribute to learn about how the operation works. + * The effect of calling this operation is unknown. This is the default type and if this type is assigned to an + * operation, the user must rely on the {@link ManagedOperation#description()} attribute to learn about how the + * operation works. */ UNKNOWN(MBeanOperationInfo.UNKNOWN); - + private int operationTypeValue; - - private OperationType(int type){ + + private OperationType(int type) { this.operationTypeValue = type; } - - public int getValue(){ + + public int getValue() { return operationTypeValue; } - + } diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/configuration/ConfigType.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/configuration/ConfigType.java index 648cf91..1091c5a 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/configuration/ConfigType.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/configuration/ConfigType.java @@ -57,5 +57,5 @@ public enum ConfigType { * Configuration loaded on properties resources. */ PROPERTIES; - + } diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/exception/ExceptionHandlerInterceptor.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/exception/ExceptionHandlerInterceptor.java index c9abc6b..5253a33 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/exception/ExceptionHandlerInterceptor.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/exception/ExceptionHandlerInterceptor.java @@ -52,9 +52,9 @@ import javax.interceptor.InvocationContext; import org.slf4j.Logger; import br.gov.frameworkdemoiselle.DemoiselleException; -import br.gov.frameworkdemoiselle.internal.producer.LoggerProducer; -import br.gov.frameworkdemoiselle.internal.producer.ResourceBundleProducer; import br.gov.frameworkdemoiselle.stereotype.Controller; +import br.gov.frameworkdemoiselle.util.Beans; +import br.gov.frameworkdemoiselle.util.NameQualifier; import br.gov.frameworkdemoiselle.util.ResourceBundle; @Interceptor @@ -63,9 +63,9 @@ public class ExceptionHandlerInterceptor implements Serializable { private static final long serialVersionUID = 1L; - private static ResourceBundle bundle; + private static transient ResourceBundle bundle; - private static Logger logger; + private static transient Logger logger; private final Map, Map, Method>> cache = new HashMap, Map, Method>>(); @@ -199,7 +199,7 @@ public class ExceptionHandlerInterceptor implements Serializable { private static ResourceBundle getBundle() { if (bundle == null) { - bundle = ResourceBundleProducer.create("demoiselle-core-bundle"); + bundle = Beans.getReference(ResourceBundle.class, new NameQualifier("demoiselle-core-bundle")); } return bundle; @@ -207,7 +207,7 @@ public class ExceptionHandlerInterceptor implements Serializable { private static Logger getLogger() { if (logger == null) { - logger = LoggerProducer.create(ExceptionHandlerInterceptor.class); + logger = Beans.getReference(Logger.class, new NameQualifier(ExceptionHandlerInterceptor.class.getName())); } return logger; diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/bootstrap/AbstractLifecycleBootstrap.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/bootstrap/AbstractLifecycleBootstrap.java index 732b52d..a441fbd 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/bootstrap/AbstractLifecycleBootstrap.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/bootstrap/AbstractLifecycleBootstrap.java @@ -110,10 +110,10 @@ public abstract class AbstractLifecycleBootstrap implement } public void loadTempContexts(@Observes final AfterBeanDiscovery event) { - //Caso este bootstrap rode antes do CoreBootstrap. Não há problemas em chamar este método várias vezes, ele - //ignora chamadas adicionais. + // Caso este bootstrap rode antes do CoreBootstrap. Não há problemas em chamar este método várias vezes, ele + // ignora chamadas adicionais. ContextManager.initialize(event); - + // Não registrar o contexto de aplicação pq ele já é registrado pela implementação do CDI ContextManager.add(new ThreadLocalContext(ViewScoped.class), event); ContextManager.add(new ThreadLocalContext(SessionScoped.class), event); diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/bootstrap/CustomInjectionPoint.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/bootstrap/CustomInjectionPoint.java deleted file mode 100644 index 8edc06d..0000000 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/bootstrap/CustomInjectionPoint.java +++ /dev/null @@ -1,136 +0,0 @@ -/* - * Demoiselle Framework - * Copyright (C) 2010 SERPRO - * ---------------------------------------------------------------------------- - * This file is part of Demoiselle Framework. - * - * Demoiselle Framework is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License version 3 - * as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public License version 3 - * along with this program; if not, see - * or write to the Free Software Foundation, Inc., 51 Franklin Street, - * Fifth Floor, Boston, MA 02110-1301, USA. - * ---------------------------------------------------------------------------- - * Este arquivo é parte do Framework Demoiselle. - * - * O Framework Demoiselle é um software livre; você pode redistribuí-lo e/ou - * modificá-lo dentro dos termos da GNU LGPL versão 3 como publicada pela Fundação - * do Software Livre (FSF). - * - * Este programa é distribuído na esperança que possa ser útil, mas SEM NENHUMA - * GARANTIA; sem uma garantia implícita de ADEQUAÇÃO a qualquer MERCADO ou - * APLICAÇÃO EM PARTICULAR. Veja a Licença Pública Geral GNU/LGPL em português - * para maiores detalhes. - * - * Você deve ter recebido uma cópia da GNU LGPL versão 3, sob o título - * "LICENCA.txt", junto com esse programa. Se não, acesse - * ou escreva para a Fundação do Software Livre (FSF) Inc., - * 51 Franklin St, Fifth Floor, Boston, MA 02111-1301, USA. - */ -package br.gov.frameworkdemoiselle.internal.bootstrap; - -import java.lang.annotation.Annotation; -import java.lang.reflect.Member; -import java.lang.reflect.Type; -import java.util.Arrays; -import java.util.HashSet; -import java.util.Set; - -import javax.enterprise.inject.spi.Annotated; -import javax.enterprise.inject.spi.Bean; -import javax.enterprise.inject.spi.InjectionPoint; - -public class CustomInjectionPoint implements InjectionPoint { - - private final Bean bean; - - private final Type beanType; - - private final Set qualifiers; - - public CustomInjectionPoint(Bean bean, Type beanType, Annotation... qualifiers) { - this.bean = bean; - this.beanType = beanType; - this.qualifiers = new HashSet(Arrays.asList(qualifiers)); - } - - @Override - public Type getType() { - return this.beanType; - } - - @Override - public Set getQualifiers() { - return this.qualifiers; - } - - @Override - public Bean getBean() { - return this.bean; - } - - @Override - public Member getMember() { - return null; - } - - @Override - public boolean isDelegate() { - return false; - } - - @Override - public boolean isTransient() { - return false; - } - - @Override - public Annotated getAnnotated() { - return new Annotated() { - - @Override - public Type getBaseType() { - // TODO Auto-generated method stub - return null; - } - - @Override - public Set getTypeClosure() { - // TODO Auto-generated method stub - return null; - } - - @Override - @SuppressWarnings("unchecked") - public T getAnnotation(Class annotationType) { - T result = null; - - for (Annotation annotation : getAnnotations()) { - if (annotation.annotationType() == annotationType) { - result = (T) annotation; - break; - } - } - - return result; - } - - @Override - public Set getAnnotations() { - return qualifiers; - } - - @Override - public boolean isAnnotationPresent(Class annotationType) { - return qualifiers.contains(annotationType); - } - }; - } -} diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/bootstrap/ManagementBootstrap.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/bootstrap/ManagementBootstrap.java index 3bcea0a..aca6e11 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/bootstrap/ManagementBootstrap.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/bootstrap/ManagementBootstrap.java @@ -32,8 +32,8 @@ public class ManagementBootstrap implements Extension { protected static List> types = Collections.synchronizedList(new ArrayList>()); - private List> managementExtensionCache = Collections.synchronizedList(new ArrayList>()); - + private List> managementExtensionCache = Collections + .synchronizedList(new ArrayList>()); public void detectAnnotation(@Observes final ProcessAnnotatedType event, final BeanManager beanManager) { if (event.getAnnotatedType().isAnnotationPresent(ManagementController.class)) { @@ -47,27 +47,28 @@ public class ManagementBootstrap implements Extension { } @SuppressWarnings("unchecked") - public void registerAvailableManagedTypes(@Observes final AfterDeploymentValidation event,BeanManager beanManager) { + public void registerAvailableManagedTypes(@Observes final AfterDeploymentValidation event, BeanManager beanManager) { ResourceBundle bundle = ResourceBundleProducer.create("demoiselle-core-bundle", Locale.getDefault()); Management monitoringManager = Beans.getReference(Management.class); for (AnnotatedType type : types) { - if (type.getJavaClass().isInterface() || Modifier.isAbstract(type.getJavaClass().getModifiers()) ){ - throw new DemoiselleException(bundle.getString("management-abstract-class-defined" , type.getJavaClass().getCanonicalName())); + if (type.getJavaClass().isInterface() || Modifier.isAbstract(type.getJavaClass().getModifiers())) { + throw new DemoiselleException(bundle.getString("management-abstract-class-defined", type.getJavaClass() + .getCanonicalName())); } ManagedType managedType = new ManagedType(type.getJavaClass()); monitoringManager.addManagedType(managedType); } - + Set> extensionBeans = beanManager.getBeans(ManagementExtension.class); - if (extensionBeans!=null){ - for (Bean bean : extensionBeans){ + if (extensionBeans != null) { + for (Bean bean : extensionBeans) { Class extensionConcreteClass = bean.getBeanClass(); managementExtensionCache.add((Class) extensionConcreteClass); } } - + monitoringManager.initialize(managementExtensionCache); } @@ -75,7 +76,7 @@ public class ManagementBootstrap implements Extension { Management manager = Beans.getReference(Management.class); manager.shutdown(managementExtensionCache); - + managementExtensionCache.clear(); types.clear(); } diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/context/ContextManager.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/context/ContextManager.java index 2e940f8..39ba5d1 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/context/ContextManager.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/context/ContextManager.java @@ -51,8 +51,9 @@ public class ContextManager { private static ResourceBundle bundle; private static Logger logger; - - private ContextManager(){} + + private ContextManager() { + } /** *

@@ -105,9 +106,9 @@ public class ContextManager { } ContextManager.getLogger().trace( - ContextManager.getBundle().getString("bootstrap-context-added", - context.getClass().getCanonicalName(), context.getScope().getCanonicalName())); - + ContextManager.getBundle().getString("bootstrap-context-added", context.getClass().getCanonicalName(), + context.getScope().getCanonicalName())); + context.setActive(false); event.addContext(context); contexts.add(new CustomContextCounter(context)); @@ -194,8 +195,10 @@ public class ContextManager { } /** - *

This method should be called when the application is shutting down, usually by observing - * the {@link BeforeShutdown} event.

+ *

+ * This method should be called when the application is shutting down, usually by observing the + * {@link BeforeShutdown} event. + *

*/ public static synchronized void shutdown() { for (CustomContextCounter context : contexts) { @@ -252,7 +255,7 @@ class CustomContextCounter { public CustomContext getInternalContext() { return this.context; } - + public void setInternalContext(CustomContext context) { this.context = context; } @@ -261,19 +264,14 @@ class CustomContextCounter { try { BeanManager beanManager = Beans.getReference(BeanManager.class); Context c = beanManager.getContext(context.getScope()); - - + if (c == context) { activationCounter++; - } - else{ + } else { ContextManager.getLogger().trace( ContextManager.getBundle().getString("custom-context-already-activated", - context.getClass().getCanonicalName() - ,c.getScope().getCanonicalName() - ,c.getClass().getCanonicalName() - ) - ); + context.getClass().getCanonicalName(), c.getScope().getCanonicalName(), + c.getClass().getCanonicalName())); } } catch (ContextNotActiveException ce) { context.setActive(true); @@ -299,10 +297,10 @@ class CustomContextCounter { } catch (ContextNotActiveException ce) { } } - + public synchronized void shutdown() { context.setActive(false); - context=null; - activationCounter=0; + context = null; + activationCounter = 0; } } diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/context/ManagedContext.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/context/ManagedContext.java index e07590c..404069e 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/context/ManagedContext.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/context/ManagedContext.java @@ -5,14 +5,13 @@ import javax.enterprise.context.RequestScoped; import br.gov.frameworkdemoiselle.stereotype.ManagementController; /** - * Context that stores {@link RequestScoped} beans during client calls to {@link ManagementController} classes. - * This context is only activated when no other context is active for {@link RequestScoped}. + * Context that stores {@link RequestScoped} beans during client calls to {@link ManagementController} classes. This + * context is only activated when no other context is active for {@link RequestScoped}. * * @author serpro - * */ public class ManagedContext extends ThreadLocalContext { - + /** * Constructs a new context. */ diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/context/ThreadLocalContext.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/context/ThreadLocalContext.java index 11ac567..b47bb60 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/context/ThreadLocalContext.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/context/ThreadLocalContext.java @@ -51,10 +51,9 @@ package br.gov.frameworkdemoiselle.internal.context; import java.lang.annotation.Annotation; /** - * Base context that has a separated store for each thread + * Base context that has a separated store for each thread * * @author serpro - * */ public class ThreadLocalContext extends AbstractCustomContext { diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/implementation/TransactionContextImpl.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/implementation/TransactionContextImpl.java index 22953bb..55be8bc 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/implementation/TransactionContextImpl.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/implementation/TransactionContextImpl.java @@ -55,7 +55,8 @@ public class TransactionContextImpl implements TransactionContext { private Transaction transaction; - private Transaction getTransaction() { + @Override + public Transaction getCurrentTransaction() { if (this.transaction == null) { Class clazz = getConfig().getTransactionClass(); @@ -69,11 +70,6 @@ public class TransactionContextImpl implements TransactionContext { return this.transaction; } - @Override - public Transaction getCurrentTransaction() { - return getTransaction(); - } - private TransactionConfig getConfig() { return Beans.getReference(TransactionConfig.class); } diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/interceptor/ExceptionHandlerInterceptor.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/interceptor/ExceptionHandlerInterceptor.java index 2bced44..1d318e0 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/interceptor/ExceptionHandlerInterceptor.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/interceptor/ExceptionHandlerInterceptor.java @@ -57,7 +57,7 @@ public class ExceptionHandlerInterceptor extends br.gov.frameworkdemoiselle.exce @Inject private Logger logger; - + @Override @AroundInvoke public Object manage(InvocationContext ic) throws Exception { @@ -65,4 +65,3 @@ public class ExceptionHandlerInterceptor extends br.gov.frameworkdemoiselle.exce return super.manage(ic); } } - diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/proxy/Slf4jLoggerProxy.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/proxy/Slf4jLoggerProxy.java index 504da1c..30e4c64 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/proxy/Slf4jLoggerProxy.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/internal/proxy/Slf4jLoggerProxy.java @@ -61,12 +61,12 @@ public class Slf4jLoggerProxy implements Logger, Serializable { private transient Logger delegate; private final Class type; - + private Logger getDelegate() { - if(delegate == null) { + if (delegate == null) { delegate = LoggerFactory.getLogger(type); } - + return delegate; } diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/lifecycle/ManagementExtension.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/lifecycle/ManagementExtension.java index ed8abf7..afe0cc8 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/lifecycle/ManagementExtension.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/lifecycle/ManagementExtension.java @@ -42,34 +42,36 @@ import br.gov.frameworkdemoiselle.internal.management.ManagedType; import br.gov.frameworkdemoiselle.stereotype.ManagementController; /** - * - *

Interface defining the lifecycle of a management extension, an extension - * capable of exposing {@link ManagementController}'s to external clients in one - * of the available management technologies, such as JMX or SNMP.

- * - *

To include a management extension into the management lifecycle, it just needs - * to implement this interface and be a CDI bean (have a beans.xml file inside - * the META-INF folder of it's java package). The Demoiselle Core lifecycle controller - * will call the {@link #initialize(List managedTypes)} and {@link #shutdown(List managedTypes)} methods at the apropriate times.

+ *

+ * Interface defining the lifecycle of a management extension, an extension capable of exposing + * {@link ManagementController}'s to external clients in one of the available management technologies, such as JMX or + * SNMP. + *

+ *

+ * To include a management extension into the management lifecycle, it just needs to implement this interface and be a + * CDI bean (have a beans.xml file inside the META-INF folder of it's java package). The Demoiselle Core + * lifecycle controller will call the {@link #initialize(List managedTypes)} and {@link #shutdown(List managedTypes)} + * methods at the apropriate times. + *

* * @author serpro - * */ public interface ManagementExtension { /** - * This method is called during the application initialization process for each concrete - * implementation of this interface. + * This method is called during the application initialization process for each concrete implementation of this + * interface. * - * @param managedTypes The list of discovered {@link ManagementController} classes. + * @param managedTypes + * The list of discovered {@link ManagementController} classes. */ void initialize(List managedTypes); /** - * This method is called during the application shutdown process for each concrete - * implementation of this interface. + * This method is called during the application shutdown process for each concrete implementation of this interface. * - * @param managedTypes The list of discovered {@link ManagementController} classes. + * @param managedTypes + * The list of discovered {@link ManagementController} classes. */ void shutdown(List managedTypes); diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/lifecycle/Shutdown.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/lifecycle/Shutdown.java index 82a8e13..e61975a 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/lifecycle/Shutdown.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/lifecycle/Shutdown.java @@ -48,17 +48,20 @@ import java.lang.annotation.Target; * Take a look at the following usage sample: *

*

+ * *
  * public class Finalizer {
  * 
- *   @Shutdown
+ * 	@Shutdown
  *   @Priority(5)
  *   public void finalize() {
  *       ...
  *    }
  * }
  * 
+ * 
  * 
+ * *
*

* diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/lifecycle/Startup.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/lifecycle/Startup.java index 1994f35..53cf974 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/lifecycle/Startup.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/lifecycle/Startup.java @@ -48,17 +48,20 @@ import java.lang.annotation.Target; * Take a look at the following usage sample: *

*

+ * *
  * public class Finalizer {
  * 
- *   @Startup
+ * 	@Startup
  *   @Priority(1)
  *   public void init() {
  *       ...
  *    }
  * }
  * 
+ * 
  * 
+ * *
*

* diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/pagination/Pagination.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/pagination/Pagination.java index a5b36cf..f16847c 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/pagination/Pagination.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/pagination/Pagination.java @@ -88,5 +88,5 @@ public interface Pagination { * Sets the position for the first record and hence calculates current page according to page size. */ void setFirstResult(int firstResult); - + } diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/pagination/PaginationContext.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/pagination/PaginationContext.java index f6e4519..e027abb 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/pagination/PaginationContext.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/pagination/PaginationContext.java @@ -51,7 +51,8 @@ public interface PaginationContext { /** * Retrieves the pagination according to the class type specified. * - * @param clazz a {@code Class} type + * @param clazz + * a {@code Class} type * @return Pagination */ Pagination getPagination(Class clazz); @@ -60,8 +61,10 @@ public interface PaginationContext { * Retrieves the pagination according to the class type specified. If not existing, creates the pagination whenever * {@code create} parameter is true. * - * @param clazz a {@code Class} type - * @param create determines whether pagination must always be returned + * @param clazz + * a {@code Class} type + * @param create + * determines whether pagination must always be returned * @return Pagination */ Pagination getPagination(Class clazz, boolean create); diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/Authenticator.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/Authenticator.java index 2ed232f..c803975 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/Authenticator.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/Authenticator.java @@ -49,7 +49,8 @@ public interface Authenticator extends Serializable { /** * Executes the necessary steps to authenticate an user. * - * @throws AuthenticationException When the authentication process fails, this exception is thrown. + * @throws AuthenticationException + * When the authentication process fails, this exception is thrown. */ void authenticate() throws AuthenticationException; diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/RequiredPermissionInterceptor.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/RequiredPermissionInterceptor.java index 188d2ae..0b674a7 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/RequiredPermissionInterceptor.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/RequiredPermissionInterceptor.java @@ -46,9 +46,8 @@ import javax.interceptor.InvocationContext; import org.slf4j.Logger; import br.gov.frameworkdemoiselle.annotation.Name; -import br.gov.frameworkdemoiselle.internal.producer.LoggerProducer; -import br.gov.frameworkdemoiselle.internal.producer.ResourceBundleProducer; import br.gov.frameworkdemoiselle.util.Beans; +import br.gov.frameworkdemoiselle.util.NameQualifier; import br.gov.frameworkdemoiselle.util.ResourceBundle; import br.gov.frameworkdemoiselle.util.Strings; @@ -63,9 +62,9 @@ public class RequiredPermissionInterceptor implements Serializable { private static final long serialVersionUID = 1L; - private static ResourceBundle bundle; + private static transient ResourceBundle bundle; - private static Logger logger; + private static transient Logger logger; /** * Gets the values for both resource and operation properties of {@code @RequiredPermission}. Delegates to @@ -168,7 +167,7 @@ public class RequiredPermissionInterceptor implements Serializable { private static ResourceBundle getBundle() { if (bundle == null) { - bundle = ResourceBundleProducer.create("demoiselle-core-bundle"); + bundle = Beans.getReference(ResourceBundle.class, new NameQualifier("demoiselle-core-bundle")); } return bundle; @@ -176,7 +175,7 @@ public class RequiredPermissionInterceptor implements Serializable { private static Logger getLogger() { if (logger == null) { - logger = LoggerProducer.create(RequiredPermissionInterceptor.class); + logger = Beans.getReference(Logger.class, new NameQualifier(RequiredPermissionInterceptor.class.getName())); } return logger; diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/RequiredRoleInterceptor.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/RequiredRoleInterceptor.java index e0da1d7..cfeabcb 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/RequiredRoleInterceptor.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/RequiredRoleInterceptor.java @@ -47,9 +47,8 @@ import javax.interceptor.InvocationContext; import org.slf4j.Logger; -import br.gov.frameworkdemoiselle.internal.producer.LoggerProducer; -import br.gov.frameworkdemoiselle.internal.producer.ResourceBundleProducer; import br.gov.frameworkdemoiselle.util.Beans; +import br.gov.frameworkdemoiselle.util.NameQualifier; import br.gov.frameworkdemoiselle.util.ResourceBundle; /** @@ -63,9 +62,9 @@ public class RequiredRoleInterceptor implements Serializable { private static final long serialVersionUID = 1L; - private static ResourceBundle bundle; + private static transient ResourceBundle bundle; - private static Logger logger; + private static transient Logger logger; /** * Gets the value property of {@code @RequiredRole}. Delegates to {@code SecurityContext} check role. If the user @@ -102,7 +101,6 @@ public class RequiredRoleInterceptor implements Serializable { .error(getBundle().getString("does-not-have-role", getSecurityContext().getCurrentUser().getName(), roles)); - // AuthorizationException a = new AuthorizationException(null); throw new AuthorizationException(getBundle().getString("does-not-have-role-ui", roles)); } @@ -139,7 +137,7 @@ public class RequiredRoleInterceptor implements Serializable { private static ResourceBundle getBundle() { if (bundle == null) { - bundle = ResourceBundleProducer.create("demoiselle-core-bundle"); + bundle = Beans.getReference(ResourceBundle.class, new NameQualifier("demoiselle-core-bundle")); } return bundle; @@ -147,7 +145,7 @@ public class RequiredRoleInterceptor implements Serializable { private static Logger getLogger() { if (logger == null) { - logger = LoggerProducer.create(RequiredRoleInterceptor.class); + logger = Beans.getReference(Logger.class, new NameQualifier(RequiredRoleInterceptor.class.getName())); } return logger; diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/User.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/User.java index 5280eb1..c191663 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/User.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/security/User.java @@ -41,7 +41,7 @@ import java.security.Principal; /** * @author SERPRO - * @deprecated + * @deprecated */ public interface User extends Principal, Serializable { diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/stereotype/ManagementController.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/stereotype/ManagementController.java index 89ff9b8..521545b 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/stereotype/ManagementController.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/stereotype/ManagementController.java @@ -49,17 +49,23 @@ import javax.enterprise.inject.Stereotype; import javax.enterprise.util.Nonbinding; /** - *

Identifies a management controller bean. What it means is that an external client can manage the application - * this class is in by reading or writing it's attributes and calling it's operations.

*

- * Only fields annotated with {@link br.gov.frameworkdemoiselle.annotation.ManagedProperty} or - * methods annotated with {@link br.gov.frameworkdemoiselle.annotation.ManagedOperation} will be exposed - * to clients.

- *

Only bean implementations (concrete classes) can be management controllers. It's a runtime error to mark an interface - * or abstract class with this annotation.

- *

This stereotype only defines a class as managed, you need to choose an extension that will expose this managed class + * Identifies a management controller bean. What it means is that an external client can manage the application + * this class is in by reading or writing it's attributes and calling it's operations. + *

+ *

+ * Only fields annotated with {@link br.gov.frameworkdemoiselle.annotation.ManagedProperty} or methods annotated with + * {@link br.gov.frameworkdemoiselle.annotation.ManagedOperation} will be exposed to clients. + *

+ *

+ * Only bean implementations (concrete classes) can be management controllers. It's a runtime error to mark an interface + * or abstract class with this annotation. + *

+ *

+ * This stereotype only defines a class as managed, you need to choose an extension that will expose this managed class * to external clients using any technology available. One example is the Demoiselle JMX extension, that will expose - * managed classes as MBeans.

+ * managed classes as MBeans. + *

* * @author SERPRO */ @@ -71,7 +77,7 @@ import javax.enterprise.util.Nonbinding; @Retention(RUNTIME) @Target({ TYPE }) public @interface ManagementController { - + /** * @return Human readable description of this managed class. */ diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/template/Crud.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/template/Crud.java index 9966e9b..3a39fd4 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/template/Crud.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/template/Crud.java @@ -43,16 +43,18 @@ import java.util.List; * Interface containing basic methods for creating, updating and deleting entities (the CRUD design pattern). * * @author serpro - * - * @param Type of the entity - * @param Type of the identification attribute of the entity + * @param + * Type of the entity + * @param + * Type of the identification attribute of the entity */ public interface Crud extends Serializable { /** * Find an entity by it's identification attribute and make it transient. * - * @param id The unique identification to find the entity to be deleted. + * @param id + * The unique identification to find the entity to be deleted. */ void delete(I id); @@ -66,24 +68,27 @@ public interface Crud extends Serializable { /** * Insert an entity and return the inserted instance of the entity * - * @param bean The bean to be inserted + * @param bean + * The bean to be inserted * @return The inserted instance of the entity */ T insert(T bean); /** * Find an entity's instance by it's identification attribute and return it - * @param id Value of the identification attribute of the desired entity's instance - * @return The entity's instance whose identification attribute's value matches - * the one passed as argument. + * + * @param id + * Value of the identification attribute of the desired entity's instance + * @return The entity's instance whose identification attribute's value matches the one passed as argument. */ T load(I id); /** - * Update an instance of the entity with the bean's attributes as new values. + * Update an instance of the entity with the bean's attributes as new values. * - * @param bean The bean instance containing both the identification value to find the old - * instance and the new values for the instance's attributes. + * @param bean + * The bean instance containing both the identification value to find the old instance and the new values + * for the instance's attributes. * @return The updated entity's instance */ T update(T bean); diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/template/DelegateCrud.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/template/DelegateCrud.java index 6735d91..291f7c0 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/template/DelegateCrud.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/template/DelegateCrud.java @@ -39,20 +39,15 @@ package br.gov.frameworkdemoiselle.template; import java.util.List; import java.util.ListIterator; -import br.gov.frameworkdemoiselle.internal.implementation.DefaultTransaction; -import br.gov.frameworkdemoiselle.transaction.Transaction; -import br.gov.frameworkdemoiselle.transaction.TransactionContext; -import br.gov.frameworkdemoiselle.transaction.Transactional; import br.gov.frameworkdemoiselle.util.Beans; import br.gov.frameworkdemoiselle.util.Reflections; /** - * An implementation of the {@link Crud} interface that delegates it's operations - * to another {@link Crud} implementation. + * An implementation of the {@link Crud} interface that delegates it's operations to another {@link Crud} + * implementation. * * @author serpro - * - * @param + * @param * bean object type * @param * bean id type @@ -75,19 +70,6 @@ public class DelegateCrud> implements Crud { */ @Override public void delete(final I id) { - if (isRunningTransactionalOperations()) { - transactionalDelete(id); - } else { - nonTransactionalDelete(id); - } - } - - @Transactional - private void transactionalDelete(final I id) { - nonTransactionalDelete(id); - } - - private void nonTransactionalDelete(final I id) { getDelegate().delete(id); } @@ -98,20 +80,8 @@ public class DelegateCrud> implements Crud { * List of entities identifiers */ public void delete(final List ids) { - if (isRunningTransactionalOperations()) { - transactionalDelete(ids); - } else { - nonTransactionalDelete(ids); - } - } - - @Transactional - private void transactionalDelete(final List ids) { - nonTransactionalDelete(ids); - } - - private void nonTransactionalDelete(final List ids) { ListIterator iter = ids.listIterator(); + while (iter.hasNext()) { this.delete(iter.next()); } @@ -151,19 +121,6 @@ public class DelegateCrud> implements Crud { */ @Override public T insert(final T bean) { - if (isRunningTransactionalOperations()) { - return transactionalInsert(bean); - } else { - return nonTransactionalInsert(bean); - } - } - - @Transactional - private T transactionalInsert(final T bean) { - return nonTransactionalInsert(bean); - } - - private T nonTransactionalInsert(final T bean) { return getDelegate().insert(bean); } @@ -185,24 +142,6 @@ public class DelegateCrud> implements Crud { */ @Override public T update(final T bean) { - if (isRunningTransactionalOperations()) { - return transactionalUpdate(bean); - } else { - return nonTransactionalUpdate(bean); - } - } - - @Transactional - private T transactionalUpdate(final T bean) { - return nonTransactionalUpdate(bean); - } - - private T nonTransactionalUpdate(final T bean) { return getDelegate().update(bean); } - - private boolean isRunningTransactionalOperations() { - Transaction transaction = Beans.getReference(TransactionContext.class).getCurrentTransaction(); - return !(transaction instanceof DefaultTransaction); - } } diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/transaction/TransactionalInterceptor.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/transaction/TransactionalInterceptor.java index 03b7fc9..63e3af7 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/transaction/TransactionalInterceptor.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/transaction/TransactionalInterceptor.java @@ -48,9 +48,8 @@ import javax.interceptor.InvocationContext; import org.slf4j.Logger; import br.gov.frameworkdemoiselle.exception.ApplicationException; -import br.gov.frameworkdemoiselle.internal.producer.LoggerProducer; -import br.gov.frameworkdemoiselle.internal.producer.ResourceBundleProducer; import br.gov.frameworkdemoiselle.util.Beans; +import br.gov.frameworkdemoiselle.util.NameQualifier; import br.gov.frameworkdemoiselle.util.ResourceBundle; @Interceptor @@ -63,9 +62,9 @@ public class TransactionalInterceptor implements Serializable { private TransactionInfo transactionInfo; - private static ResourceBundle bundle; + private static transient ResourceBundle bundle; - private static Logger logger; + private static transient Logger logger; private TransactionContext getTransactionContext() { if (this.transactionContext == null) { @@ -175,7 +174,7 @@ public class TransactionalInterceptor implements Serializable { private static ResourceBundle getBundle() { if (bundle == null) { - bundle = ResourceBundleProducer.create("demoiselle-core-bundle"); + bundle = Beans.getReference(ResourceBundle.class, new NameQualifier("demoiselle-core-bundle")); } return bundle; @@ -183,7 +182,7 @@ public class TransactionalInterceptor implements Serializable { private static Logger getLogger() { if (logger == null) { - logger = LoggerProducer.create(TransactionalInterceptor.class); + logger = Beans.getReference(Logger.class, new NameQualifier(TransactionalInterceptor.class.getName())); } return logger; diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/util/Beans.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/util/Beans.java index 3c4b1d0..69ea286 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/util/Beans.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/util/Beans.java @@ -37,22 +37,25 @@ package br.gov.frameworkdemoiselle.util; import java.lang.annotation.Annotation; +import java.lang.reflect.Member; import java.lang.reflect.Type; -import java.util.Locale; +import java.util.Arrays; +import java.util.HashSet; import java.util.NoSuchElementException; import java.util.Set; import javax.enterprise.context.spi.CreationalContext; +import javax.enterprise.inject.spi.Annotated; import javax.enterprise.inject.spi.Bean; import javax.enterprise.inject.spi.BeanManager; import javax.enterprise.inject.spi.InjectionPoint; import br.gov.frameworkdemoiselle.DemoiselleException; -import br.gov.frameworkdemoiselle.internal.bootstrap.CustomInjectionPoint; -import br.gov.frameworkdemoiselle.internal.producer.ResourceBundleProducer; public final class Beans { + private static transient ResourceBundle bundle; + private static BeanManager manager; private Beans() { @@ -132,6 +135,98 @@ public final class Beans { } private static ResourceBundle getBundle() { - return ResourceBundleProducer.create("demoiselle-core-bundle", Locale.getDefault()); + if (bundle == null) { + bundle = Beans.getReference(ResourceBundle.class, new NameQualifier("demoiselle-core-bundle")); + } + + return bundle; + } + + static class CustomInjectionPoint implements InjectionPoint { + + private final Bean bean; + + private final Type beanType; + + private final Set qualifiers; + + public CustomInjectionPoint(Bean bean, Type beanType, Annotation... qualifiers) { + this.bean = bean; + this.beanType = beanType; + this.qualifiers = new HashSet(Arrays.asList(qualifiers)); + } + + @Override + public Type getType() { + return this.beanType; + } + + @Override + public Set getQualifiers() { + return this.qualifiers; + } + + @Override + public Bean getBean() { + return this.bean; + } + + @Override + public Member getMember() { + return null; + } + + @Override + public boolean isDelegate() { + return false; + } + + @Override + public boolean isTransient() { + return false; + } + + @Override + public Annotated getAnnotated() { + return new Annotated() { + + @Override + public Type getBaseType() { + // TODO Auto-generated method stub + return null; + } + + @Override + public Set getTypeClosure() { + // TODO Auto-generated method stub + return null; + } + + @Override + @SuppressWarnings("unchecked") + public T getAnnotation(Class annotationType) { + T result = null; + + for (Annotation annotation : getAnnotations()) { + if (annotation.annotationType() == annotationType) { + result = (T) annotation; + break; + } + } + + return result; + } + + @Override + public Set getAnnotations() { + return qualifiers; + } + + @Override + public boolean isAnnotationPresent(Class annotationType) { + return qualifiers.contains(annotationType); + } + }; + } } } diff --git a/impl/core/src/test/java/configuration/field/beanvalidation/BeanValidationWithEmptyNotNullFieldConfig.java b/impl/core/src/test/java/configuration/field/beanvalidation/BeanValidationWithEmptyNotNullFieldConfig.java index 8d66090..2dc4e7e 100644 --- a/impl/core/src/test/java/configuration/field/beanvalidation/BeanValidationWithEmptyNotNullFieldConfig.java +++ b/impl/core/src/test/java/configuration/field/beanvalidation/BeanValidationWithEmptyNotNullFieldConfig.java @@ -42,14 +42,14 @@ public abstract class BeanValidationWithEmptyNotNullFieldConfig { @NotNull private Integer intAttributeNull; - + @NotNull private String stringAttributeNull; - + public Integer getIntAttributeNull() { return intAttributeNull; } - + public String getStringAttributeNull() { return stringAttributeNull; } diff --git a/impl/core/src/test/java/configuration/field/beanvalidation/BeanValidationWithFilledNotNullFieldConfig.java b/impl/core/src/test/java/configuration/field/beanvalidation/BeanValidationWithFilledNotNullFieldConfig.java index 05188b0..15f60ca 100644 --- a/impl/core/src/test/java/configuration/field/beanvalidation/BeanValidationWithFilledNotNullFieldConfig.java +++ b/impl/core/src/test/java/configuration/field/beanvalidation/BeanValidationWithFilledNotNullFieldConfig.java @@ -6,14 +6,14 @@ public class BeanValidationWithFilledNotNullFieldConfig { @NotNull private String stringAttributeNotNull; - + @NotNull private Integer intAttibuteNotNull; - + public String getStringAttributeNotNull() { return stringAttributeNotNull; } - + public Integer getIntAttibuteNotNull() { return intAttibuteNotNull; } diff --git a/impl/core/src/test/java/configuration/field/beanvalidation/ConfigurationBeanValidationFieldTest.java b/impl/core/src/test/java/configuration/field/beanvalidation/ConfigurationBeanValidationFieldTest.java index 4bc2826..acec664 100644 --- a/impl/core/src/test/java/configuration/field/beanvalidation/ConfigurationBeanValidationFieldTest.java +++ b/impl/core/src/test/java/configuration/field/beanvalidation/ConfigurationBeanValidationFieldTest.java @@ -80,7 +80,8 @@ public class ConfigurationBeanValidationFieldTest { JavaArchive deployment = Tests.createDeployment(ConfigurationBeanValidationFieldTest.class); deployment.addAsResource(Tests.createFileAsset(PATH + "/demoiselle.properties"), "demoiselle.properties"); deployment.addAsResource(Tests.createFileAsset(PATH + "/demoiselle.xml"), "demoiselle.xml"); - deployment.addAsResource(Tests.createFileAsset(PATH + "/two-constrain-validation.properties"), "two-constrain-validation.properties"); + deployment.addAsResource(Tests.createFileAsset(PATH + "/two-constrain-validation.properties"), + "two-constrain-validation.properties"); return deployment; } @@ -136,7 +137,7 @@ public class ConfigurationBeanValidationFieldTest { } @Test - public void loadPropertiesWithTwoConstraintViolations(){ + public void loadPropertiesWithTwoConstraintViolations() { try { propertyWithTwoConstrainViolations.getAttributeWithTwoConstrainValidations(); fail(); diff --git a/impl/core/src/test/java/configuration/field/clazz/AbstractClassNotFoundFieldConfig.java b/impl/core/src/test/java/configuration/field/clazz/AbstractClassNotFoundFieldConfig.java index 14b3e6a..f45ae69 100644 --- a/impl/core/src/test/java/configuration/field/clazz/AbstractClassNotFoundFieldConfig.java +++ b/impl/core/src/test/java/configuration/field/clazz/AbstractClassNotFoundFieldConfig.java @@ -41,7 +41,7 @@ public abstract class AbstractClassNotFoundFieldConfig { private Class nonExistentTypedClass; private Class nonExistentUntypedClass; - + public Class getNonExistentTypedClass() { return nonExistentTypedClass; } diff --git a/impl/core/src/test/java/configuration/field/clazz/PropertiesNullClassFieldConfig.java b/impl/core/src/test/java/configuration/field/clazz/PropertiesNullClassFieldConfig.java index cc51f30..bb287a3 100644 --- a/impl/core/src/test/java/configuration/field/clazz/PropertiesNullClassFieldConfig.java +++ b/impl/core/src/test/java/configuration/field/clazz/PropertiesNullClassFieldConfig.java @@ -40,9 +40,9 @@ import br.gov.frameworkdemoiselle.configuration.Configuration; @Configuration public class PropertiesNullClassFieldConfig { - + private Class nullClass; - + public Class getNullClass() { return nullClass; } diff --git a/impl/core/src/test/java/configuration/field/map/AbstractMapFieldConfig.java b/impl/core/src/test/java/configuration/field/map/AbstractMapFieldConfig.java index 1bd787b..34c50f9 100644 --- a/impl/core/src/test/java/configuration/field/map/AbstractMapFieldConfig.java +++ b/impl/core/src/test/java/configuration/field/map/AbstractMapFieldConfig.java @@ -45,7 +45,7 @@ public abstract class AbstractMapFieldConfig { private Map stringWithUndefinedKeyMap; private Map emptyValueMap; - + private Map NullMapValue; public Map getStringWithUndefinedKeyMap() { diff --git a/impl/core/src/test/java/configuration/field/map/ConfigurationMapFieldTest.java b/impl/core/src/test/java/configuration/field/map/ConfigurationMapFieldTest.java index 3e8d409..ef8bd33 100644 --- a/impl/core/src/test/java/configuration/field/map/ConfigurationMapFieldTest.java +++ b/impl/core/src/test/java/configuration/field/map/ConfigurationMapFieldTest.java @@ -99,9 +99,9 @@ public class ConfigurationMapFieldTest { assertEquals(expected, propertiesConfig.getEmptyValueMap()); assertEquals(expected, xmlConfig.getEmptyValueMap()); } - + @Test - public void loadNullMap(){ + public void loadNullMap() { assertNull(propertiesConfig.getNullMapValue()); assertNull(xmlConfig.getNullMapValue()); } diff --git a/impl/core/src/test/java/configuration/field/primitiveorwrapper/AbstractPrimitiveOrWrapperErrorFieldConfig.java b/impl/core/src/test/java/configuration/field/primitiveorwrapper/AbstractPrimitiveOrWrapperErrorFieldConfig.java index 420f927..22cf7bd 100644 --- a/impl/core/src/test/java/configuration/field/primitiveorwrapper/AbstractPrimitiveOrWrapperErrorFieldConfig.java +++ b/impl/core/src/test/java/configuration/field/primitiveorwrapper/AbstractPrimitiveOrWrapperErrorFieldConfig.java @@ -45,7 +45,7 @@ public abstract class AbstractPrimitiveOrWrapperErrorFieldConfig { private Integer emptyWrappedField; private Integer conversionErrorWrappedField; - + public int getEmptyPrimitiveField() { return emptyPrimitiveField; } diff --git a/impl/core/src/test/java/configuration/field/primitiveorwrapper/ConfigurationPrimitiveOrWrapperFieldTest.java b/impl/core/src/test/java/configuration/field/primitiveorwrapper/ConfigurationPrimitiveOrWrapperFieldTest.java index ea0af44..ea84e02 100644 --- a/impl/core/src/test/java/configuration/field/primitiveorwrapper/ConfigurationPrimitiveOrWrapperFieldTest.java +++ b/impl/core/src/test/java/configuration/field/primitiveorwrapper/ConfigurationPrimitiveOrWrapperFieldTest.java @@ -78,7 +78,7 @@ public class ConfigurationPrimitiveOrWrapperFieldTest { @Inject private PropertiesNullWrappedField nullWrappedField; - + @Deployment public static JavaArchive createDeployment() { JavaArchive deployment = Tests.createDeployment(ConfigurationPrimitiveOrWrapperFieldTest.class); @@ -210,9 +210,9 @@ public class ConfigurationPrimitiveOrWrapperFieldTest { assertEquals(ConversionException.class, cause.getCause().getClass()); } } - + @Test - public void loadNullWrappedField(){ + public void loadNullWrappedField() { assertNull(nullWrappedField.getNullWrappedField()); } } diff --git a/impl/core/src/test/java/configuration/field/primitiveorwrapper/PropertiesNullWrappedField.java b/impl/core/src/test/java/configuration/field/primitiveorwrapper/PropertiesNullWrappedField.java index 85656ad..aa75173 100644 --- a/impl/core/src/test/java/configuration/field/primitiveorwrapper/PropertiesNullWrappedField.java +++ b/impl/core/src/test/java/configuration/field/primitiveorwrapper/PropertiesNullWrappedField.java @@ -6,7 +6,7 @@ import br.gov.frameworkdemoiselle.configuration.Configuration; public class PropertiesNullWrappedField { private Integer nullWrappedField; - + public Integer getNullWrappedField() { return nullWrappedField; } diff --git a/impl/core/src/test/java/configuration/field/string/AbstractNullStringFieldConfig.java b/impl/core/src/test/java/configuration/field/string/AbstractNullStringFieldConfig.java index 8386fd2..f3a143b 100644 --- a/impl/core/src/test/java/configuration/field/string/AbstractNullStringFieldConfig.java +++ b/impl/core/src/test/java/configuration/field/string/AbstractNullStringFieldConfig.java @@ -1,6 +1,5 @@ package configuration.field.string; - public class AbstractNullStringFieldConfig { private String nullString; diff --git a/impl/core/src/test/java/configuration/field/string/ConfigurationStringFieldTest.java b/impl/core/src/test/java/configuration/field/string/ConfigurationStringFieldTest.java index 49a4342..5b333d8 100644 --- a/impl/core/src/test/java/configuration/field/string/ConfigurationStringFieldTest.java +++ b/impl/core/src/test/java/configuration/field/string/ConfigurationStringFieldTest.java @@ -63,7 +63,7 @@ public class ConfigurationStringFieldTest { @Inject private SystemStringFieldConfig systemConfig; - + @Inject private PropertiesNullStringFieldConfig propertiesNullConfig; @@ -113,9 +113,9 @@ public class ConfigurationStringFieldTest { assertEquals(expected, propertiesConfig.getEmptyString()); assertEquals(expected, xmlConfig.getEmptyString()); } - + @Test - public void loadNullString(){ + public void loadNullString() { assertNull(propertiesNullConfig.getNullString()); assertNull(xmlNullConfig.getNullString()); assertNull(systemNullConfig.getNullString()); diff --git a/impl/core/src/test/java/exception/basic/ExceptionClassNotAnnotated.java b/impl/core/src/test/java/exception/basic/ExceptionClassNotAnnotated.java index 9cafa55..cd24578 100644 --- a/impl/core/src/test/java/exception/basic/ExceptionClassNotAnnotated.java +++ b/impl/core/src/test/java/exception/basic/ExceptionClassNotAnnotated.java @@ -41,7 +41,7 @@ import br.gov.frameworkdemoiselle.exception.ExceptionHandler; public class ExceptionClassNotAnnotated { private boolean nullPointerExceptionHandler = false; - + public boolean isNullPointerExceptionHandler() { return nullPointerExceptionHandler; } diff --git a/impl/core/src/test/java/exception/basic/ExceptionHandlerTest.java b/impl/core/src/test/java/exception/basic/ExceptionHandlerTest.java index 55c0097..e8142ac 100644 --- a/impl/core/src/test/java/exception/basic/ExceptionHandlerTest.java +++ b/impl/core/src/test/java/exception/basic/ExceptionHandlerTest.java @@ -64,7 +64,7 @@ public class ExceptionHandlerTest { @Inject private ExceptionNested nested; - + @Inject private ExceptionClassNotAnnotated classNotAnnotated; @@ -127,7 +127,7 @@ public class ExceptionHandlerTest { assertEquals(false, nested.isExceptionHandler()); } } - + @Test public void exceptionClassNotAnnotatedController() { try { diff --git a/impl/core/src/test/java/exception/basic/SimpleExceptionHandler.java b/impl/core/src/test/java/exception/basic/SimpleExceptionHandler.java index ece182b..f8ef5eb 100644 --- a/impl/core/src/test/java/exception/basic/SimpleExceptionHandler.java +++ b/impl/core/src/test/java/exception/basic/SimpleExceptionHandler.java @@ -45,7 +45,7 @@ public class SimpleExceptionHandler { private boolean nullPointerExceptionHandler = false; private boolean arithmeticExceptionHandler = false; - + public boolean isNullPointerExceptionHandler() { return nullPointerExceptionHandler; } @@ -53,7 +53,7 @@ public class SimpleExceptionHandler { public boolean isArithmeticExceptionHandler() { return arithmeticExceptionHandler; } - + public void throwNullPointerException() { throw new NullPointerException(); } @@ -61,11 +61,11 @@ public class SimpleExceptionHandler { public void throwArithmeticException() { throw new ArithmeticException(); } - + public void throwExceptionWithoutHandler() { throw new IllegalArgumentException(); - } - + } + @SuppressWarnings({ "null", "unused" }) public void throwTwoException() { String txt = null; @@ -81,5 +81,5 @@ public class SimpleExceptionHandler { @ExceptionHandler public void handler(ArithmeticException cause) { arithmeticExceptionHandler = true; - } + } } diff --git a/impl/core/src/test/java/exception/custom/CustomExceptionHandler.java b/impl/core/src/test/java/exception/custom/CustomExceptionHandler.java index baf8512..c053b5a 100644 --- a/impl/core/src/test/java/exception/custom/CustomExceptionHandler.java +++ b/impl/core/src/test/java/exception/custom/CustomExceptionHandler.java @@ -50,12 +50,12 @@ public class CustomExceptionHandler { public void setExceptionHandler(boolean exceptionHandler) { this.exceptionHandler = exceptionHandler; - } - + } + public void throwExceptionWithMessage() { throw new CustomException(); } - + @ExceptionHandler public void handler(CustomException exception) { setExceptionHandler(true); diff --git a/impl/core/src/test/java/lifecycle/shutdown/priority/ShutdownWithPriority.java b/impl/core/src/test/java/lifecycle/shutdown/priority/ShutdownWithPriority.java index 6b8e764..077968f 100644 --- a/impl/core/src/test/java/lifecycle/shutdown/priority/ShutdownWithPriority.java +++ b/impl/core/src/test/java/lifecycle/shutdown/priority/ShutdownWithPriority.java @@ -51,7 +51,7 @@ import br.gov.frameworkdemoiselle.lifecycle.Shutdown; public class ShutdownWithPriority { private List listShutdown = new ArrayList(); - + public List getListShutdown() { return listShutdown; } @@ -67,7 +67,7 @@ public class ShutdownWithPriority { public void unloadWithPriority1() { listShutdown.add(2); } - + @Shutdown @Priority(MAX_PRIORITY) public void unloadWithMaxPriority() { diff --git a/impl/core/src/test/java/lifecycle/shutdown/simple/ShutdownSimple.java b/impl/core/src/test/java/lifecycle/shutdown/simple/ShutdownSimple.java index b6a5359..b8b7680 100644 --- a/impl/core/src/test/java/lifecycle/shutdown/simple/ShutdownSimple.java +++ b/impl/core/src/test/java/lifecycle/shutdown/simple/ShutdownSimple.java @@ -47,11 +47,11 @@ import br.gov.frameworkdemoiselle.lifecycle.Shutdown; public class ShutdownSimple { private List listShutdown = new ArrayList(); - + public List getListShutdown() { return listShutdown; } - + @Shutdown public void unloadWithoutPriorityFirst() { listShutdown.add(3); diff --git a/impl/core/src/test/java/lifecycle/startup/priority/StartupWithPriorityTest.java b/impl/core/src/test/java/lifecycle/startup/priority/StartupWithPriorityTest.java index 1ef19ef..be174b4 100644 --- a/impl/core/src/test/java/lifecycle/startup/priority/StartupWithPriorityTest.java +++ b/impl/core/src/test/java/lifecycle/startup/priority/StartupWithPriorityTest.java @@ -73,7 +73,7 @@ public class StartupWithPriorityTest { Beans.getBeanManager().fireEvent(new AfterStartupProccess() { }); } - + @Test public void startupWithPriority() { expected.add(1); diff --git a/impl/core/src/test/java/lifecycle/startup/simple/StartupSimple.java b/impl/core/src/test/java/lifecycle/startup/simple/StartupSimple.java index bdcb821..760476b 100644 --- a/impl/core/src/test/java/lifecycle/startup/simple/StartupSimple.java +++ b/impl/core/src/test/java/lifecycle/startup/simple/StartupSimple.java @@ -65,5 +65,5 @@ public class StartupSimple { @Startup public void loadWithoutPriorityThird() { listStartup.add(2); - } + } } diff --git a/impl/core/src/test/java/lifecycle/startup/simple/StartupSimpleTest.java b/impl/core/src/test/java/lifecycle/startup/simple/StartupSimpleTest.java index 007993e..4305d60 100644 --- a/impl/core/src/test/java/lifecycle/startup/simple/StartupSimpleTest.java +++ b/impl/core/src/test/java/lifecycle/startup/simple/StartupSimpleTest.java @@ -59,9 +59,9 @@ public class StartupSimpleTest { @Inject private StartupSimple startupSimple; - + List expected = new ArrayList(); - + @Deployment public static JavaArchive createDeployment() { JavaArchive deployment = Tests.createDeployment(StartupSimpleTest.class); @@ -73,7 +73,7 @@ public class StartupSimpleTest { Beans.getBeanManager().fireEvent(new AfterStartupProccess() { }); } - + @Test public void startup() { expected.add(1); @@ -83,4 +83,3 @@ public class StartupSimpleTest { Assert.assertEquals(expected, startupSimple.getListStartup()); } } - diff --git a/impl/core/src/test/java/resourcebundle/file/defaultfile/ResourceBundleDefaultTest.java b/impl/core/src/test/java/resourcebundle/file/defaultfile/ResourceBundleDefaultTest.java index 9842a87..2852e65 100644 --- a/impl/core/src/test/java/resourcebundle/file/defaultfile/ResourceBundleDefaultTest.java +++ b/impl/core/src/test/java/resourcebundle/file/defaultfile/ResourceBundleDefaultTest.java @@ -67,23 +67,23 @@ public class ResourceBundleDefaultTest { @Test public void loadResourceDefault() { - Locale.setDefault(new Locale("pt", "BR")); + Locale.setDefault(new Locale("pt", "BR")); bundleDefault = Beans.getReference(ResourceBundleDefault.class); Assert.assertEquals("mensagem em Portugues", bundleDefault.getMessage()); } @Test public void loadResourceDefaultEnglish() { - Locale.setDefault(Locale.US); + Locale.setDefault(Locale.US); bundleDefault = Beans.getReference(ResourceBundleDefault.class); Assert.assertEquals("message in English", bundleDefault.getMessage()); } - + @Test public void loadResourceWithLocaleNotExist() { Locale.setDefault(Locale.ITALY); bundleDefault = Beans.getReference(ResourceBundleDefault.class); Assert.assertEquals("mensagem em Portugues", bundleDefault.getMessage()); - } + } } diff --git a/impl/core/src/test/java/resourcebundle/parameter/ResourceBundleWithParameterTest.java b/impl/core/src/test/java/resourcebundle/parameter/ResourceBundleWithParameterTest.java index c830579..c9d8088 100644 --- a/impl/core/src/test/java/resourcebundle/parameter/ResourceBundleWithParameterTest.java +++ b/impl/core/src/test/java/resourcebundle/parameter/ResourceBundleWithParameterTest.java @@ -77,7 +77,7 @@ public class ResourceBundleWithParameterTest { String value = bundleCustom.getBundle().getString("messageTwoParameter", "1", "2"); Assert.assertEquals(expected, value); } - + @Test public void loadKeyWithoutParameter() { bundleCustom = Beans.getReference(ResourceBundleWithParameter.class); @@ -85,15 +85,15 @@ public class ResourceBundleWithParameterTest { String value = bundleCustom.getBundle().getString("messageWithoutParameter", "1", "2", "3"); Assert.assertEquals(expected, value); } - + @Test public void loadKeyWithStringParameter() { bundleCustom = Beans.getReference(ResourceBundleWithParameter.class); String expected = "Mensagem número 1"; String value = bundleCustom.getBundle().getString("messageParameterString", "1"); Assert.assertNotSame(expected, value); - - expected = "Mensagem número {numero}"; + + expected = "Mensagem número {numero}"; Assert.assertEquals(expected, value); } diff --git a/impl/core/src/test/java/security/athentication/custom/CustomAuthenticatorTest.java b/impl/core/src/test/java/security/athentication/custom/CustomAuthenticatorTest.java index c95437f..4cb6161 100644 --- a/impl/core/src/test/java/security/athentication/custom/CustomAuthenticatorTest.java +++ b/impl/core/src/test/java/security/athentication/custom/CustomAuthenticatorTest.java @@ -83,24 +83,24 @@ public class CustomAuthenticatorTest { @Test public void loginProcess() { ContextManager.activate(ThreadLocalContext.class, RequestScoped.class); - + context.login(); assertTrue(context.isLoggedIn()); assertNotNull(observer.getEvent()); assertEquals("demoiselle", context.getCurrentUser().getName()); - + ContextManager.deactivate(ThreadLocalContext.class, RequestScoped.class); } @Test public void logoutProcess() { ContextManager.activate(ThreadLocalContext.class, RequestScoped.class); - + context.login(); context.logout(); assertFalse(context.isLoggedIn()); assertNull(context.getCurrentUser()); - + ContextManager.deactivate(ThreadLocalContext.class, RequestScoped.class); } } diff --git a/impl/core/src/test/java/test/Tests.java b/impl/core/src/test/java/test/Tests.java index b16ce3c..206a211 100644 --- a/impl/core/src/test/java/test/Tests.java +++ b/impl/core/src/test/java/test/Tests.java @@ -47,7 +47,7 @@ public final class Tests { private Tests() { } - public static JavaArchive createDeployment(Class baseClass) { + public static JavaArchive createDeployment(final Class baseClass) { return createDeployment().addPackages(true, baseClass.getPackage()); } @@ -62,7 +62,7 @@ public final class Tests { "services/javax.enterprise.inject.spi.Extension"); } - public static FileAsset createFileAsset(String pathname) { + public static FileAsset createFileAsset(final String pathname) { return new FileAsset(new File(pathname)); } } diff --git a/impl/core/src/test/java/transaction/rollback/DummyStrategy.java b/impl/core/src/test/java/transaction/rollback/DummyStrategy.java index 3e0217f..27b3283 100644 --- a/impl/core/src/test/java/transaction/rollback/DummyStrategy.java +++ b/impl/core/src/test/java/transaction/rollback/DummyStrategy.java @@ -41,7 +41,7 @@ import br.gov.frameworkdemoiselle.transaction.Transaction; public class DummyStrategy implements Transaction { private static final long serialVersionUID = 1L; - + private boolean markedRollback = false; private boolean active = false; diff --git a/impl/core/src/test/java/transaction/rollback/TransactionManager.java b/impl/core/src/test/java/transaction/rollback/TransactionManager.java index f8fe298..c21bc13 100644 --- a/impl/core/src/test/java/transaction/rollback/TransactionManager.java +++ b/impl/core/src/test/java/transaction/rollback/TransactionManager.java @@ -97,35 +97,35 @@ public class TransactionManager { return transactionPassedInSetRollbackOnlyMethod; } - public static void setTransactionMarkedRollback(boolean markedRollback) { + public static void setTransactionMarkedRollback(final boolean markedRollback) { transactionMarkedRollback = markedRollback; } - public static void setTransactionActive(boolean active) { + public static void setTransactionActive(final boolean active) { transactionActive = active; } - public static void setTransactionPassedInIsActiveMethod(boolean passedInIsActiveMethod) { + public static void setTransactionPassedInIsActiveMethod(final boolean passedInIsActiveMethod) { transactionPassedInIsActiveMethod = passedInIsActiveMethod; } - public static void setTransactionPassedInIsMarkedRollbackMethod(boolean passedInIsMarkedRollbackMethod) { + public static void setTransactionPassedInIsMarkedRollbackMethod(final boolean passedInIsMarkedRollbackMethod) { transactionPassedInIsMarkedRollbackMethod = passedInIsMarkedRollbackMethod; } - public static void setTransactionPassedInBeginMethod(boolean passedInBeginMethod) { + public static void setTransactionPassedInBeginMethod(final boolean passedInBeginMethod) { transactionPassedInBeginMethod = passedInBeginMethod; } - public static void setTransactionPassedInCommitMethod(boolean passedInCommitMethod) { + public static void setTransactionPassedInCommitMethod(final boolean passedInCommitMethod) { transactionPassedInCommitMethod = passedInCommitMethod; } - public static void setTransactionPassedInRollbackMethod(boolean passedInRollbackMethod) { + public static void setTransactionPassedInRollbackMethod(final boolean passedInRollbackMethod) { transactionPassedInRollbackMethod = passedInRollbackMethod; } - public static void setTransactionPassedInSetRollbackOnlyMethod(boolean passedInSetRollbackOnlyMethod) { + public static void setTransactionPassedInSetRollbackOnlyMethod(final boolean passedInSetRollbackOnlyMethod) { transactionPassedInSetRollbackOnlyMethod = passedInSetRollbackOnlyMethod; } } diff --git a/impl/core/src/test/java/transaction/rollback/TransactionManagerWithDefaultRollback.java b/impl/core/src/test/java/transaction/rollback/TransactionManagerWithDefaultRollback.java index eef61ce..ab167d7 100644 --- a/impl/core/src/test/java/transaction/rollback/TransactionManagerWithDefaultRollback.java +++ b/impl/core/src/test/java/transaction/rollback/TransactionManagerWithDefaultRollback.java @@ -41,8 +41,8 @@ import br.gov.frameworkdemoiselle.stereotype.Controller; import br.gov.frameworkdemoiselle.transaction.Transactional; @Controller -public class TransactionManagerWithDefaultRollback extends TransactionManager{ - +public class TransactionManagerWithDefaultRollback extends TransactionManager { + @Transactional public void insert() { throw new TransactionExceptionWithDefaultRollback(); diff --git a/impl/core/src/test/java/transaction/rollback/TransactionManagerWithRollback.java b/impl/core/src/test/java/transaction/rollback/TransactionManagerWithRollback.java index 8b0a359..72fc776 100644 --- a/impl/core/src/test/java/transaction/rollback/TransactionManagerWithRollback.java +++ b/impl/core/src/test/java/transaction/rollback/TransactionManagerWithRollback.java @@ -41,7 +41,7 @@ import br.gov.frameworkdemoiselle.stereotype.Controller; import br.gov.frameworkdemoiselle.transaction.Transactional; @Controller -public class TransactionManagerWithRollback extends TransactionManager{ +public class TransactionManagerWithRollback extends TransactionManager { @Transactional public void insert() { diff --git a/impl/core/src/test/java/transaction/rollback/TransactionRollbackTest.java b/impl/core/src/test/java/transaction/rollback/TransactionRollbackTest.java index 88e7c71..8130f18 100644 --- a/impl/core/src/test/java/transaction/rollback/TransactionRollbackTest.java +++ b/impl/core/src/test/java/transaction/rollback/TransactionRollbackTest.java @@ -58,16 +58,16 @@ import br.gov.frameworkdemoiselle.internal.context.ManagedContext; @RunWith(Arquillian.class) public class TransactionRollbackTest { - + @Inject private TransactionManagerWithDefaultRollback managerWithDefaultRollback; - + @Inject private TransactionManagerWithRollback managerWithRollback; - + @Inject private TransactionManagerWithoutRollback managerWithoutRollback; - + @Deployment public static JavaArchive createDeployment() { JavaArchive deployment = Tests.createDeployment(TransactionRollbackTest.class); @@ -78,19 +78,19 @@ public class TransactionRollbackTest { public void activeContext() { ContextManager.activate(ManagedContext.class, RequestScoped.class); } - + @After - public void deactiveContext(){ + public void deactiveContext() { ContextManager.deactivate(ManagedContext.class, RequestScoped.class); } - + @Test - public void transactionWithDefaultRollback(){ - try{ + public void transactionWithDefaultRollback() { + try { managerWithDefaultRollback.clean(); managerWithDefaultRollback.insert(); fail(); - }catch(TransactionExceptionWithDefaultRollback exception){ + } catch (TransactionExceptionWithDefaultRollback exception) { assertTrue(managerWithDefaultRollback.isTransactionPassedInIsActiveMethod()); assertTrue(managerWithDefaultRollback.isTransactionPassedInBeginMethod()); assertTrue(managerWithDefaultRollback.isTransactionMarkedRollback()); @@ -101,14 +101,14 @@ public class TransactionRollbackTest { assertFalse(managerWithDefaultRollback.isTransactionActive()); } } - + @Test - public void transactionWithRollback(){ - try{ + public void transactionWithRollback() { + try { managerWithRollback.clean(); managerWithRollback.insert(); fail(); - }catch(TransactionExceptionWithRollback exception){ + } catch (TransactionExceptionWithRollback exception) { assertTrue(managerWithRollback.isTransactionPassedInIsActiveMethod()); assertTrue(managerWithRollback.isTransactionPassedInBeginMethod()); assertTrue(managerWithRollback.isTransactionMarkedRollback()); @@ -119,14 +119,14 @@ public class TransactionRollbackTest { assertFalse(managerWithRollback.isTransactionActive()); } } - - @Test - public void transactionWithoutRollback(){ - try{ + + @Test + public void transactionWithoutRollback() { + try { managerWithoutRollback.clean(); managerWithoutRollback.insert(); fail(); - }catch(TransactionExceptionWithoutRollback exception){ + } catch (TransactionExceptionWithoutRollback exception) { assertTrue(managerWithRollback.isTransactionPassedInIsActiveMethod()); assertTrue(managerWithRollback.isTransactionPassedInBeginMethod()); assertFalse(managerWithRollback.isTransactionMarkedRollback()); diff --git a/impl/core/src/test/java/util/ReflectionsTest.java b/impl/core/src/test/java/util/ReflectionsTest.java index 87f8dc0..69284bb 100644 --- a/impl/core/src/test/java/util/ReflectionsTest.java +++ b/impl/core/src/test/java/util/ReflectionsTest.java @@ -62,7 +62,7 @@ public class ReflectionsTest { class SomeClass { - public void setNumber(T t) { + public void setNumber(final T t) { } } diff --git a/impl/core/src/test/java/util/StringsTest.java b/impl/core/src/test/java/util/StringsTest.java index 165cf4f..294daa3 100644 --- a/impl/core/src/test/java/util/StringsTest.java +++ b/impl/core/src/test/java/util/StringsTest.java @@ -144,7 +144,7 @@ public class StringsTest { assertTrue(result.contains("Test [name=myName, lastname=myLastname, nullField=null, this")); } - private void testEqualsGetString(String in, String expected, Object... params) { + private void testEqualsGetString(final String in, final String expected, final Object... params) { String out = Strings.getString(in, params); assertEquals(expected, out); } -- libgit2 0.21.2