From b5d35f66c4b1cf3439d3b145d52f258f974eebca Mon Sep 17 00:00:00 2001 From: Cleverson Sacramento Date: Tue, 26 Mar 2013 08:53:34 -0300 Subject: [PATCH] Resolvendo a advertĂȘncia do Sonar: Bad practice - Serializable inner --- impl/core/src/main/java/br/gov/frameworkdemoiselle/transaction/TransactionalInterceptor.java | 20 +++++++++++--------- impl/extension/jdbc/src/main/java/br/gov/frameworkdemoiselle/transaction/JDBCTransaction.java | 10 +++++----- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/impl/core/src/main/java/br/gov/frameworkdemoiselle/transaction/TransactionalInterceptor.java b/impl/core/src/main/java/br/gov/frameworkdemoiselle/transaction/TransactionalInterceptor.java index f8f41f9..a8fadec 100644 --- a/impl/core/src/main/java/br/gov/frameworkdemoiselle/transaction/TransactionalInterceptor.java +++ b/impl/core/src/main/java/br/gov/frameworkdemoiselle/transaction/TransactionalInterceptor.java @@ -81,15 +81,7 @@ public class TransactionalInterceptor implements Serializable { instance.getCounter(); } catch (ContextNotActiveException cause) { - instance = new TransactionInfo() { - - private static final long serialVersionUID = 1L; - - @Override - public boolean isOwner() { - return false; - } - }; + instance = new VoidTransactionInfo(); } return instance; @@ -194,4 +186,14 @@ public class TransactionalInterceptor implements Serializable { return logger; } + + private static class VoidTransactionInfo extends TransactionInfo { + + private static final long serialVersionUID = 1L; + + @Override + public boolean isOwner() { + return false; + } + } } diff --git a/impl/extension/jdbc/src/main/java/br/gov/frameworkdemoiselle/transaction/JDBCTransaction.java b/impl/extension/jdbc/src/main/java/br/gov/frameworkdemoiselle/transaction/JDBCTransaction.java index 2c9dc2f..c73186a 100644 --- a/impl/extension/jdbc/src/main/java/br/gov/frameworkdemoiselle/transaction/JDBCTransaction.java +++ b/impl/extension/jdbc/src/main/java/br/gov/frameworkdemoiselle/transaction/JDBCTransaction.java @@ -126,12 +126,12 @@ public class JDBCTransaction implements Transaction { public boolean isActive() { Status status; boolean result = true; - + for (Connection connection : getDelegate()) { status = cache.get(connection); result = result && status.isActive(); } - + return result; } @@ -139,16 +139,16 @@ public class JDBCTransaction implements Transaction { public boolean isMarkedRollback() { Status status; boolean result = true; - + for (Connection connection : getDelegate()) { status = cache.get(connection); result = result && status.isMarkedRollback(); } - + return result; } - private class Status implements Serializable { + private static class Status implements Serializable { private static final long serialVersionUID = 1L; -- libgit2 0.21.2