From 293f1ad672ac516b85fc4894a56f692bfadc0e09 Mon Sep 17 00:00:00 2001
From: Rafael Reggiani Manzo <rr.manzo@gmail.com>
Date: Wed, 10 Jun 2015 16:44:47 -0300
Subject: [PATCH] branches and request vars for Repository form js extracted to Branch class

---
 app/assets/javascripts/repository/branch.js.coffee |  4 ++++
 app/views/repositories/_form.html.erb              | 18 ++++++++----------
 2 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/app/assets/javascripts/repository/branch.js.coffee b/app/assets/javascripts/repository/branch.js.coffee
index 49fcfcf..36d4217 100644
--- a/app/assets/javascripts/repository/branch.js.coffee
+++ b/app/assets/javascripts/repository/branch.js.coffee
@@ -1,4 +1,8 @@
 class Repository.Branch
+  constructor: ->
+    @names = {}
+    @request = null
+
   @toggle: ->
     scm_type_field = document.getElementById("repository_scm_type")
     index = scm_type_field.selectedIndex
diff --git a/app/views/repositories/_form.html.erb b/app/views/repositories/_form.html.erb
index 111b194..444611e 100644
--- a/app/views/repositories/_form.html.erb
+++ b/app/views/repositories/_form.html.erb
@@ -132,8 +132,7 @@
 </script>
 
 <script>
-  var branches = {};
-  var request = null;
+  var repository_branch = new Repository.Branch;
   function fetch_branches (address_field) {
     cancel_previous_request();
     var address = address_field.value;
@@ -141,15 +140,14 @@
     var el = $("#repository_branch");
     el.empty(); // remove old options
 
-    console.log(address);
-    if(branches[address] != null) {
-      fill_options(branches[address], el);
+    if(repository_branch.names[address] != null) {
+      fill_options(repository_branch.names[address], el);
       return;
     }
 
     var scm_type = $("#repository_scm_type option:selected").text();
 
-    request = ($.ajax({
+    repository_branch.request = ($.ajax({
       url: "<%= repository_branches_path() %>",
       data: {'url': address, 'scm_type': scm_type},
       type: 'GET',
@@ -157,16 +155,16 @@
       success: function (data){
         options = data["branches"];
         if (options != null) {
-          branches[address] = options;
+          repository_branch.names[address] = options;
           fill_options(options, el);
         }
        }
     }));
 
     function cancel_previous_request() {
-      if (request != null) {
-        request.abort();
-        request = null;
+      if (repository_branch.request != null) {
+        repository_branch.request.abort();
+        repository_branch.request = null;
       }
     }
   }
--
libgit2 0.21.2