From 466a15b467531324469690c6e7aa98e3945d6383 Mon Sep 17 00:00:00 2001
From: Rafael Reggiani Manzo <rr.manzo@gmail.com>
Date: Fri, 12 Jun 2015 11:03:40 -0300
Subject: [PATCH] Repository.Branch JS using full JQuery potential

---
 app/assets/javascripts/repository/branch.js.coffee | 13 ++++---------
 app/views/repositories/_form.html.erb              |  2 +-
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/app/assets/javascripts/repository/branch.js.coffee b/app/assets/javascripts/repository/branch.js.coffee
index 883102f..7a3fce8 100644
--- a/app/assets/javascripts/repository/branch.js.coffee
+++ b/app/assets/javascripts/repository/branch.js.coffee
@@ -4,13 +4,9 @@ class Repository.Branch
     @request = null
 
   toggle: ->
-    scm_type_field = document.getElementById("repository_scm_type")
-    index = scm_type_field.selectedIndex
-    option = scm_type_field.options[index]
-
-    if option.value != "SVN"
+    if $("#repository_scm_type").val() != "SVN"
       $("#branches").show()
-      @fetch(document.getElementById("repository_address"))
+      @fetch($("#repository_address").val())
     else
       $("#branches").hide()
 
@@ -32,9 +28,8 @@ class Repository.Branch
           .attr("value", option)
           .text(option))
 
-  fetch: (address_field) ->
+  fetch: (address) ->
     @cancel_request()
-    address = address_field.value
 
     # Prevent a call with blank address
     if address == ""
@@ -47,7 +42,7 @@ class Repository.Branch
       @fill_options(@names[address], el)
       return
 
-    scm_type = $("#repository_scm_type option:selected").text()
+    scm_type = $("#repository_scm_type").val()
 
     context = this
     @request = $.get '/repository_branches',
diff --git a/app/views/repositories/_form.html.erb b/app/views/repositories/_form.html.erb
index fb3b6c3..06700a7 100644
--- a/app/views/repositories/_form.html.erb
+++ b/app/views/repositories/_form.html.erb
@@ -55,7 +55,7 @@
     <div class="form-row">
       <div class="field-container">
         <%= f.label :address, class: 'control-label' %>
-        <%= f.text_field :address, :required => true, class: 'text-field form-control', onchange: "_repository_branch.fetch(this);" %>
+        <%= f.text_field :address, :required => true, class: 'text-field form-control', onchange: "_repository_branch.fetch(this.value);" %>
       </div>
       <div class="help-container">
         <p>
--
libgit2 0.21.2