From 50eb406534cde2753f91d00801657b06d34ef42c Mon Sep 17 00:00:00 2001
From: Rafael Reggiani Manzo <rr.manzo@gmail.com>
Date: Wed, 29 Apr 2015 16:57:52 -0300
Subject: [PATCH] Fixed Project image renderization

---
 app/helpers/projects_helper.rb       | 11 +++++++++++
 app/views/projects/show.html.erb     |  7 +------
 config/locales/views/projects/en.yml |  1 +
 config/locales/views/projects/pt.yml |  1 +
 spec/helpers/projects_helper_spec.rb | 28 ++++++++++++++++++++++++++++
 5 files changed, 42 insertions(+), 6 deletions(-)

diff --git a/app/helpers/projects_helper.rb b/app/helpers/projects_helper.rb
index 90aa575..5d5718c 100644
--- a/app/helpers/projects_helper.rb
+++ b/app/helpers/projects_helper.rb
@@ -2,4 +2,15 @@ module ProjectsHelper
   def project_owner? project_id
     user_signed_in? && !current_user.project_attributes.find_by_project_id(project_id).nil?
   end
+
+  def project_image_html(project)
+    url = project.attributes.image_url
+
+    if url && !url.empty?
+      image_tag url, size:"128x128"
+    else
+      "<center><i class='fa fa-file-image-o fa-5x'></i></center><br />
+       #{t('no_image_available')}"
+    end
+  end
 end
\ No newline at end of file
diff --git a/app/views/projects/show.html.erb b/app/views/projects/show.html.erb
index 685375c..3af23de 100644
--- a/app/views/projects/show.html.erb
+++ b/app/views/projects/show.html.erb
@@ -1,12 +1,7 @@
 <div class="page-header">
   <div class="row">
     <div class="col-md-2">
-      <% if @project_image && !@project_image.url.empty? %>
-        <%= image_tag "#{@project_image.url}", size:"128x128" %>
-      <% else %>
-        <center><i class="fa fa-file-image-o fa-5x"></i></center><br />
-        <%= t("no_image_available") %>
-      <% end %>
+      <%= project_image_html(@project) %>
     </div>
     <div class="col-md-10">
       <h1><%= @project.name %></h1>
diff --git a/config/locales/views/projects/en.yml b/config/locales/views/projects/en.yml
index 3f0dc58..c1ba0ef 100644
--- a/config/locales/views/projects/en.yml
+++ b/config/locales/views/projects/en.yml
@@ -17,3 +17,4 @@ en:
   image_url: "Image URL"
   all_projects: "All Projects"
   no_repositories: "There are no Repositories yet!"
+  no_image_available: "No Image Available"
diff --git a/config/locales/views/projects/pt.yml b/config/locales/views/projects/pt.yml
index eecac5a..2a7b65b 100644
--- a/config/locales/views/projects/pt.yml
+++ b/config/locales/views/projects/pt.yml
@@ -17,3 +17,4 @@ pt:
   image_url: "URL da imagem"
   all_projects: "Todos os Projetos"
   no_repositories: "Não há repositórios ainda!"
+  no_image_available: "Imagem indisponível"
diff --git a/spec/helpers/projects_helper_spec.rb b/spec/helpers/projects_helper_spec.rb
index 7d6c58c..37d4404 100644
--- a/spec/helpers/projects_helper_spec.rb
+++ b/spec/helpers/projects_helper_spec.rb
@@ -43,4 +43,32 @@ describe ProjectsHelper, :type => :helper do
     end
   end
 
+  describe 'project_image_html' do
+    let(:project) { FactoryGirl.build(:project) }
+    let(:project_attributes) { FactoryGirl.build(:project_attributes) }
+
+    context 'when the project has an image' do
+      before :each do
+        project.expects(:attributes).twice.returns(project_attributes)
+      end
+
+      it 'is expect to return an image tag with the project attribute URL' do
+        expect(helper.project_image_html(project)).to include("<img")
+        expect(helper.project_image_html(project)).to include(project_attributes.image_url)
+      end
+    end
+
+    context 'when the project does not has an image' do
+      before :each do
+        project_attributes.image_url = ""
+        project.expects(:attributes).twice.returns(project_attributes)
+      end
+
+      it 'is expect to return a default image icon with a message' do
+        expect(helper.project_image_html(project)).to include("<i class")
+        expect(helper.project_image_html(project)).to include(I18n.t('no_image_available'))
+      end
+    end
+  end
+
 end
\ No newline at end of file
--
libgit2 0.21.2