From 51adda62a01568ee3fd7854d3ba56a12013f7524 Mon Sep 17 00:00:00 2001
From: Daniel Miranda <danielkza2@gmail.com>
Date: Thu, 18 Jun 2015 18:59:15 -0300
Subject: [PATCH] Implement more Javascript tests for branch selection

---
 spec/javascripts/repository/branch_spec.js.coffee | 136 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------
 1 file changed, 109 insertions(+), 27 deletions(-)

diff --git a/spec/javascripts/repository/branch_spec.js.coffee b/spec/javascripts/repository/branch_spec.js.coffee
index cb4117c..ffc65f8 100644
--- a/spec/javascripts/repository/branch_spec.js.coffee
+++ b/spec/javascripts/repository/branch_spec.js.coffee
@@ -3,36 +3,118 @@
 #= require repository/branch
 #= require sinon
 
-describe "Branch#constructor", ->
-  it "should construct a branch", ->
-    subject = new Repository.Branch()
-    subject.names.should.deep.equal({})
-    assert.isNull(subject.request)
-
-describe "toggle", ->
-  before ->
+describe "Repository.Branch", ->
+  beforeEach ->
     @subject = new Repository.Branch()
 
-    @combo_box = sinon.stub()
-    $ = sinon.stub(window, "$")
-    $.withArgs("#branches").returns(@combo_box)
+  describe "constructor", ->
+    it "should construct a branch", ->
+      @subject.names.should.deep.equal({})
+      assert.isNull(@subject.request)
 
-  context "scm_type = SVN", ->
+  describe "#toggle", ->
     before ->
-      @combo_box.hide = sinon.spy()
-      $.withArgs("#repository_scm_type").returns({val: -> "SVN"})
+      @combo_box = sinon.stub()
+      sinon.stub(window, "$")
+      $.withArgs("#branches").returns(@combo_box)
 
-    it "should hide the branches combo box", ->
-      @subject.toggle()
-      assert.isTrue(@combo_box.hide.calledOnce)
+    after ->
+      window.$.restore()
 
-  context "scm_type != SVN", ->
-    before ->
-      @combo_box.show = sinon.spy()
-      $.withArgs("#repository_address").returns({val: -> "https://github.com/mezuro/prezento.git"})
-      $.withArgs("#repository_scm_type").returns({val: -> "GIT"})
-      sinon.stub(@subject, "fetch").withArgs("https://github.com/mezuro/prezento.git")
-
-    it "should show the branches combo box", ->
-      @subject.toggle()
-      assert.isTrue(@combo_box.show.calledOnce)
+    context "scm_type = SVN", ->
+      beforeEach ->
+        @combo_box.hide = sinon.spy()
+        $.withArgs("#repository_scm_type").returns({val: -> "SVN"})
+
+      it "should hide the branches combo box", ->
+        @subject.toggle()
+        assert.isTrue(@combo_box.hide.calledOnce)
+
+    context "scm_type != SVN", ->
+      beforeEach ->
+        @combo_box.show = sinon.spy()
+        $.withArgs("#repository_address").returns({val: -> "https://github.com/mezuro/prezento.git"})
+        $.withArgs("#repository_scm_type").returns({val: -> "GIT"})
+        sinon.stub(@subject, "fetch").withArgs("https://github.com/mezuro/prezento.git")
+
+      it "should show the branches combo box", ->
+        @subject.toggle()
+        assert.isTrue(@combo_box.show.calledOnce)
+
+  describe "#cancel_request", ->
+    context 'request is not null', ->
+      beforeEach ->
+        @request = sinon.stub()
+        @request.abort = sinon.spy()
+        @subject.request = @request
+
+      it 'should abort the request', ->
+        @subject.cancel_request()
+        assert.isTrue(@request.abort.calledOnce)
+        assert.isNull(@subject.request)
+
+  describe "#fill_options", ->
+    beforeEach ->
+      @el = jQuery("<select></select>")
+
+    context 'with branches that contain master', ->
+      it 'should place master first', ->
+        @subject.fill_options(['dev', 'stable', 'master'], @el)
+
+        option_values = []
+        for option in @el.get(0).options
+          option_values.push(option.value)
+
+        assert.deepEqual(option_values, ['master', 'dev', 'stable'])
+
+    context "with branches that don't contain master", ->
+      it "shouldn't change anything", ->
+        @subject.fill_options(['dev', 'stable', 'branch_do_daniel'], @el)
+
+        option_values = []
+        for option in @el.get(0).options
+          option_values.push(option.value)
+
+        assert.deepEqual(option_values, ['dev', 'stable', 'branch_do_daniel'])
+
+  describe '#fetch', ->
+    beforeEach ->
+      @subject.cancel_request = sinon.spy()
+
+    context 'with valid address', ->
+      beforeEach ->
+        @subject.fill_options = sinon.spy()
+#           @subject.names = {'https://github.com/mezuro/prezento.git': ['master', 'dev']}
+
+      context 'with new address', ->
+        beforeEach ->
+          @subject.names = {}
+
+          @address = 'https://github.com/mezuro/kalibro_processor.git'
+
+          @select = sinon.stub()
+          # Stub just the selector and not the whole jQuery object
+          find_stub = sinon.stub($, "find")
+          find_stub.withArgs("#repository_branch").returns(@select)
+          find_stub.withArgs("#repository_scm_type").returns({val: -> "SVN"})
+
+          @server = sinon.fakeServer.create()
+          @server.respondImmediately = true
+
+          address_url_encoded = encodeURI(@address)
+          @server.respondWith('GET', '/repository_branches&url=' + address_url_encoded + '&scm_type=' + 'GIT',
+            [200, { "Content-Type": "application/json" }, JSON.stringify({
+              "branches": ["stable", "dev", "master"]
+            })]
+          )
+
+        afterEach ->
+          @server.restore()
+          $.find.restore()
+
+        it 'should fetch the branches and fill the options', ->
+          @subject.fetch(@address)
+          @server.respond()
+          console.log(@server.requests[0])
+          debugger
+          assert.isTrue(@subject.fill_options.calledWith(['stable', 'dev', 'master'], @select))
--
libgit2 0.21.2