From 6316f10805992905d263e8c217bc15a2446eeea2 Mon Sep 17 00:00:00 2001 From: Diego Araújo Date: Fri, 17 Apr 2015 17:25:58 -0300 Subject: [PATCH] Reviewing PR #204 --- app/views/tutorials/analyzing.pt.html.erb | 6 +++--- features/step_definitions/repository_steps.rb | 6 ------ features/users/user_update.feature | 1 - spec/helpers/application_helper_spec.rb | 4 ++-- 4 files changed, 5 insertions(+), 12 deletions(-) diff --git a/app/views/tutorials/analyzing.pt.html.erb b/app/views/tutorials/analyzing.pt.html.erb index f5c6057..861c401 100644 --- a/app/views/tutorials/analyzing.pt.html.erb +++ b/app/views/tutorials/analyzing.pt.html.erb @@ -30,10 +30,10 @@ A fim de criar um projeto, você deve:
  1. A partir da página do projeto, clique em "Novo Repositório"
  2. -
  3. Preencha o formulário, garantindo que: +
  4. Preencha o formulário:
      -
    • O "Nome" seja único
    • -
    • Você deve escolher uma "Licença" Open Source na plataforma de acordo com o seu código
    • +
    • O "Nome" deve ser único
    • +
    • Você deve escolher uma "Licença" Open Source na plataforma de acordo com o seu código
    • O campo "Tipo" está relacionado com a ferramenta de controle de versão do código (Git, por exemplo)
    • Preencha o "Endereço" com a URL a partir da qual podemos fazer o download do código
    • Se você quiser analisar seu projeto periodicamente, configure-o (você pode também executá-lo a partir da interface sempre que quiser)
    • diff --git a/features/step_definitions/repository_steps.rb b/features/step_definitions/repository_steps.rb index aa53301..9e87892 100644 --- a/features/step_definitions/repository_steps.rb +++ b/features/step_definitions/repository_steps.rb @@ -114,7 +114,6 @@ When(/^I wait up for the ajax request$/) do end When(/^I get the Creation Date information as "(.*?)"$/) do |variable| - p page.find('p', text: 'Creation Date').text.match(/^Creation Date:(.*)$/).captures val = page.find('p', text: 'Creation Date').text.match(/^Creation Date:(.*)$/).captures.first eval ("@#{variable} = DateTime.parse('#{val}')") end @@ -172,10 +171,5 @@ end Then(/^"(.*?)" should be lesser than "(.*?)"$/) do |arg1, arg2| v1 = eval "@#{arg1}" v2 = eval "@#{arg2}" - - p v1 - p v2 - expect(v1 < v2).to be_truthy end - diff --git a/features/users/user_update.feature b/features/users/user_update.feature index 19aad73..eb474a3 100644 --- a/features/users/user_update.feature +++ b/features/users/user_update.feature @@ -3,7 +3,6 @@ Feature: User update As a regular user I want to have an edit page - @javascript Scenario: with current password Given I am a regular user And I am signed in diff --git a/spec/helpers/application_helper_spec.rb b/spec/helpers/application_helper_spec.rb index f4d4288..ea8e197 100644 --- a/spec/helpers/application_helper_spec.rb +++ b/spec/helpers/application_helper_spec.rb @@ -9,7 +9,7 @@ describe ApplicationHelper, :type => :helper do let!(:translation) { "translated test" } before :each do - helper.expects(:t).with("activemodel.hints.#{helper.controller_name}.#{attribute_key}").returns(translation) + helper.expects(:t).with("activemodel.hints.#{helper.controller_name}.#{attribute_key}", {}).returns(translation) end it 'is expected to return the hint for the given attribute' do @@ -23,4 +23,4 @@ describe ApplicationHelper, :type => :helper do end end end -end \ No newline at end of file +end -- libgit2 0.21.2