From 7cc2fe6842f0986434b85b1392e932b199d48b64 Mon Sep 17 00:00:00 2001 From: Rafael Reggiani Manzo Date: Fri, 16 Oct 2015 16:24:36 -0300 Subject: [PATCH] Standardize MetricConfigurationsCon[...] comments --- app/controllers/metric_configurations_controller.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/controllers/metric_configurations_controller.rb b/app/controllers/metric_configurations_controller.rb index d857939..8693ed5 100644 --- a/app/controllers/metric_configurations_controller.rb +++ b/app/controllers/metric_configurations_controller.rb @@ -7,7 +7,7 @@ class MetricConfigurationsController < BaseMetricConfigurationsController def new super - # find_by_name throws an exception instead of returning nil, unlike ActiveRecord's API + # FIXME: find_by_name throws an exception instead of returning nil, unlike ActiveRecord's API metric_configuration.metric = KalibroClient::Entities::Processor::MetricCollectorDetails.find_by_name(params[:metric_collector_name]).find_metric_by_code params[:metric_code] @reading_groups = ReadingGroup.public_or_owned_by_user(current_user).map { |reading_group| [reading_group.name, reading_group.id] @@ -24,7 +24,7 @@ class MetricConfigurationsController < BaseMetricConfigurationsController end def edit - #FIXME: set the configuration id just once! + # FIXME: set the configuration id just once! @kalibro_configuration_id = params[:kalibro_configuration_id] @metric_configuration.kalibro_configuration_id = @kalibro_configuration_id @reading_groups = ReadingGroup.public_or_owned_by_user(current_user).map { |reading_group| @@ -72,7 +72,7 @@ class MetricConfigurationsController < BaseMetricConfigurationsController Rails.cache.delete("#{params[:kalibro_configuration_id]}_hotspot_metric_configurations") end - # Duplicated code on create and update actions extracted here + # FIXME: Duplicated code on create and update actions extracted here def failed_action(format, destiny_action) @kalibro_configuration_id = params[:kalibro_configuration_id] @@ -80,7 +80,7 @@ class MetricConfigurationsController < BaseMetricConfigurationsController format.json { render json: @metric_configuration.kalibro_errors, status: :unprocessable_entity } end - #Code extracted from create action + # Code extracted from create action def create_and_redir(format) if @metric_configuration.save format.html { redirect_to kalibro_configuration_path(@metric_configuration.kalibro_configuration_id), notice: t('successfully_created', :record => t(metric_configuration.class)) } -- libgit2 0.21.2