From 8c64ffc8af338a0f632e5422e10fdc73492ffafe Mon Sep 17 00:00:00 2001
From: Rafael Reggiani Manzo <rr.manzo@gmail.com>
Date: Wed, 20 Jan 2016 11:08:09 -0200
Subject: [PATCH] Coverup all metric_con finding branches on Base

---
 spec/controllers/metric_configurations_controller_spec.rb | 45 +++++++++++++++++++++++++++++++++------------
 1 file changed, 33 insertions(+), 12 deletions(-)

diff --git a/spec/controllers/metric_configurations_controller_spec.rb b/spec/controllers/metric_configurations_controller_spec.rb
index 16a6ac8..f6b74ea 100644
--- a/spec/controllers/metric_configurations_controller_spec.rb
+++ b/spec/controllers/metric_configurations_controller_spec.rb
@@ -105,29 +105,50 @@ describe MetricConfigurationsController, :type => :controller do
     let(:kalibro_range) { FactoryGirl.build(:kalibro_range) }
 
     before :each do
-        KalibroConfiguration.expects(:find).with(kalibro_configuration.id).returns kalibro_configuration
-        MetricConfiguration.expects(:find).with(metric_configuration.id).returns(metric_configuration)
+      KalibroConfiguration.expects(:find).with(kalibro_configuration.id).returns kalibro_configuration
     end
 
-    context 'with valid parameters' do
+    context 'with a valid metric configuration instance' do
       before :each do
-        ReadingGroup.expects(:find).with(metric_configuration.reading_group_id).returns(reading_group)
-        metric_configuration.expects(:kalibro_ranges).returns([kalibro_range])
+        MetricConfiguration.expects(:find).with(metric_configuration.id).returns(metric_configuration)
+      end
+
+      context 'with valid parameters' do
+        before :each do
+          ReadingGroup.expects(:find).with(metric_configuration.reading_group_id).returns(reading_group)
+          metric_configuration.expects(:kalibro_ranges).returns([kalibro_range])
+
+          get :show, kalibro_configuration_id: metric_configuration.kalibro_configuration_id.to_s, id: metric_configuration.id
+        end
 
-        get :show, kalibro_configuration_id: metric_configuration.kalibro_configuration_id.to_s, id: metric_configuration.id
+        it { is_expected.to render_template(:show) }
       end
 
-      it { is_expected.to render_template(:show) }
+      context 'with invalid parameters' do
+        before :each do
+          ReadingGroup.expects(:find).with(metric_configuration.reading_group_id).raises(KalibroClient::Errors::RecordNotFound)
+
+          get :show, kalibro_configuration_id: metric_configuration.kalibro_configuration_id.to_s, id: metric_configuration.id
+        end
+
+        it { is_expected.to redirect_to(kalibro_configuration_path(kalibro_configuration.id)) }
+      end
     end
 
-    context 'with invalid parameters' do
-      before :each do
-        ReadingGroup.expects(:find).with(metric_configuration.reading_group_id).raises(KalibroClient::Errors::RecordNotFound)
+    context 'with an invalid metric configuration instance' do
+      let!(:invalid_metric_configuration) { FactoryGirl.build(:metric_configuration, reading_group_id: reading_group.id, kalibro_configuration_id: metric_configuration.kalibro_configuration_id + 1) }
 
-        get :show, kalibro_configuration_id: metric_configuration.kalibro_configuration_id.to_s, id: metric_configuration.id
+      before :each do
+        MetricConfiguration.expects(:find).with(metric_configuration.id).returns(invalid_metric_configuration)
       end
 
-      it { is_expected.to redirect_to(kalibro_configuration_path(kalibro_configuration.id)) }
+      context 'with valid parameters' do
+        before :each do
+          get :show, kalibro_configuration_id: metric_configuration.kalibro_configuration_id.to_s, id: metric_configuration.id
+        end
+
+        it { is_expected.to respond_with(:not_found) }
+      end
     end
   end
 
--
libgit2 0.21.2