From b7e10d2d1dc73bd19d8571f8f73a64b68916dfa6 Mon Sep 17 00:00:00 2001
From: Heitor Reis <marcheing@gmail.com>
Date: Tue, 19 May 2015 10:56:50 -0300
Subject: [PATCH] Completed unit tests coverage

---
 spec/controllers/metric_configurations_controller_spec.rb | 11 +++++++++--
 spec/controllers/repositories_controller_spec.rb          | 14 ++++++++------
 2 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/spec/controllers/metric_configurations_controller_spec.rb b/spec/controllers/metric_configurations_controller_spec.rb
index d053587..4275746 100644
--- a/spec/controllers/metric_configurations_controller_spec.rb
+++ b/spec/controllers/metric_configurations_controller_spec.rb
@@ -24,12 +24,16 @@ describe MetricConfigurationsController, :type => :controller do
   describe 'new' do
     let!(:metric_collector) { FactoryGirl.build(:metric_collector) }
     let!(:native_metric) { FactoryGirl.build(:loc) }
+    let!(:reading_groups) { [FactoryGirl.build(:reading_group)] }
+    let!(:user) { FactoryGirl.create(:user) }
+
     before :each do
-      sign_in FactoryGirl.create(:user)
+      sign_in user
     end
 
     context 'when the current user owns the kalibro configuration' do
       before :each do
+        ReadingGroup.expects(:public_or_owned_by_user).with(user).returns(reading_groups)
         subject.expects(:kalibro_configuration_owner?).returns true
         KalibroClient::Entities::Processor::MetricCollectorDetails.expects(:find_by_name).with(metric_collector.name).returns(metric_collector)
         metric_collector.expects(:find_metric_by_code).with(native_metric.code).returns(native_metric)
@@ -108,14 +112,17 @@ describe MetricConfigurationsController, :type => :controller do
 
   describe 'edit' do
     let(:metric_configuration) { FactoryGirl.build(:metric_configuration_with_id) }
+    let!(:reading_groups) { [FactoryGirl.build(:reading_group)] }
+    let!(:user) { FactoryGirl.create(:user) }
 
     context 'with a User logged in' do
       before do
-        sign_in FactoryGirl.create(:user)
+        sign_in user
       end
 
       context 'when the user owns the metric configuration' do
         before :each do
+          ReadingGroup.expects(:public_or_owned_by_user).with(user).returns(reading_groups)
           subject.expects(:metric_configuration_owner?).returns(true)
           MetricConfiguration.expects(:find).with(metric_configuration.id).returns(metric_configuration)
           get :edit, id: metric_configuration.id, kalibro_configuration_id: metric_configuration.kalibro_configuration_id.to_s
diff --git a/spec/controllers/repositories_controller_spec.rb b/spec/controllers/repositories_controller_spec.rb
index 46815b1..3377c41 100644
--- a/spec/controllers/repositories_controller_spec.rb
+++ b/spec/controllers/repositories_controller_spec.rb
@@ -5,12 +5,15 @@ describe RepositoriesController, :type => :controller do
 
   describe 'new' do
     context 'with a User logged in' do
+      let!(:user) { FactoryGirl.create(:user) }
+      let!(:kalibro_configurations) { [FactoryGirl.build(:kalibro_configuration)] }
       before :each do
-        sign_in FactoryGirl.create(:user)
+        sign_in user
       end
 
       context 'when the current user owns the project' do
         before :each do
+          KalibroConfiguration.expects(:public_or_owned_by_user).with(user).returns(kalibro_configurations)
           Repository.expects(:repository_types).returns([])
           subject.expects(:project_owner?).returns true
 
@@ -91,8 +94,6 @@ describe RepositoriesController, :type => :controller do
 
     context 'without a specific module_result' do
       before :each do
-        processing = FactoryGirl.build(:processing)
-
         KalibroConfiguration.expects(:find).with(repository.id).returns(FactoryGirl.build(:kalibro_configuration, :with_id))
         Repository.expects(:find).with(repository.id).returns(repository)
 
@@ -105,8 +106,6 @@ describe RepositoriesController, :type => :controller do
     context 'for an specific module_result' do
 
       before :each do
-        processing = FactoryGirl.build(:processing)
-
         KalibroConfiguration.expects(:find).with(repository.id).returns(FactoryGirl.build(:kalibro_configuration, :with_id))
         Repository.expects(:find).with(repository.id).returns(repository)
 
@@ -161,12 +160,15 @@ describe RepositoriesController, :type => :controller do
     let(:repository) { FactoryGirl.build(:repository) }
 
     context 'with an User logged in' do
+      let!(:user) { FactoryGirl.create(:user) }
+      let!(:kalibro_configurations) { [FactoryGirl.build(:kalibro_configuration)] }
       before do
-        sign_in FactoryGirl.create(:user)
+        sign_in user
       end
 
       context 'when the user owns the repository' do
         before :each do
+          KalibroConfiguration.expects(:public_or_owned_by_user).with(user).returns(kalibro_configurations)
           subject.expects(:repository_owner?).returns true
           Repository.expects(:find).at_least_once.with(repository.id).returns(repository)
           Repository.expects(:repository_types).returns(["SUBVERSION"])
--
libgit2 0.21.2