From e389402ee7164c30774260f509bd4b5002e7f5b3 Mon Sep 17 00:00:00 2001 From: Abner Oliveira Date: Thu, 14 Jul 2016 13:32:54 -0300 Subject: [PATCH] some small refactoring on class naming and changed to allow EVENTS_HUB_KNOW_EVENT_NAMES to be an array of strings --- src/app/known-events.ts | 2 +- src/app/main/main.component.spec.ts | 13 +++++++++++-- src/app/main/main.component.ts | 4 ++-- 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/src/app/known-events.ts b/src/app/known-events.ts index cb8831e..9a655bd 100644 --- a/src/app/known-events.ts +++ b/src/app/known-events.ts @@ -2,7 +2,7 @@ import { EventsHubKnownEventNames } from './shared/services/events-hub.service'; export class NoosferoKnownEvents implements EventsHubKnownEventNames { IMAGE_PROFILE_UPDATED: string = 'IMAGE_PROFILE_UPDATED'; - PROFILE_INFO_UPDATED: string = 'IMAGE_PROFILE_UPDATED'; + PROFILE_INFO_UPDATED: string = 'PROFILE_INFO_UPDATED'; ARTICLE_UPDATED: string = 'ARTICLE_UPDATED'; constructor() { diff --git a/src/app/main/main.component.spec.ts b/src/app/main/main.component.spec.ts index deefb17..fae1c76 100644 --- a/src/app/main/main.component.spec.ts +++ b/src/app/main/main.component.spec.ts @@ -4,8 +4,9 @@ import {TestComponentBuilder, ComponentFixture} from "ng-forward/cjs/testing/tes import {quickCreateComponent} from "../../spec/helpers"; import {getAngularServiceFactory} from "../../spec/helpers"; +import { EVENTS_HUB_KNOW_EVENT_NAMES } from "../shared/services/events-hub.service"; -describe("MainComponent", function() { +describe("MainComponent", function () { let localFixture: ComponentFixture; let $state: angular.ui.IStateService; @@ -34,6 +35,14 @@ describe("MainComponent", function() { { useValue: environmentService }), + provide(EVENTS_HUB_KNOW_EVENT_NAMES, + { + useValue: [ + 'IMAGE_PROFILE_UPDATED', + 'PROFILE_INFO_UPDATED', + 'ARTICLE_UPDATED' + ] + }), ] }) class MainComponentParent { @@ -57,7 +66,7 @@ describe("MainComponent", function() { // navigates to the environment home $state.go("main.environment.home"); localFixture.detectChanges(); - // after changes were detected it checks the current $state route + // after changes were detected it checks the current $state route expect($state.current.name).toEqual("main.environment.home"); done(); }); diff --git a/src/app/main/main.component.ts b/src/app/main/main.component.ts index ceec544..4ec1ffa 100644 --- a/src/app/main/main.component.ts +++ b/src/app/main/main.component.ts @@ -48,7 +48,7 @@ import {SearchComponent} from "../search/search.component"; import {SearchFormComponent} from "../search/search-form/search-form.component"; import { EVENTS_HUB_KNOW_EVENT_NAMES, EventsHubService } from "../shared/services/events-hub.service"; -import { NoosferoEventsHubKnownEventNames } from "../events-hub-known-events"; +import { NoosferoKnownEvents } from "../known-events"; /** * @ngdoc controller * @name main.MainContentComponent @@ -71,7 +71,7 @@ export class MainContentComponent { constructor( private bodyStateClassesService: BodyStateClassesService, - eventsNames: NoosferoEventsHubKnownEventNames, + eventsNames: NoosferoKnownEvents, eventsHubService: EventsHubService ) { try { -- libgit2 0.21.2