From 4aa998ad243e8d6e6e1fdaf899b6d39296251e72 Mon Sep 17 00:00:00 2001
From: Victor Costa <vfcosta@gmail.com>
Date: Fri, 4 Mar 2016 14:12:23 -0300
Subject: [PATCH] Create a helper to provide filters to tests

---
 src/app/components/noosfero-blocks/link-list/link-list.component.spec.ts               | 19 ++++++++-----------
 src/app/components/noosfero-blocks/link-list/link-list.html                            |  2 +-
 src/app/components/noosfero-blocks/recent-documents/recent-documents.component.spec.ts |  7 +++----
 src/app/components/noosfero/noosfero-template.filter.js                                |  2 +-
 src/spec/helpers.ts                                                                    |  9 ++++++++-
 5 files changed, 21 insertions(+), 18 deletions(-)

diff --git a/src/app/components/noosfero-blocks/link-list/link-list.component.spec.ts b/src/app/components/noosfero-blocks/link-list/link-list.component.spec.ts
index d1395d7..ea13d21 100644
--- a/src/app/components/noosfero-blocks/link-list/link-list.component.spec.ts
+++ b/src/app/components/noosfero-blocks/link-list/link-list.component.spec.ts
@@ -1,5 +1,6 @@
 import {TestComponentBuilder} from 'ng-forward/cjs/testing/test-component-builder';
 import {Pipe, Input, provide, Component} from 'ng-forward';
+import {provideFilters} from '../../../../spec/helpers';
 
 import {LinkListBlock} from './link-list.component';
 
@@ -41,21 +42,17 @@ describe("Link List Block Component", () => {
 
     it("display links stored in block settings", done => {
 
-        @Pipe('noosferoTemplateFilter')
-        class NoosferoTemplateFilter {
-            transform(input: any, changeTo: any) {
-                return input;
-            }
-        }
-
-        @Component({ selector: 'test-container-component', template: htmlTemplate, directives: [LinkListBlock] })
+        @Component({
+            selector: 'test-container-component',
+            template: htmlTemplate,
+            directives: [LinkListBlock],
+            providers: provideFilters("noosferoTemplateFilter")
+        })
         class CustomBlockType {
             block: any = { settings: { links: [{ name: 'link1', address: 'address1' }, { name: 'link2', address: 'address2' }] } };
             owner: any = { name: 'profile-name' };
-            constructor() {
-            }
         }
-        tcb.overrideView(LinkListBlock, { templateUrl: "app/components/noosfero-blocks/link-list/link-list.html", pipes: [NoosferoTemplateFilter] }).createAsync(CustomBlockType).then(fixture => {
+        tcb.createAsync(CustomBlockType).then(fixture => {
             expect(fixture.debugElement.queryAll(".link-list-block a").length).toEqual(2);
             done();
         });
diff --git a/src/app/components/noosfero-blocks/link-list/link-list.html b/src/app/components/noosfero-blocks/link-list/link-list.html
index f874ad4..17db1db 100644
--- a/src/app/components/noosfero-blocks/link-list/link-list.html
+++ b/src/app/components/noosfero-blocks/link-list/link-list.html
@@ -1,6 +1,6 @@
 <div class="link-list-block">
   <div ng-repeat="link in ctrl.links">
-    <a ng-href="{{link.address | noosferoTemplateFilter:{profile: ctrl.owner.identifier} }}">
+    <a ng-href="{{link.address | noosferoTemplate:{profile: ctrl.owner.identifier} }}">
       <i class="fa fa-fw icon-{{link.icon}}"></i> <span>{{link.name}}</span>
     </a>
   </div>
diff --git a/src/app/components/noosfero-blocks/recent-documents/recent-documents.component.spec.ts b/src/app/components/noosfero-blocks/recent-documents/recent-documents.component.spec.ts
index 8b4a180..f69545b 100644
--- a/src/app/components/noosfero-blocks/recent-documents/recent-documents.component.spec.ts
+++ b/src/app/components/noosfero-blocks/recent-documents/recent-documents.component.spec.ts
@@ -1,6 +1,6 @@
 import {TestComponentBuilder} from 'ng-forward/cjs/testing/test-component-builder';
 import {Provider, Input, provide, Component} from 'ng-forward';
-
+import {provideFilters} from '../../../../spec/helpers';
 import {RecentDocumentsBlock} from './recent-documents.component';
 
 const htmlTemplate: string = '<noosfero-recent-documents-block [block]="ctrl.block" [owner]="ctrl.owner"></noosfero-recent-documents-block>';
@@ -13,8 +13,6 @@ describe("Recent Documents Block Component", () => {
 
     let state = jasmine.createSpyObj("state", ["go"]);
     let providers = [
-        new Provider('truncateFilter', { useValue: () => { } }),
-        new Provider('stripTagsFilter', { useValue: () => { } }),
         new Provider('$state', { useValue: state }),
         new Provider('ArticleService', {
             useValue: {
@@ -23,7 +21,8 @@ describe("Recent Documents Block Component", () => {
                 }
             }
         }),
-    ];
+    ].concat(provideFilters("truncateFilter", "stripTagsFilter"));
+
     @Component({ selector: 'test-container-component', template: htmlTemplate, directives: [RecentDocumentsBlock], providers: providers })
     class BlockContainerComponent {
         block = { type: 'Block', settings: {} };
diff --git a/src/app/components/noosfero/noosfero-template.filter.js b/src/app/components/noosfero/noosfero-template.filter.js
index c3c9997..42073b4 100644
--- a/src/app/components/noosfero/noosfero-template.filter.js
+++ b/src/app/components/noosfero/noosfero-template.filter.js
@@ -2,7 +2,7 @@
   'use strict';
   angular
     .module("noosferoApp")
-    .filter("noosferoTemplateFilter", function() {
+    .filter("noosferoTemplate", function() {
       return function(text, options) {
         for(var option in options) {
           text = text.replace('{'+option+'}', options[option]);
diff --git a/src/spec/helpers.ts b/src/spec/helpers.ts
index 7cdf2eb..fc9eb91 100644
--- a/src/spec/helpers.ts
+++ b/src/spec/helpers.ts
@@ -1,7 +1,7 @@
 
 import {ngClass, TestComponentBuilder, ComponentFixture} from 'ng-forward/cjs/testing/test-component-builder';
 import {quickFixture} from 'ng-forward/cjs/tests/utils';
-import {Input, provide, Component} from 'ng-forward';
+import {Provider, Input, provide, Component} from 'ng-forward';
 
 
 
@@ -29,3 +29,10 @@ export function createComponentFromClass(yourClass: ngClass) {
     return tcb.createAsync(yourClass);
 }
 
+export function provideFilters(...filters: string[]) {
+    let providers: Provider[] = [];
+    for (var filter of filters) {
+        providers.push(new Provider(filter, { useValue: () => { } }));
+    }
+    return providers;
+}
--
libgit2 0.21.2