From 0cbc9681bef893f5c215b8977c4ab6d0268aa7e4 Mon Sep 17 00:00:00 2001 From: Nathan Broadbent Date: Sat, 6 Aug 2011 23:30:03 +0800 Subject: [PATCH] Added more info to ApiVersionError, and parsed['version'] should be tested as a string. --- lib/hoptoad.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/hoptoad.rb b/lib/hoptoad.rb index 4bf64e6..a543639 100644 --- a/lib/hoptoad.rb +++ b/lib/hoptoad.rb @@ -3,14 +3,14 @@ module Hoptoad require 'digest/md5' class ApiVersionError < StandardError - def initialize - super "Wrong API Version: Expecting v2.0" + def initialize(version) + super "Wrong API Version: Expecting v2.0, got version: #{version}" end end def self.parse_xml(xml) parsed = ActiveSupport::XmlMini.backend.parse(xml)['notice'] - raise ApiVersionError unless parsed && parsed['version'] == '2.0' + raise ApiVersionError(parsed['version']) unless parsed && parsed['version'].to_s == '2.0' rekeyed = rekey(parsed) rekeyed['fingerprint'] = Digest::MD5.hexdigest(rekeyed['error']['backtrace'].to_s) rekeyed @@ -43,3 +43,4 @@ module Hoptoad end end end + -- libgit2 0.21.2