diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 1f77d9e..30edd5a 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -354,17 +354,6 @@ Style/SpaceInsideBrackets: Style/SpaceInsideHashLiteralBraces: Enabled: false -# Offense count: 9 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/SpaceInsideStringInterpolation: - Exclude: - - 'app/models/issue.rb' - - 'app/models/notification_service.rb' - - 'app/models/notification_services/flowdock_service.rb' - - 'app/models/notification_services/hoiio_service.rb' - - 'spec/controllers/problems_controller_spec.rb' - # Offense count: 873 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. diff --git a/app/models/issue.rb b/app/models/issue.rb index d85dd24..726cbe4 100644 --- a/app/models/issue.rb +++ b/app/models/issue.rb @@ -22,7 +22,7 @@ class Issue if tracker.respond_to?(:title) tracker.title else - "[#{ problem.environment }][#{ problem.where }] #{problem.message.to_s.truncate(100)}" + "[#{problem.environment}][#{problem.where}] #{problem.message.to_s.truncate(100)}" end end diff --git a/app/models/notification_service.rb b/app/models/notification_service.rb index 6bf006b..228ab1b 100644 --- a/app/models/notification_service.rb +++ b/app/models/notification_service.rb @@ -35,7 +35,7 @@ class NotificationService def check_params; true; end def notification_description(problem) - "[#{ problem.environment }][#{ problem.where }] #{problem.message.to_s.truncate(100)}" + "[#{problem.environment}][#{problem.where}] #{problem.message.to_s.truncate(100)}" end # Allows us to set the issue tracker class from a single form. diff --git a/app/models/notification_services/flowdock_service.rb b/app/models/notification_services/flowdock_service.rb index 3563353..da2dfe8 100644 --- a/app/models/notification_services/flowdock_service.rb +++ b/app/models/notification_services/flowdock_service.rb @@ -35,7 +35,7 @@ if defined? Flowdock end def content(problem, url) - full_description = "[#{ problem.environment }][#{ problem.where }] #{problem.message}" + full_description = "[#{problem.environment}][#{problem.where}] #{problem.message}" <<-MSG.strip_heredoc #{ERB::Util.html_escape full_description}
#{url} diff --git a/app/models/notification_services/hoiio_service.rb b/app/models/notification_services/hoiio_service.rb index dfc349d..3106c71 100644 --- a/app/models/notification_services/hoiio_service.rb +++ b/app/models/notification_services/hoiio_service.rb @@ -26,7 +26,7 @@ class NotificationServices::HoiioService < NotificationService end def notification_description(problem) - "[#{ problem.environment }]#{problem.message.to_s.truncate(50)}" + "[#{problem.environment}]#{problem.message.to_s.truncate(50)}" end def create_notification(problem) diff --git a/spec/controllers/problems_controller_spec.rb b/spec/controllers/problems_controller_spec.rb index cbe8534..5612f60 100644 --- a/spec/controllers/problems_controller_spec.rb +++ b/spec/controllers/problems_controller_spec.rb @@ -218,7 +218,7 @@ describe ProblemsController, type: 'controller' do it "should save the right title" do post :create_issue, app_id: problem.app.id, id: problem.id - title = "[#{ problem.environment }][#{ problem.where }] #{problem.message.to_s.truncate(100)}" + title = "[#{problem.environment}][#{problem.where}] #{problem.message.to_s.truncate(100)}" line = issue_tracker.tracker.output.shift expect(line[0]).to eq(title) end -- libgit2 0.21.2