From 55b516633d4ed8f348dd9b70b111ec4efbfecd7c Mon Sep 17 00:00:00 2001 From: Nathan Broadbent Date: Tue, 5 Mar 2013 15:25:32 +1300 Subject: [PATCH] Added column to backtrace for JS errors --- app/models/backtrace_line.rb | 3 ++- app/views/notices/_backtrace_line.html.haml | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/app/models/backtrace_line.rb b/app/models/backtrace_line.rb index a1b3e01..eadfe8e 100644 --- a/app/models/backtrace_line.rb +++ b/app/models/backtrace_line.rb @@ -4,6 +4,7 @@ class BacktraceLine GEMS_PATH = %r{\[GEM_ROOT\]\/gems\/([^\/]+)} field :number, :type => Integer + field :column, :type => Integer field :file field :method @@ -14,7 +15,7 @@ class BacktraceLine delegate :app, :to => :backtrace def to_s - "#{file}:#{number}" + "#{file}:#{number}" << (column.present? ? ":{column}" : "") end def in_app? diff --git a/app/views/notices/_backtrace_line.html.haml b/app/views/notices/_backtrace_line.html.haml index 28eeafd..2517610 100644 --- a/app/views/notices/_backtrace_line.html.haml +++ b/app/views/notices/_backtrace_line.html.haml @@ -5,5 +5,7 @@ %span.file>= line.file_name - if line.number.present? %span.number>= ":#{line.number}" + - if line.column.present? + %span.number>= ":#{line.column}" → %span.method= line.method -- libgit2 0.21.2