From 5cc81085cee1fca1a8718741ad8606696c4c0bf7 Mon Sep 17 00:00:00 2001
From: Arthur Neves <arthurnn@gmail.com>
Date: Tue, 23 Dec 2014 21:43:16 -0500
Subject: [PATCH] Fix tests

---
 spec/controllers/apps_controller_spec.rb   | 36 ------------------------------------
 spec/models/problem_spec.rb                |  2 +-
 spec/views/problems/show.html.haml_spec.rb |  7 ++++---
 3 files changed, 5 insertions(+), 40 deletions(-)

diff --git a/spec/controllers/apps_controller_spec.rb b/spec/controllers/apps_controller_spec.rb
index 7bdd367..77d53ba 100644
--- a/spec/controllers/apps_controller_spec.rb
+++ b/spec/controllers/apps_controller_spec.rb
@@ -308,42 +308,6 @@ describe AppsController do
             expect(@app.issue_tracker_configured?).to eq false
           end
         end
-
-        ErrbitPlugin::Registry.issue_trackers.each do |key, klass|
-          context key do
-            it "should save tracker params" do
-              params = {
-                :options => klass.fields.inject({}){|hash,f| hash[f[0]] = "test_value"; hash },
-                :type_tracker => key.dup.to_s
-              }
-              put :update, :id => @app.id, :app => {:issue_tracker_attributes => params}
-
-              @app.reload
-
-              tracker = @app.issue_tracker
-              expect(tracker.tracker).to be_a(ErrbitPlugin::Registry.issue_trackers[key])
-              klass.fields.each do |field, field_info|
-                case field
-                when :ticket_properties; tracker.send(field.to_sym).should == 'card_type = defect'
-                else tracker.options[field.to_s].should == 'test_value'
-                end
-              end
-            end
-
-            it "should show validation notice when sufficient params are not present" do
-              # Leave out one required param
-              # TODO. previous test was not relevant because one params can be enough. So put noone
-              put :update, :id => @app.id, :app => {
-                :issue_tracker_attributes => {
-                  :type_tracker => key.dup.to_s
-                }
-              }
-
-              @app.reload
-              expect(@app.issue_tracker_configured?).to eq false
-            end
-          end
-        end
       end
     end
 
diff --git a/spec/models/problem_spec.rb b/spec/models/problem_spec.rb
index d9d2c6f..4481aea 100644
--- a/spec/models/problem_spec.rb
+++ b/spec/models/problem_spec.rb
@@ -395,7 +395,7 @@ describe Problem do
         end
 
         it 'return the issue_tracker label' do
-          expect(problem.issue_type).to eql 'fake'
+          expect(problem.issue_type).to eql 'mock'
         end
       end
 
diff --git a/spec/views/problems/show.html.haml_spec.rb b/spec/views/problems/show.html.haml_spec.rb
index be360a0..7ec9a78 100644
--- a/spec/views/problems/show.html.haml_spec.rb
+++ b/spec/views/problems/show.html.haml_spec.rb
@@ -6,13 +6,13 @@ describe "problems/show.html.haml" do
   let(:pivotal_tracker) {
     Class.new(ErrbitPlugin::IssueTracker) do
       def self.label; 'pivotal'; end
-      def initialize(app, params); end
+      def initialize(options); end
       def configured?; true; end
     end
   }
   let(:github_tracker) {
     Class.new(ErrbitPlugin::IssueTracker) do
-      def initialize(app, params); end
+      def initialize(options); end
       def label; 'github'; end
       def configured?; true; end
     end
@@ -36,8 +36,9 @@ describe "problems/show.html.haml" do
   end
 
   def with_issue_tracker(tracker, problem)
-    problem.app.issue_tracker = IssueTracker.new :type_tracker => tracker, :options => {:api_token => "token token token", :project_id => "1234"}
     ErrbitPlugin::Registry.stub(:issue_trackers).and_return(trackers)
+    problem.app.issue_tracker = IssueTracker.new :type_tracker => tracker, :options => {:api_token => "token token token", :project_id => "1234"}
+
     view.stub(:problem).and_return(problem)
     view.stub(:app).and_return(problem.app)
   end
--
libgit2 0.21.2