From 62ee78a8ea9c75264a7b753cfc60023bab58927b Mon Sep 17 00:00:00 2001 From: Nathan Broadbent Date: Wed, 13 Jun 2012 10:57:15 +1200 Subject: [PATCH] Don't crash migration on save if IssueTracker doesn't have username or password --- app/models/issue_trackers/github_issues_tracker.rb | 2 +- db/migrate/20120603112130_change_github_url_to_github_repo.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/issue_trackers/github_issues_tracker.rb b/app/models/issue_trackers/github_issues_tracker.rb index 6dab8c0..7bec1b0 100644 --- a/app/models/issue_trackers/github_issues_tracker.rb +++ b/app/models/issue_trackers/github_issues_tracker.rb @@ -21,7 +21,7 @@ class IssueTrackers::GithubIssuesTracker < IssueTracker def check_params if Fields.detect {|f| self[f[0]].blank? } - errors.add :base, 'You must specify your GitHub repository, username and password' + errors.add :base, 'You must specify your GitHub username and password' end end diff --git a/db/migrate/20120603112130_change_github_url_to_github_repo.rb b/db/migrate/20120603112130_change_github_url_to_github_repo.rb index c51603a..5bda698 100644 --- a/db/migrate/20120603112130_change_github_url_to_github_repo.rb +++ b/db/migrate/20120603112130_change_github_url_to_github_repo.rb @@ -3,7 +3,7 @@ class ChangeGithubUrlToGithubRepo < Mongoid::Migration App.collection.update({}, {'$rename' => {'github_url' => 'github_repo'}}, multi: true, safe: true) App.all.each do |app| app.send :normalize_github_repo - app.save! + app.save end end -- libgit2 0.21.2