diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 1b447c3..9eb7dec 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -318,12 +318,6 @@ Style/LeadingCommentSpace: - 'spec/models/notification_service/hoiio_service_spec.rb' - 'spec/models/notification_service/pushover_service_spec.rb' -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/MethodDefParentheses: - Enabled: false - # Offense count: 7 # Cop supports --auto-correct. Style/MultilineBlockLayout: diff --git a/app/controllers/apps_controller.rb b/app/controllers/apps_controller.rb index 962b08e..ce19b77 100644 --- a/app/controllers/apps_controller.rb +++ b/app/controllers/apps_controller.rb @@ -103,7 +103,7 @@ class AppsController < ApplicationController end end - def plug_params app + def plug_params(app) app.watchers.build if app.watchers.none? app.issue_tracker ||= IssueTracker.new app.notification_service = NotificationService.new unless app.notification_service_configured? diff --git a/app/models/notification_services/gtalk_service.rb b/app/models/notification_services/gtalk_service.rb index 71fd68c..0197fb9 100644 --- a/app/models/notification_services/gtalk_service.rb +++ b/app/models/notification_services/gtalk_service.rb @@ -59,13 +59,13 @@ class NotificationServices::GtalkService < NotificationService private - def send_to_users client, message + def send_to_users(client, message) user_id.tr(' ', ",").tr(';', ",").split(",").map(&:strip).reject(&:empty?).each do |user| client.send(Jabber::Message.new(user, message)) end end - def send_to_muc client, message + def send_to_muc(client, message) #TODO: set this so that it can send to multiple rooms like users, nb multiple room joins in one send fail randomly so leave as one room for the moment muc = Jabber::MUC::SimpleMUCClient.new(client) muc.join(room_id + "/errbit") -- libgit2 0.21.2