Commit 8cc1085f46082944e2d88bacd62d5f239150f210
1 parent
a21ce09a
Exists in
master
and in
1 other branch
Rubocop: method definitions always use ()
Showing
3 changed files
with
3 additions
and
9 deletions
Show diff stats
.rubocop_todo.yml
| @@ -318,12 +318,6 @@ Style/LeadingCommentSpace: | @@ -318,12 +318,6 @@ Style/LeadingCommentSpace: | ||
| 318 | - 'spec/models/notification_service/hoiio_service_spec.rb' | 318 | - 'spec/models/notification_service/hoiio_service_spec.rb' |
| 319 | - 'spec/models/notification_service/pushover_service_spec.rb' | 319 | - 'spec/models/notification_service/pushover_service_spec.rb' |
| 320 | 320 | ||
| 321 | -# Offense count: 3 | ||
| 322 | -# Cop supports --auto-correct. | ||
| 323 | -# Configuration parameters: EnforcedStyle, SupportedStyles. | ||
| 324 | -Style/MethodDefParentheses: | ||
| 325 | - Enabled: false | ||
| 326 | - | ||
| 327 | # Offense count: 7 | 321 | # Offense count: 7 |
| 328 | # Cop supports --auto-correct. | 322 | # Cop supports --auto-correct. |
| 329 | Style/MultilineBlockLayout: | 323 | Style/MultilineBlockLayout: |
app/controllers/apps_controller.rb
| @@ -103,7 +103,7 @@ class AppsController < ApplicationController | @@ -103,7 +103,7 @@ class AppsController < ApplicationController | ||
| 103 | end | 103 | end |
| 104 | end | 104 | end |
| 105 | 105 | ||
| 106 | - def plug_params app | 106 | + def plug_params(app) |
| 107 | app.watchers.build if app.watchers.none? | 107 | app.watchers.build if app.watchers.none? |
| 108 | app.issue_tracker ||= IssueTracker.new | 108 | app.issue_tracker ||= IssueTracker.new |
| 109 | app.notification_service = NotificationService.new unless app.notification_service_configured? | 109 | app.notification_service = NotificationService.new unless app.notification_service_configured? |
app/models/notification_services/gtalk_service.rb
| @@ -59,13 +59,13 @@ class NotificationServices::GtalkService < NotificationService | @@ -59,13 +59,13 @@ class NotificationServices::GtalkService < NotificationService | ||
| 59 | 59 | ||
| 60 | private | 60 | private |
| 61 | 61 | ||
| 62 | - def send_to_users client, message | 62 | + def send_to_users(client, message) |
| 63 | user_id.tr(' ', ",").tr(';', ",").split(",").map(&:strip).reject(&:empty?).each do |user| | 63 | user_id.tr(' ', ",").tr(';', ",").split(",").map(&:strip).reject(&:empty?).each do |user| |
| 64 | client.send(Jabber::Message.new(user, message)) | 64 | client.send(Jabber::Message.new(user, message)) |
| 65 | end | 65 | end |
| 66 | end | 66 | end |
| 67 | 67 | ||
| 68 | - def send_to_muc client, message | 68 | + def send_to_muc(client, message) |
| 69 | #TODO: set this so that it can send to multiple rooms like users, nb multiple room joins in one send fail randomly so leave as one room for the moment | 69 | #TODO: set this so that it can send to multiple rooms like users, nb multiple room joins in one send fail randomly so leave as one room for the moment |
| 70 | muc = Jabber::MUC::SimpleMUCClient.new(client) | 70 | muc = Jabber::MUC::SimpleMUCClient.new(client) |
| 71 | muc.join(room_id + "/errbit") | 71 | muc.join(room_id + "/errbit") |