From 929e795aba1c09a217a1a755fd8ed70c39f793dd Mon Sep 17 00:00:00 2001
From: Dave Miller <dave.miller@renewfund.com>
Date: Mon, 23 Sep 2013 16:55:51 -0700
Subject: [PATCH] Treat request URL as CDATA so query string params don't result in invalid XML

---
 public/javascripts/notifier.js        | 2 +-
 spec/fixtures/hoptoad_test_notice.xml | 2 +-
 spec/models/error_report_spec.rb      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/public/javascripts/notifier.js b/public/javascripts/notifier.js
index 0545032..18aa5b5 100644
--- a/public/javascripts/notifier.js
+++ b/public/javascripts/notifier.js
@@ -506,7 +506,7 @@ printStackTrace.implementation.prototype = {
                 '<backtrace>{backtrace_lines}</backtrace>' +
             '</error>' +
             '<request>' +
-                '<url>{request_url}</url>' +
+                '<url><![CDATA[{request_url}]]></url>' +
                 '<component>{request_component}</component>' +
                 '<action>{request_action}</action>' +
                 '{request}' +
diff --git a/spec/fixtures/hoptoad_test_notice.xml b/spec/fixtures/hoptoad_test_notice.xml
index 699191d..add5d46 100644
--- a/spec/fixtures/hoptoad_test_notice.xml
+++ b/spec/fixtures/hoptoad_test_notice.xml
@@ -87,7 +87,7 @@
     </backtrace>
   </error>
   <request>
-    <url>http://example.org/verify</url>
+    <url><![CDATA[http://example.org/verify/cupcake=fistfight&lovebird=doomsayer]]></url>
     <component>application</component>
     <action>verify</action>
     <params>
diff --git a/spec/models/error_report_spec.rb b/spec/models/error_report_spec.rb
index c58acf6..5f32dea 100644
--- a/spec/models/error_report_spec.rb
+++ b/spec/models/error_report_spec.rb
@@ -84,7 +84,7 @@ describe ErrorReport do
         end
 
         it 'has request' do
-          subject.request['url'].should == 'http://example.org/verify'
+          subject.request['url'].should == 'http://example.org/verify/cupcake=fistfight&lovebird=doomsayer'
           subject.request['params']['controller'].should == 'application'
         end
 
--
libgit2 0.21.2