From 98f4db155e230af6321f049a65da01af006a1894 Mon Sep 17 00:00:00 2001 From: Nathan Broadbent Date: Fri, 9 Sep 2011 17:06:07 +0800 Subject: [PATCH] Fixed line spacing for backtrace, added blank space for empty line numbers --- app/views/notices/_backtrace.html.haml | 7 +++++-- public/stylesheets/application.css | 11 +++++++++-- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/app/views/notices/_backtrace.html.haml b/app/views/notices/_backtrace.html.haml index 2f8662d..7f5438f 100644 --- a/app/views/notices/_backtrace.html.haml +++ b/app/views/notices/_backtrace.html.haml @@ -4,8 +4,11 @@ %th %ul.line-numbers - lines.each do |line| - %li= (@app.github_url? && Notice.in_app_backtrace_line?(line)) ? link_to_github(@app, line, line['number']) : line['number'] - + %li + - if line['number'].present? + = (@app.github_url? && Notice.in_app_backtrace_line?(line)) ? link_to_github(@app, line, line['number']) : line['number'] + - else +   %td %ul.lines - lines.each do |line| diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css index 0809273..2161727 100644 --- a/public/stylesheets/application.css +++ b/public/stylesheets/application.css @@ -691,16 +691,23 @@ table.backtrace td { background-color: #222 !important; } table.backtrace ul.line-numbers li { + border-bottom: 0; text-align: right; + font-size: 13px; + line-height: 21px; } + table.backtrace ul.lines { padding: 10px 8px; overflow: auto; } -table.backtrace li { +table.backtrace ul.lines li { + border-bottom: 1px solid #2B2B2B; + font-size: 13px; + line-height: 20px; white-space: nowrap; } -table.backtrace li.in-app { +table.backtrace ul.lines li.in-app { color: #2adb2e; background-color: #2f2f2f; } -- libgit2 0.21.2