diff --git a/app/controllers/problems_controller.rb b/app/controllers/problems_controller.rb index 71b77fd..801f8a7 100644 --- a/app/controllers/problems_controller.rb +++ b/app/controllers/problems_controller.rb @@ -128,7 +128,6 @@ class ProblemsController < ApplicationController def search ps = Problem.search(params[:search]).for_apps(app_scope).in_env(params[:environment]).all_else_unresolved(params[:all_errs]).ordered_by(params_sort, params_order) - selected_problems = params[:problems] || [] self.problems = ps.page(params[:page]).per(current_user.per_page) respond_to do |format| format.html { render :index } diff --git a/app/helpers/form_helper.rb b/app/helpers/form_helper.rb index ce15967..0463a57 100644 --- a/app/helpers/form_helper.rb +++ b/app/helpers/form_helper.rb @@ -5,8 +5,8 @@ module FormHelper content_tag(:div, :class => 'error-messages') do body = content_tag(:h2, 'Dang. The following errors are keeping this from being a success.') - body += content_tag(:ul) do - document.errors.full_messages.inject('') {|errs, msg| errs += content_tag(:li, h(msg)) }.html_safe + body + content_tag(:ul) do + document.errors.full_messages.inject('') {|errs, msg| errs + content_tag(:li, h(msg)) }.html_safe end end end diff --git a/spec/lib/airbrake_api/v3/notice_parser_spec.rb b/spec/lib/airbrake_api/v3/notice_parser_spec.rb index 53bcaf1..2d7aa5e 100644 --- a/spec/lib/airbrake_api/v3/notice_parser_spec.rb +++ b/spec/lib/airbrake_api/v3/notice_parser_spec.rb @@ -42,7 +42,7 @@ describe AirbrakeApi::V3::NoticeParser do params['key'] = app.api_key report = AirbrakeApi::V3::NoticeParser.new(params).report - notice = report.generate_notice! + report.generate_notice! expect(report.error_class).to eq('Error') expect(report.message).to eq('Error: TestError') @@ -58,4 +58,4 @@ describe AirbrakeApi::V3::NoticeParser do data end -end \ No newline at end of file +end diff --git a/spec/models/notification_service/gtalk_service_spec.rb b/spec/models/notification_service/gtalk_service_spec.rb index 387fe2b..edf016f 100644 --- a/spec/models/notification_service/gtalk_service_spec.rb +++ b/spec/models/notification_service/gtalk_service_spec.rb @@ -2,7 +2,7 @@ describe NotificationServices::GtalkService, type: 'model' do it "it should send a notification to gtalk" do # setup notice = Fabricate :notice - problem = notice.problem + notice.problem notification_service = Fabricate :gtalk_notification_service, :app => notice.app problem = notice.problem @@ -94,7 +94,7 @@ describe NotificationServices::GtalkService, type: 'model' do it "it should send a notification to room only" do # setup notice = Fabricate :notice - problem = notice.problem + notice.problem notification_service = Fabricate :gtalk_notification_service, :app => notice.app problem = notice.problem -- libgit2 0.21.2