From c189653b448c54cd60f71855b08dc7965474abc8 Mon Sep 17 00:00:00 2001 From: Laust Rud Jacobsen Date: Wed, 4 Nov 2015 22:06:51 +0100 Subject: [PATCH] Rubocop: replace "unless/else" with "if/else" with reversed bodies --- .rubocop_todo.yml | 5 ----- app/controllers/problems_searcher.rb | 12 ++++++------ 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 842b0f1..eb9a8a5 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -284,8 +284,3 @@ Style/SymbolProc: - 'app/controllers/users/omniauth_callbacks_controller.rb' - 'app/models/deploy.rb' - 'spec/models/deploy_spec.rb' - -# Offense count: 2 -Style/UnlessElse: - Exclude: - - 'app/controllers/problems_searcher.rb' diff --git a/app/controllers/problems_searcher.rb b/app/controllers/problems_searcher.rb index 0854f5c..270a5ab 100644 --- a/app/controllers/problems_searcher.rb +++ b/app/controllers/problems_searcher.rb @@ -6,18 +6,18 @@ module ProblemsSearcher included do expose(:params_sort) { - unless %w{app message last_notice_at last_deploy_at count}.member?(params[:sort]) - "last_notice_at" - else + if %w{app message last_notice_at last_deploy_at count}.member?(params[:sort]) params[:sort] + else + "last_notice_at" end } expose(:params_order) { - unless %w{asc desc}.member?(params[:order]) - 'desc' - else + if %w{asc desc}.member?(params[:order]) params[:order] + else + 'desc' end } -- libgit2 0.21.2