From dba2a9eb57391e317100af76538d8c365c7e0b33 Mon Sep 17 00:00:00 2001 From: Laust Rud Jacobsen Date: Wed, 4 Nov 2015 21:16:03 +0100 Subject: [PATCH] Rubocop: move towards fewer single line block invocations --- .rubocop_todo.yml | 5 +---- app/helpers/form_helper.rb | 4 +++- app/models/notice_fingerprinter.rb | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index b22e20d..26a056a 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -273,13 +273,10 @@ Style/SignalException: - 'lib/airbrake_api/v3/notice_parser.rb' - 'lib/hoptoad.rb' -# Offense count: 4 +# Offense count: 1 # Configuration parameters: Methods. Style/SingleLineBlockParams: Exclude: - - 'app/helpers/application_helper.rb' - - 'app/helpers/form_helper.rb' - - 'app/models/notice_fingerprinter.rb' - 'lib/hoptoad/v2.rb' # Offense count: 11 diff --git a/app/helpers/form_helper.rb b/app/helpers/form_helper.rb index d0784b3..66aadc8 100644 --- a/app/helpers/form_helper.rb +++ b/app/helpers/form_helper.rb @@ -5,7 +5,9 @@ module FormHelper content_tag(:div, :class => 'error-messages') do body = content_tag(:h2, 'Dang. The following errors are keeping this from being a success.') body + content_tag(:ul) do - document.errors.full_messages.inject('') {|errs, msg| errs + content_tag(:li, h(msg)) }.html_safe + document.errors.full_messages.inject('') do |errs, msg| + errs + content_tag(:li, h(msg)) + end.html_safe end end end diff --git a/app/models/notice_fingerprinter.rb b/app/models/notice_fingerprinter.rb index 0bdc7c9..34fe17c 100644 --- a/app/models/notice_fingerprinter.rb +++ b/app/models/notice_fingerprinter.rb @@ -27,6 +27,6 @@ class NoticeFingerprinter material << backtrace.lines.slice(0, backtrace_lines) end - Digest::MD5.hexdigest(material.reduce('') { |c, m| c << m.to_s; c }) + Digest::MD5.hexdigest(material.map(&:to_s).join) end end -- libgit2 0.21.2