diff --git a/plugins/oauth_client/test/functional/oauth_client_plugin_public_controller_test.rb b/plugins/oauth_client/test/functional/oauth_client_plugin_public_controller_test.rb index a4d0f95..77bfc3b 100644 --- a/plugins/oauth_client/test/functional/oauth_client_plugin_public_controller_test.rb +++ b/plugins/oauth_client/test/functional/oauth_client_plugin_public_controller_test.rb @@ -65,6 +65,14 @@ class OauthClientPluginPublicControllerTest < ActionController::TestCase assert session[:external].present? end + should 'not create an user when performing external login' do + request.env["omniauth.params"] = {"action" => "external_login"} + + assert_no_difference 'User.count' do + get :callback + end + end + should 'not perform external login when the provider is disabled' do request.env["omniauth.params"] = {"action" => "external_login"} provider.update_attribute(:enabled, false) diff --git a/plugins/oauth_client/views/auth/_oauth_login.html.erb b/plugins/oauth_client/views/auth/_oauth_login.html.erb index 931db98..f57fa74 100644 --- a/plugins/oauth_client/views/auth/_oauth_login.html.erb +++ b/plugins/oauth_client/views/auth/_oauth_login.html.erb @@ -8,7 +8,7 @@ <% if OauthClientPlugin::Config.instance.allow_external_login %> <%= _('Login with:') %>
- <%= render :partial => 'auth/generate_providers_links', :locals => {:providers => providers, :action => "external_login"} %> + <%= render :partial => 'auth/generate_providers_links', :locals => {:providers => providers, :action => "external_login"} %>
<% end %> -- libgit2 0.21.2