From 7aa42ede6046e3730393cebf58188c7e12be2f85 Mon Sep 17 00:00:00 2001 From: Braulio Bhavamitra Date: Fri, 19 Feb 2016 23:18:10 -0300 Subject: [PATCH] selenium: Speed up visibility checks --- features/admin_categories.feature | 2 +- features/comment.feature | 2 +- features/step_definitions/custom_web_steps.rb | 8 ++------ 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/features/admin_categories.feature b/features/admin_categories.feature index 75b6caf..59d75a2 100644 --- a/features/admin_categories.feature +++ b/features/admin_categories.feature @@ -45,7 +45,7 @@ Feature: manage categories And I should see "Steak" When I follow "Hide" Then I should not see "Vegetarian" - And "Steak" should not be visible within "div" + And I should not see "Steak" @selenium Scenario: the show link is available just for categories with category tree diff --git a/features/comment.feature b/features/comment.feature index b7569c5..1510805 100644 --- a/features/comment.feature +++ b/features/comment.feature @@ -96,4 +96,4 @@ Feature: comment Scenario: hide post a comment button when clicked Given I am on /booking/article-to-comment And I follow "Post a comment" - Then "Post a comment" should not be visible within "#article" + Then "Post comment" should not be visible within "#article" diff --git a/features/step_definitions/custom_web_steps.rb b/features/step_definitions/custom_web_steps.rb index 48ed077..05532f1 100644 --- a/features/step_definitions/custom_web_steps.rb +++ b/features/step_definitions/custom_web_steps.rb @@ -1,13 +1,9 @@ Then /^"([^"]*)" should not be visible within "([^"]*)"$/ do |text, selector| - if page.has_content?(text) - page.should have_no_css(selector, :text => text, :visible => false) - end + page.should have_no_css selector, text: text, visible: false end Then /^"([^"]*)" should be visible within "([^"]*)"$/ do |text, selector| - if page.has_content?(text) - page.should have_css(selector, :text => text, :visible => false) - end + page.should have_css selector, text: text, visible: false end Then /^I should see "([^"]*)" link$/ do |text| -- libgit2 0.21.2