From e59ccc620d8e7c3201250617faedcba82d985491 Mon Sep 17 00:00:00 2001 From: Leandro Nunes dos Santos Date: Tue, 30 Aug 2016 16:13:02 -0300 Subject: [PATCH] should not check requestor on approve article task --- app/models/approve_article.rb | 3 --- test/unit/approve_article_test.rb | 5 ++--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/app/models/approve_article.rb b/app/models/approve_article.rb index 2903a04..0b345aa 100644 --- a/app/models/approve_article.rb +++ b/app/models/approve_article.rb @@ -9,9 +9,6 @@ class ApproveArticle < Task if target.person? && requestor != target self.errors.add(:requestor, _('You can not post articles to other users.')) end - if target.organization? && !target.members.include?(requestor) && target.environment.portal_community != target - self.errors.add(:requestor, _('Only members can post articles on communities.')) - end end end diff --git a/test/unit/approve_article_test.rb b/test/unit/approve_article_test.rb index 3bc3227..5565c0a 100644 --- a/test/unit/approve_article_test.rb +++ b/test/unit/approve_article_test.rb @@ -462,7 +462,7 @@ class ApproveArticleTest < ActiveSupport::TestCase assert t2.invalid?(:requestor) end - should 'allow only members to be requestors when target is a community' do + should 'allow anyone to be requestors when target is a community' do community = fast_create(Community) member = fast_create(Person) community.add_member(member) @@ -472,8 +472,7 @@ class ApproveArticleTest < ActiveSupport::TestCase t2 = ApproveArticle.new(:requestor => non_member, :target => community) assert t1.valid? - assert !t2.valid? - assert t2.invalid?(:requestor) + assert t2.valid? end should 'allow any user to be requestor whe the target is the portal community' do -- libgit2 0.21.2