From ad33d466992f59b7d7fda08258242c0171e145f0 Mon Sep 17 00:00:00 2001
From: Perry Werneck <perry.werneck@gmail.com>
Date: Tue, 15 Jan 2019 15:22:38 -0200
Subject: [PATCH] Fixing memory leak when getting CRL from LDAP.

---
 lib3270.cbp                    | 7 ++++++-
 src/lib3270/ssl/linux/getcrl.c | 7 ++++---
 src/lib3270/trace_ds.c         | 1 -
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/lib3270.cbp b/lib3270.cbp
index 81dc8c6..a2b0dae 100644
--- a/lib3270.cbp
+++ b/lib3270.cbp
@@ -12,6 +12,8 @@
 				<Option object_output=".obj/Debug/" />
 				<Option type="3" />
 				<Option compiler="gcc" />
+				<Option host_application=".bin/Debug/lib3270" />
+				<Option run_host_application_in_terminal="0" />
 				<Compiler>
 					<Add option="-g" />
 				</Compiler>
@@ -211,7 +213,10 @@
 		<Unit filename="src/lib3270/sf.c">
 			<Option compilerVar="CC" />
 		</Unit>
-		<Unit filename="src/lib3270/ssl/linux/ctx_init.c">
+		<Unit filename="src/lib3270/ssl/ctx_init.c">
+			<Option compilerVar="CC" />
+		</Unit>
+		<Unit filename="src/lib3270/ssl/linux/getcrl.c">
 			<Option compilerVar="CC" />
 		</Unit>
 		<Unit filename="src/lib3270/ssl/negotiate.c">
diff --git a/src/lib3270/ssl/linux/getcrl.c b/src/lib3270/ssl/linux/getcrl.c
index 97c79ee..810b787 100644
--- a/src/lib3270/ssl/linux/getcrl.c
+++ b/src/lib3270/ssl/linux/getcrl.c
@@ -267,9 +267,10 @@ X509_CRL * lib3270_get_X509_CRL(H3270 *hSession, SSL_ERROR_MESSAGE * message)
 			return NULL;
 		}
 
-		debug("CRL Length=%d",(int) value[0]->bv_len);
+		// Precisa salvar uma cópia porque d2i_X509_CRL modifica o ponteiro.
+		const unsigned char *crl_data = (const unsigned char *) value[0]->bv_val;
 
-		if(!d2i_X509_CRL(&crl, (const unsigned char **) &value[0]->bv_val, value[0]->bv_len))
+		if(!d2i_X509_CRL(&crl, &crl_data, value[0]->bv_len))
 		{
 			message->error = hSession->ssl.error = ERR_get_error();
 			message->title = N_( "Security error" );
@@ -277,7 +278,7 @@ X509_CRL * lib3270_get_X509_CRL(H3270 *hSession, SSL_ERROR_MESSAGE * message)
 			lib3270_write_log(hSession,"ssl","%s: %s",url, message->text);
 		}
 
-		// ldap_value_free_len(value);
+		ldap_value_free_len(value);
 
 	}
 #endif // HAVE_LDAP
diff --git a/src/lib3270/trace_ds.c b/src/lib3270/trace_ds.c
index b32b914..d8b8ca3 100644
--- a/src/lib3270/trace_ds.c
+++ b/src/lib3270/trace_ds.c
@@ -183,7 +183,6 @@ void trace_ssl(H3270 *session, const char *fmt, ...)
 {
 	va_list args;
 
-	debug("******************* %d",(int) lib3270_get_toggle(session,LIB3270_TOGGLE_SSL_TRACE));
 	if (!lib3270_get_toggle(session,LIB3270_TOGGLE_SSL_TRACE))
 		return;
 
--
libgit2 0.21.2