From fc19e1dc6943e01be04088751556b98783f2df31 Mon Sep 17 00:00:00 2001 From: Macartur Sousa Date: Thu, 20 Aug 2015 10:43:12 -0300 Subject: [PATCH] Fixed flake8 warnings --- colab_spb/tests/test_get_list.py | 16 +++++++++------- colab_spb/urls.py | 6 +++--- colab_spb/views.py | 30 +++++++++++++++--------------- 3 files changed, 27 insertions(+), 25 deletions(-) diff --git a/colab_spb/tests/test_get_list.py b/colab_spb/tests/test_get_list.py index 055cae9..e5cf200 100644 --- a/colab_spb/tests/test_get_list.py +++ b/colab_spb/tests/test_get_list.py @@ -1,7 +1,6 @@ -from django.http import HttpResponsePermanentRedirect +# -*- coding: utf-8 -*- from django.test import TestCase, Client -from colab.super_archives.models import * class ColabSPB(TestCase): @@ -16,17 +15,20 @@ class ColabSPB(TestCase): def test_getlist_without_list(self): response = self.client.get("/spb/get_list/?list_name=") - self.assertEqual("",response.content) - self.assertEqual(404,response.status_code) + message = ("Não foi encontrada lista de discussão a está" + "comunidade, para mais detalhes contacte o" + "administrador.") + self.assertEqual(message, response.content) + self.assertEqual(404, response.status_code) def test_getlist_with_list(self): response = self.client.get("/spb/get_list/?list_name=ListA&MAX=5") - self.assertEqual(5,len(response.context[1]['latest'])) + self.assertEqual(5, len(response.context[1]['latest'])) def test_getlist_default_MAX(self): response = self.client.get("/spb/get_list/?list_name=ListA") - self.assertEqual(7,len(response.context[1]['latest'])) + self.assertEqual(7, len(response.context[1]['latest'])) def test_getlist_invalid_MAX(self): response = self.client.get("/spb/get_list/?list_name=ListA&MAX=") - self.assertEqual(7,len(response.context[1]['latest'])) + self.assertEqual(7, len(response.context[1]['latest'])) diff --git a/colab_spb/urls.py b/colab_spb/urls.py index 0f7c0a2..e5ce1c0 100644 --- a/colab_spb/urls.py +++ b/colab_spb/urls.py @@ -2,6 +2,6 @@ from django.conf.urls import patterns, url from . import views urlpatterns = patterns('', - url( r'^get_list/$',views.get_list, name='get_list'), - url( r'^feed_repository/$',views.feed_repository, name='feed_repository'), -) + url(r'^get_list/$', views.get_list, name='get_list'), + url(r'^feed_repository/$', views.feed_repository, + name='feed_repository'), ) diff --git a/colab_spb/views.py b/colab_spb/views.py index c765f52..bc5665f 100644 --- a/colab_spb/views.py +++ b/colab_spb/views.py @@ -1,15 +1,14 @@ # -*- coding: utf-8 -*- from django.shortcuts import render from django.http import HttpResponse -from django.utils.translation import ugettext as _ from colab.super_archives.models import MailingList, Thread from colab.accounts.utils import mailman from colab.accounts.models import User -def get_list(request): - list_name = request.GET.get('list_name',None) - MAX = request.GET.get('MAX',7) +def get_list(request): + list_name = request.GET.get('list_name', None) + MAX = request.GET.get('MAX', 7) if not MAX: MAX = 7 @@ -42,26 +41,27 @@ def get_list(request): )) if len(context['lists']) == 0: - return HttpResponse("""Não foi encontrada lista de discussão a está - comunidade, para mais detalhes contacte o - administrador.""",status=404) + message = ("Não foi encontrada lista de discussão a está" + "comunidade, para mais detalhes contacte o" + "administrador.") + return HttpResponse(message, status=404) - return render(request,"discussion.html",context) + return render(request, "discussion.html", context) def feed_repository(request): - group = request.GET.get('group',"") - project = request.GET.get('project',"") - limit = request.GET.get("limit",20) + group = request.GET.get('group', "") + project = request.GET.get('project', "") + limit = request.GET.get("limit", 20) context = {} - context['url']= '/gitlab' + context['url'] = '/gitlab' - if group : + if group: context['url'] += "/"+group - if project : + if project: context['url'] += "/"+project if limit: context['limit'] = limit - return render(request,"feed_repository.html",context) + return render(request, "feed_repository.html", context) -- libgit2 0.21.2