From f3c7a21c472f6d0f53f9f2cec5c4c1bb673897a5 Mon Sep 17 00:00:00 2001
From: Athos Ribeiro <athoscribeiro@gmail.com>
Date: Mon, 2 Nov 2015 11:26:02 -0200
Subject: [PATCH] only compare versions against git ones

---
 README.md            |  2 +-
 spb_copr_status.psgi | 24 ++++++++++++++++--------
 template.html.tt     |  4 ++--
 3 files changed, 19 insertions(+), 11 deletions(-)

diff --git a/README.md b/README.md
index d7d3f65..0b47e55 100644
--- a/README.md
+++ b/README.md
@@ -11,7 +11,7 @@ Note that this app consists of a single PSGI script, a template file and Bootstr
 In order to use this app you will need perl 5 and the following perl modules installed:
 
 Plack
-LWP::Simple
+LWP::UserAgent
 JSON
 Text::Template
 
diff --git a/spb_copr_status.psgi b/spb_copr_status.psgi
index 53166dd..5199f5a 100644
--- a/spb_copr_status.psgi
+++ b/spb_copr_status.psgi
@@ -59,19 +59,27 @@ sub info2html {
   my $table_entries="";
   foreach my $key (%{$info}) {
     next if(ref($key) eq 'HASH');
-    my $fill_row;
-    if($info->{$key}->{'v4_version'} eq $info->{$key}->{'v5_version'} && $info->{$key}->{'v4_version'} eq $info->{$key}->{git_version}) {
-      $fill_row = "success";
+    my $fill_v4_row;
+    my $fill_v5_row;
+    if($info->{$key}->{'v4_version'} eq $info->{$key}->{git_version}) {
+      $fill_v4_row = "success";
     }
     else {
-      $fill_row = "danger";
+      $fill_v4_row = "danger";
     }
 
-    $table_entries .= "<tr class=\"$fill_row\">
-    <td>$key</td>
-    <td>$info->{$key}->{'v4_version'}</td>
-    <td>$info->{$key}->{'v5_version'}</td>
+    if($info->{$key}->{'v5_version'} eq $info->{$key}->{git_version}) {
+      $fill_v5_row = "success";
+    }
+    else {
+      $fill_v5_row = "danger";
+    }
+
+    $table_entries .= "<tr>
+    <td><b>$key</b></td>
     <td>$info->{$key}->{'git_version'}</td>
+    <td class=\"$fill_v4_row\">$info->{$key}->{'v4_version'}</td>
+    <td class=\"$fill_v5_row\">$info->{$key}->{'v5_version'}</td>
     </tr>";
   }
 
diff --git a/template.html.tt b/template.html.tt
index 33d28d3..4d2c5cc 100644
--- a/template.html.tt
+++ b/template.html.tt
@@ -27,7 +27,7 @@
       </div>
 
       <div class="jumbotron">
-        <p class="lead">This app fetches data from softwarepublico Copr EPEL7 repositories and compares package versions. In short, red rows mean package versions differ among the repositories and/or git (<b>note that this is NOT necessarily a bad thing</b>).</p>
+        <p class="lead">This app fetches data from softwarepublico Copr EPEL7 repositories and compares package versions. In short, a red cell means that the package version differ from the git one (<b>note that this is NOT necessarily a bad thing</b>).</p>
         <div class="row">
           <div class="col-md-6 col-md-offset-3">
             <table class="table table-striped">
@@ -45,9 +45,9 @@
       <table class="table table-striped">
         <tr>
           <th>PACKAGE</th>
+          <th>git</th>
           <th>softwarepublico/v4</th>
           <th>softwarepublico/v5</th>
-          <th>git</th>
         </tr>
         {$table_entries}
       </table>
--
libgit2 0.21.2