From 1af65c96c952fd7b02b24cae34e526d7dd7b5950 Mon Sep 17 00:00:00 2001 From: Jacob Vosmaer Date: Fri, 6 Dec 2013 13:20:35 +0100 Subject: [PATCH] Avoid duplicate group membership emails --- app/observers/users_group_observer.rb | 2 +- spec/observers/users_group_observer_spec.rb | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/app/observers/users_group_observer.rb b/app/observers/users_group_observer.rb index ecdbede..42a05b5 100644 --- a/app/observers/users_group_observer.rb +++ b/app/observers/users_group_observer.rb @@ -4,6 +4,6 @@ class UsersGroupObserver < BaseObserver end def after_update(membership) - notification.update_group_member(membership) + notification.update_group_member(membership) if membership.group_access_changed? end end diff --git a/spec/observers/users_group_observer_spec.rb b/spec/observers/users_group_observer_spec.rb index 3bf562e..6548480 100644 --- a/spec/observers/users_group_observer_spec.rb +++ b/spec/observers/users_group_observer_spec.rb @@ -23,5 +23,10 @@ describe UsersGroupObserver do subject.should_receive(:notification) @membership.update_attribute(:group_access, UsersGroup::MASTER) end + + it "does not send an email when the access level has not changed" do + subject.should_not_receive(:notification) + @membership.update_attribute(:group_access, UsersGroup::OWNER) + end end end -- libgit2 0.21.2