diff --git a/app/decorators/commit_decorator.rb b/app/decorators/commit_decorator.rb index 69d5b17..a066b2e 100644 --- a/app/decorators/commit_decorator.rb +++ b/app/decorators/commit_decorator.rb @@ -76,7 +76,7 @@ class CommitDecorator < ApplicationDecorator source_name = send "#{options[:source]}_name".to_sym source_email = send "#{options[:source]}_email".to_sym text = if options[:avatar] - avatar = h.image_tag h.gravatar_icon(source_email, options[:size]), class: "avatar #{"s#{options[:size]}" if options[:size]}", width: options[:size] + avatar = h.image_tag h.gravatar_icon(source_email, options[:size]), class: "avatar #{"s#{options[:size]}" if options[:size]}", width: options[:size], alt: "" %Q{#{avatar} #{source_name}} else source_name diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index a689213..e130c09 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -30,7 +30,9 @@ module ApplicationHelper args.any? { |v| v.to_s.downcase == action_name } end - def gravatar_icon(user_email = '', size = 40) + def gravatar_icon(user_email = '', size = nil) + size = 40 if size.nil? || size <= 0 + if Gitlab.config.disable_gravatar? || user_email.blank? 'no_avatar.png' else -- libgit2 0.21.2