From 77d0e41df00c45aaafdec5fd6cdddce003c29445 Mon Sep 17 00:00:00 2001 From: Nihad Abbasov Date: Tue, 7 May 2013 00:09:23 +0500 Subject: [PATCH] fix API route to delete project hook --- lib/api/projects.rb | 2 +- spec/requests/api/projects_spec.rb | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/api/projects.rb b/lib/api/projects.rb index 53fd91d..18e912f 100644 --- a/lib/api/projects.rb +++ b/lib/api/projects.rb @@ -274,7 +274,7 @@ module Gitlab # hook_id (required) - The ID of hook to delete # Example Request: # DELETE /projects/:id/hooks/:hook_id - delete ":id/hooks" do + delete ":id/hooks/:hook_id" do authorize! :admin_project, user_project required_attributes! [:hook_id] diff --git a/spec/requests/api/projects_spec.rb b/spec/requests/api/projects_spec.rb index a3620d0..4fd6d5a 100644 --- a/spec/requests/api/projects_spec.rb +++ b/spec/requests/api/projects_spec.rb @@ -467,21 +467,21 @@ describe Gitlab::API do end end - describe "DELETE /projects/:id/hooks" do + describe "DELETE /projects/:id/hooks/:hook_id" do it "should delete hook from project" do expect { - delete api("/projects/#{project.id}/hooks", user), hook_id: hook.id + delete api("/projects/#{project.id}/hooks/#{hook.id}", user) }.to change {project.hooks.count}.by(-1) response.status.should == 200 end it "should return success when deleting hook" do - delete api("/projects/#{project.id}/hooks", user), hook_id: hook.id + delete api("/projects/#{project.id}/hooks/#{hook.id}", user) response.status.should == 200 end it "should return success when deleting non existent hook" do - delete api("/projects/#{project.id}/hooks", user), hook_id: 42 + delete api("/projects/#{project.id}/hooks/42", user) response.status.should == 200 end -- libgit2 0.21.2