From 98b7717df7e455b745c47582dcd5718f2ab904a2 Mon Sep 17 00:00:00 2001
From: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Date: Thu, 4 Apr 2013 10:53:39 +0300
Subject: [PATCH] Remove user decorator

---
 app/assets/stylesheets/common.scss                | 18 +++---------------
 app/controllers/admin/teams/members_controller.rb |  1 -
 app/controllers/milestones_controller.rb          |  2 +-
 app/controllers/teams/members_controller.rb       |  1 -
 app/decorators/user_decorator.rb                  | 11 -----------
 app/models/user.rb                                |  4 ++++
 app/views/issues/_issue.html.haml                 |  2 +-
 app/views/milestones/show.html.haml               |  3 +--
 8 files changed, 10 insertions(+), 32 deletions(-)
 delete mode 100644 app/decorators/user_decorator.rb

diff --git a/app/assets/stylesheets/common.scss b/app/assets/stylesheets/common.scss
index 0f66536..7d315a1 100644
--- a/app/assets/stylesheets/common.scss
+++ b/app/assets/stylesheets/common.scss
@@ -111,22 +111,10 @@ span.update-author {
 }
 
 .label {
-  padding: 0px 4px;
-  font-size: 10px;
+  padding: 1px 4px;
+  font-size: 12px;
   font-style: normal;
-  background-color: $link_color;
-
-  &.label-success {
-    background-color: #8D8;
-    color: #333;
-    text-shadow: 0 1px 1px white;
-  }
-
-  &.label-error {
-    background-color: #D88;
-    color: #333;
-    text-shadow: 0 1px 1px white;
-  }
+  font-weight: normal;
 }
 
 form {
diff --git a/app/controllers/admin/teams/members_controller.rb b/app/controllers/admin/teams/members_controller.rb
index e646987..a5a6030 100644
--- a/app/controllers/admin/teams/members_controller.rb
+++ b/app/controllers/admin/teams/members_controller.rb
@@ -1,7 +1,6 @@
 class Admin::Teams::MembersController < Admin::Teams::ApplicationController
   def new
     @users = User.potential_team_members(user_team)
-    @users = UserDecorator.decorate_collection @users
   end
 
   def create
diff --git a/app/controllers/milestones_controller.rb b/app/controllers/milestones_controller.rb
index cdac28c..135281b 100644
--- a/app/controllers/milestones_controller.rb
+++ b/app/controllers/milestones_controller.rb
@@ -32,7 +32,7 @@ class MilestonesController < ProjectResourceController
 
   def show
     @issues = @milestone.issues
-    @users = UserDecorator.decorate_collection(@milestone.participants)
+    @users = @milestone.participants
     @merge_requests = @milestone.merge_requests
 
     respond_to do |format|
diff --git a/app/controllers/teams/members_controller.rb b/app/controllers/teams/members_controller.rb
index f87d422..8af27e0 100644
--- a/app/controllers/teams/members_controller.rb
+++ b/app/controllers/teams/members_controller.rb
@@ -8,7 +8,6 @@ class Teams::MembersController < Teams::ApplicationController
 
   def new
     @users = User.potential_team_members(user_team)
-    @users = UserDecorator.decorate_collection @users
   end
 
   def create
diff --git a/app/decorators/user_decorator.rb b/app/decorators/user_decorator.rb
deleted file mode 100644
index af9c6a6..0000000
--- a/app/decorators/user_decorator.rb
+++ /dev/null
@@ -1,11 +0,0 @@
-class UserDecorator < ApplicationDecorator
-  decorates :user
-
-  def avatar_image size = 16
-    h.image_tag h.gravatar_icon(self.email, size), class: "avatar #{"s#{size}"}", width: size
-  end
-
-  def tm_of(project)
-    project.team_member_by_id(self.id)
-  end
-end
diff --git a/app/models/user.rb b/app/models/user.rb
index 4559363..a835e52 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -373,4 +373,8 @@ class User < ActiveRecord::Base
   def name_with_username
     "#{name} (#{username})"
   end
+
+  def tm_of(project)
+    project.team_member_by_id(self.id)
+  end
 end
diff --git a/app/views/issues/_issue.html.haml b/app/views/issues/_issue.html.haml
index 3d1ecd4..ab34116 100644
--- a/app/views/issues/_issue.html.haml
+++ b/app/views/issues/_issue.html.haml
@@ -34,6 +34,6 @@
       = render 'votes/votes_inline', votable: issue
     %span
       - issue.labels.each do |label|
-        %span.label
+        %span.label.label-info
           %i.icon-tag
           = label.name
diff --git a/app/views/milestones/show.html.haml b/app/views/milestones/show.html.haml
index e1808a2..747ce74 100644
--- a/app/views/milestones/show.html.haml
+++ b/app/views/milestones/show.html.haml
@@ -88,7 +88,6 @@
 %div
   - @users.each do |user|
     = link_to user, class: 'float-link' do
-      = user.avatar_image
-      = user.name
+      = link_to_member(@project, user)
 
 .clearfix
--
libgit2 0.21.2