From c78393ec1714daaa01313793cdc3fa2e98378d7a Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Fri, 21 Jun 2013 22:08:16 +0300 Subject: [PATCH] Remove $.ready events --- app/views/compare/_form.html.haml | 14 ++++++-------- app/views/layouts/_init_auto_complete.html.haml | 8 +++----- app/views/merge_requests/_form.html.haml | 22 ++++++++++------------ app/views/milestones/_form.html.haml | 12 +++++------- app/views/search/_result.html.haml | 4 +--- 5 files changed, 25 insertions(+), 35 deletions(-) diff --git a/app/views/compare/_form.html.haml b/app/views/compare/_form.html.haml index ef80cd4..ccdd0fc 100644 --- a/app/views/compare/_form.html.haml +++ b/app/views/compare/_form.html.haml @@ -27,13 +27,11 @@ :javascript - $(function() { - var availableTags = #{@project.repository.ref_names.to_json}; + var availableTags = #{@project.repository.ref_names.to_json}; - $("#from, #to").autocomplete({ - source: availableTags, - minLength: 1 - }); - - disableButtonIfEmptyField('#to', '.commits-compare-btn'); + $("#from, #to").autocomplete({ + source: availableTags, + minLength: 1 }); + + disableButtonIfEmptyField('#to', '.commits-compare-btn'); diff --git a/app/views/layouts/_init_auto_complete.html.haml b/app/views/layouts/_init_auto_complete.html.haml index 3549794..7d16a75 100644 --- a/app/views/layouts/_init_auto_complete.html.haml +++ b/app/views/layouts/_init_auto_complete.html.haml @@ -1,6 +1,4 @@ :javascript - $(function() { - GitLab.GfmAutoComplete.dataSource = "#{autocomplete_sources_project_path(@project)}" - GitLab.GfmAutoComplete.Emoji.assetBase = '#{image_path("emoji")}' - GitLab.GfmAutoComplete.setup(); - }); + GitLab.GfmAutoComplete.dataSource = "#{autocomplete_sources_project_path(@project)}" + GitLab.GfmAutoComplete.Emoji.assetBase = '#{image_path("emoji")}' + GitLab.GfmAutoComplete.setup(); diff --git a/app/views/merge_requests/_form.html.haml b/app/views/merge_requests/_form.html.haml index 1c3aca1..24e6624 100644 --- a/app/views/merge_requests/_form.html.haml +++ b/app/views/merge_requests/_form.html.haml @@ -62,20 +62,18 @@ Cancel :javascript - $(function(){ - disableButtonIfEmptyField("#merge_request_title", ".btn-save"); + disableButtonIfEmptyField("#merge_request_title", ".btn-save"); - var source_branch = $("#merge_request_source_branch") - , target_branch = $("#merge_request_target_branch"); + var source_branch = $("#merge_request_source_branch") + , target_branch = $("#merge_request_target_branch"); - $.get("#{branch_from_project_merge_requests_path(@project)}", {ref: source_branch.val() }); - $.get("#{branch_to_project_merge_requests_path(@project)}", {ref: target_branch.val() }); + $.get("#{branch_from_project_merge_requests_path(@project)}", {ref: source_branch.val() }); + $.get("#{branch_to_project_merge_requests_path(@project)}", {ref: target_branch.val() }); - source_branch.live("change", function() { - $.get("#{branch_from_project_merge_requests_path(@project)}", {ref: $(this).val() }); - }); + source_branch.live("change", function() { + $.get("#{branch_from_project_merge_requests_path(@project)}", {ref: $(this).val() }); + }); - target_branch.live("change", function() { - $.get("#{branch_to_project_merge_requests_path(@project)}", {ref: $(this).val() }); - }); + target_branch.live("change", function() { + $.get("#{branch_to_project_merge_requests_path(@project)}", {ref: $(this).val() }); }); diff --git a/app/views/milestones/_form.html.haml b/app/views/milestones/_form.html.haml index fbaf64a..50e3e71 100644 --- a/app/views/milestones/_form.html.haml +++ b/app/views/milestones/_form.html.haml @@ -40,10 +40,8 @@ :javascript - $(function() { - disableButtonIfEmptyField("#milestone_title", ".btn-save"); - $( ".datepicker" ).datepicker({ - dateFormat: "yy-mm-dd", - onSelect: function(dateText, inst) { $("#milestone_due_date").val(dateText) } - }).datepicker("setDate", $.datepicker.parseDate('yy-mm-dd', $('#milestone_due_date').val())); - }); + disableButtonIfEmptyField("#milestone_title", ".btn-save"); + $( ".datepicker" ).datepicker({ + dateFormat: "yy-mm-dd", + onSelect: function(dateText, inst) { $("#milestone_due_date").val(dateText) } + }).datepicker("setDate", $.datepicker.parseDate('yy-mm-dd', $('#milestone_due_date').val())); diff --git a/app/views/search/_result.html.haml b/app/views/search/_result.html.haml index 4d8caa5..4e56eea 100644 --- a/app/views/search/_result.html.haml +++ b/app/views/search/_result.html.haml @@ -49,7 +49,5 @@ = paginate @blobs, theme: 'gitlab' :javascript - $(function() { - $(".search_results .term").highlight("#{escape_javascript(params[:search])}"); - }) + $(".search_results .term").highlight("#{escape_javascript(params[:search])}"); -- libgit2 0.21.2