From 28a22dbcbf16512c48277b15b9f4527e10d9aae8 Mon Sep 17 00:00:00 2001
From: ArthurJahn <stutrzbecher@gmail.com>
Date: Thu, 13 Aug 2015 11:53:34 -0300
Subject: [PATCH] Removing general bad smells in catalog html pages

---
 views/search/_catalog_filter.html.erb       | 17 ++++++-----------
 views/search/_software_search_form.html.erb |  2 +-
 views/search/software_infos.html.erb        |  4 +---
 3 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/views/search/_catalog_filter.html.erb b/views/search/_catalog_filter.html.erb
index 04151c5..7ce8d23 100644
--- a/views/search/_catalog_filter.html.erb
+++ b/views/search/_catalog_filter.html.erb
@@ -9,22 +9,20 @@
 
     <div id="filter-categories-catalog"><h4> <%= _("Categories") %> </h4></div>
       <div id="group-categories">
-        <div id="group-catalog-01">
+        <ul>
           <% @categories_groupe_one.each do |category| %>
-            <label>
+            <li>
               <%= check_box_tag("selected_categories_id[]", category.id, @selected_categories_id.include?(category.id), :class => "categories-catalog", @enabled_check_box[category] => "true") %>
               <span><%= _("#{category.name}") %></span>
-            </label> <br>
+            </li>
           <% end %>
-        </div>
-        <div id="group-catalog-02">
           <% @categories_groupe_two.each do |category| %>
-            <label>
+            <li>
               <%= check_box_tag("selected_categories_id[]", category.id, @selected_categories_id.include?(category.id), :class => "categories-catalog", @enabled_check_box[category] => "true") %>
               <%= _("#{category.name}") %>
-            </label> <br>
+            </li>
           <% end %>
-        </div>
+        </ul>
       </div>
 
     <div class="project-software"> <%= _("Software Projects:") %>
@@ -34,9 +32,6 @@
       </label>
       <span class="doubts-catalog-software" title="<%= _('Include software development projects that are not yet officially Brazilian Public Software.') %>">?</span>
     </div>
-
-    <br />
-
     <%= button_tag _("Clean up"), :id => "cleanup-filter-catalg", :type => "button" %>
     <%= button_tag _("Close"), :id => "close-filter-catalog", :type => "button" %>
   </div>
diff --git a/views/search/_software_search_form.html.erb b/views/search/_software_search_form.html.erb
index d3aba37..126f646 100644
--- a/views/search/_software_search_form.html.erb
+++ b/views/search/_software_search_form.html.erb
@@ -3,7 +3,7 @@
     <h3> <%= _("Search Public Software Catalog") %> </h3>
 
     <%= form_tag( { :controller => 'search', :action => @asset ? @asset : 'index', :asset => nil, :category_path => ( @category ? @category.path : nil ) },
-    :method => 'get', :class => 'search_form' ) do %>
+      :method => 'get') do %>
 
     <div style="margin:0;padding:0;display:inline">
       <input name="utf8" type="hidden" value="&#x2713;" />
diff --git a/views/search/software_infos.html.erb b/views/search/software_infos.html.erb
index f2f5830..c68f6fc 100644
--- a/views/search/software_infos.html.erb
+++ b/views/search/software_infos.html.erb
@@ -5,8 +5,6 @@
 
   <%= render :partial => 'software_search_form', :locals => { :hint => _("Type words about the %s you're looking for") % @asset.to_s.singularize } %>
 
-  <div style="clear: both"></div>
-
   <% if @asset == :product %>
     <%= javascript_tag do %>
       jQuery('.search-product-price-details').altBeautify();
@@ -20,4 +18,4 @@
   <% if params[:display] != 'map' %>
     <%= pagination_links @searches[@asset][:results] %>
   <% end %>
-</div>
\ No newline at end of file
+</div>
--
libgit2 0.21.2