From 158fd0a9856b142d440d2b48dc359395f1a42b78 Mon Sep 17 00:00:00 2001 From: Rodrigo Souto Date: Thu, 23 Jan 2014 20:01:58 -0300 Subject: [PATCH] versioned-article-view: use variabla and alert developers about doubled verification --- app/views/content_viewer/versioned_article.rhtml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/views/content_viewer/versioned_article.rhtml b/app/views/content_viewer/versioned_article.rhtml index 130d09b..6bb666d 100644 --- a/app/views/content_viewer/versioned_article.rhtml +++ b/app/views/content_viewer/versioned_article.rhtml @@ -15,11 +15,16 @@ <%= _("Version %{version} - %{author} on %{date}") % {:version => @version, :author => @page.author_name(@version), :date => show_time(@versioned_article.updated_at) } %> - <% if @page.version_license(@version).present? %> + <% version_license = @page.version_license(@version) %> + <%# This seemingly doubled verification exists because the article-sub-header + div must appear only if at least one content inside it will appeart. + Although we have only one content now, we might have others in the future. + So we're keeping it like that to avoid mistakes. %> + <% if version_license.present? %>
- <% if @page.version_license(@version).present? %> + <% if version_license.present? %>
- <%= _('Licensed under %s') % (@page.version_license(@version).url.present? ? link_to(@page.version_license(@version).name, @page.version_license(@version).url, :target => '_blank') : @page.version_license(@version).name) %> + <%= _('Licensed under %s') % (version_license.url.present? ? link_to(version_license.name, version_license.url, :target => '_blank') : version_license.name) %>
<% end %>
-- libgit2 0.21.2