diff --git a/app/controllers/public/browse_controller.rb b/app/controllers/public/browse_controller.rb index 149383c..7951a70 100644 --- a/app/controllers/public/browse_controller.rb +++ b/app/controllers/public/browse_controller.rb @@ -12,7 +12,7 @@ class BrowseController < PublicController @filter = filter @title = self.filter_description(params[:action] + '_' + @filter ) - @results = @environment.people.send(@filter) + @results = @environment.people.visible.send(@filter) if params[:query].blank? @results = @results.paginate(:per_page => 27, :page => params[:page]) @@ -25,7 +25,7 @@ class BrowseController < PublicController @filter = filter @title = self.filter_description(params[:action] + '_' + @filter ) - @results = @environment.communities.send(@filter) + @results = @environment.communities.visible.send(@filter) if params[:query].blank? @results = @results.paginate(:per_page => 27, :page => params[:page]) diff --git a/test/functional/browse_controller_test.rb b/test/functional/browse_controller_test.rb index 177124a..92d1f21 100644 --- a/test/functional/browse_controller_test.rb +++ b/test/functional/browse_controller_test.rb @@ -218,4 +218,18 @@ class BrowseControllerTest < Test::Unit::TestCase assert_tag :h1, :content => 'More recent communities' end + should "only include visible people in more_recent filter" do + # assuming that all filters behave the same! + p1 = fast_create(Person, :visible => false) + get :people, :filter => 'more_recent' + assert_not_includes assigns(:results), p1 + end + + should "only include visible communities in more_recent filter" do + # assuming that all filters behave the same! + p1 = fast_create(Community, :visible => false) + get :communities, :filter => 'more_recent' + assert_not_includes assigns(:results), p1 + end + end -- libgit2 0.21.2