From 8b11b55de9144608de7621251c1289cbba793d51 Mon Sep 17 00:00:00 2001
From: Victor Costa <vfcosta@gmail.com>
Date: Fri, 9 Jan 2015 16:48:44 -0300
Subject: [PATCH] Small improvements on layout of person notifier email

---
 app/views/person_notifier/mailer/_create_article.html.erb   |  6 ++----
 app/views/person_notifier/mailer/_default_activity.html.erb |  6 ++----
 app/views/person_notifier/mailer/_upload_image.html.erb     |  6 ++----
 app/views/person_notifier/mailer/content_summary.html.erb   | 40 ++++++++++++++++++++++++----------------
 4 files changed, 30 insertions(+), 28 deletions(-)

diff --git a/app/views/person_notifier/mailer/_create_article.html.erb b/app/views/person_notifier/mailer/_create_article.html.erb
index caf2e19..75acaaf 100644
--- a/app/views/person_notifier/mailer/_create_article.html.erb
+++ b/app/views/person_notifier/mailer/_create_article.html.erb
@@ -1,10 +1,9 @@
-<table>
 <tr>
-  <td>
+  <td style="width: 11%">
     <%= link_to(profile_image(activity.user, :minor), activity.user.url) %>
   </td>
   <td>
-    <p style="width:550px">
+    <p>
     <span style="font-size: 14px;"><%= link_to activity.user.short_name(20), activity.user.url %></span>
     <span style="font-size: 14px;"><%= _("has published on community %s") % link_to(activity.target.profile.short_name(20), activity.target.profile.url, :style => "color: #333; font-weight: bold; text-decoration: none;") if activity.target.profile.is_a?(Community) %></span>
     <span style="font-size: 10px; color: #444444; float:right;"><%= time_ago_as_sentence(activity.created_at) %></span>
@@ -24,4 +23,3 @@
     <%= render :partial => 'profile_comments', :locals => { :activity => activity } %>
   </td>
 </tr>
-</table>
diff --git a/app/views/person_notifier/mailer/_default_activity.html.erb b/app/views/person_notifier/mailer/_default_activity.html.erb
index 5e28fe4..04a6ff7 100644
--- a/app/views/person_notifier/mailer/_default_activity.html.erb
+++ b/app/views/person_notifier/mailer/_default_activity.html.erb
@@ -1,10 +1,9 @@
-<table>
 <tr>
-  <td>
+  <td style="width: 11%">
     <%= link_to(profile_image(activity.user, :minor), activity.user.url) %>
   </td>
   <td>
-    <p style="width:550px">
+    <p>
       <span style="font-size: 14px;"><%= link_to activity.user.name, activity.user.url %> <%= describe activity %></span>
       <span style="font-size: 10px; color: #444444; float: right;"><%= time_ago_as_sentence(activity.created_at) %></span>
     </p>
@@ -16,4 +15,3 @@
     <%= render :partial => 'profile_comments', :locals => { :activity => activity } %>
   </td>
 </tr>
-</table>
diff --git a/app/views/person_notifier/mailer/_upload_image.html.erb b/app/views/person_notifier/mailer/_upload_image.html.erb
index 058a163..bdae2bf 100644
--- a/app/views/person_notifier/mailer/_upload_image.html.erb
+++ b/app/views/person_notifier/mailer/_upload_image.html.erb
@@ -1,15 +1,13 @@
-<table>
   <tr>
-    <td>
+    <td style="width: 11%">
       <%= link_to(profile_image(activity.user, :minor), activity.user.url) %>
     </td>
     <td>
-      <p style="width:550px">
+      <p>
         <span style="font-size: 14px;"><%= link_to activity.user.name, activity.user.url %> <%= describe activity %></span>
         <span style="font-size: 10px; color: #444444; float:right;"><%= time_ago_as_sentence(activity.created_at) %></span>
       </p>
   </td>
 </tr>
-</table>
 <div title='<%= activity.target.class.short_description %>' class='profile-activity-icon icon-new icon-newgallery'></div>
 <br/>
diff --git a/app/views/person_notifier/mailer/content_summary.html.erb b/app/views/person_notifier/mailer/content_summary.html.erb
index d56c2f6..6e587dc 100644
--- a/app/views/person_notifier/mailer/content_summary.html.erb
+++ b/app/views/person_notifier/mailer/content_summary.html.erb
@@ -1,18 +1,26 @@
-<h3><%= _("%s's network activity") % @profile.name %></h3>
-<br/>
-<div>
-<% @notifications.each do |activity| %>
-  <div style="border-left:none;border-right:none;border-top:1px solid #ccc;border-bottom:none;padding:10px;width:600px">
-    <%= render :partial => activity.verb, :locals => { :activity => activity } rescue "cannot render notification for #{activity.verb}" %>
+<div style="background-color: #EEEEEE">
+  <table style="width: 100%;"><tbody><tr><td align="center">
+  <div style="display: table; background-color: white; margin: 26px 0;">
+    <div style="padding: 25px 20px 20px 20px;text-align: left;">
+      <%= link_to @url, :style => "text-decoration: none;" do %>
+        <span style="font-weight:bold;font-size: 28px;margin: 0;color: white;background-color: #AAAAAA;padding: 5px;"><%= @environment %></span>
+      <% end %>
+      <span style="font-weight:bold;color: #333;font-size:19px;margin-left: 8px;"><%= _("%s's network activity") % @profile.name %></h3>
+    </div>
+    <div style="margin: 0 20px 20px 20px;border-top:2px solid #e2e2e2;">
+    <% @notifications.each do |activity| %>
+        <div style="border-bottom:1px solid #e2e2e2;padding:15px 0;width:600px">
+        <table style="width:100%;">
+          <%= render :partial => activity.verb, :locals => { :activity => activity } rescue "cannot render notification for #{activity.verb}" %>
+        </table>
+      </div>
+    <% end %>
+    </div>
+    <div style="color:#444444;font-size:11px;margin-bottom: 20px;">
+      <p style="margin:0"><%= _("Greetings,") %></p>
+      <p style="margin:0"><%= _('%s team.') % @environment %></p>
+      <p style="margin:0"><%= link_to @url, url_for(@url) %></p>
+    </div>
   </div>
-<% end %>
+  </td></tr></tbody></table>
 </div>
-
-<div style="color:#444444;font-size:11px;">
-<p><%= _("Greetings,") %></p>
-<br/>
-<p>--</p>
-<p><%= _('%s team.') % @environment %></p>
-<p><%= url_for @url %></p>
-</div>
-<br/>
--
libgit2 0.21.2