From a7891948f4cfdab393760434ec09df40a290a040 Mon Sep 17 00:00:00 2001 From: Diego Araújo + João M. M. da Silva Date: Tue, 6 Nov 2012 16:32:33 -0200 Subject: [PATCH] [Mezuro] Completed throwable model refactoring. --- plugins/mezuro/lib/kalibro/error.rb | 21 --------------------- plugins/mezuro/lib/kalibro/throwable.rb | 21 +++++++++++++++++++++ plugins/mezuro/test/fixtures/error_fixtures.rb | 20 -------------------- plugins/mezuro/test/fixtures/throwable_fixtures.rb | 20 ++++++++++++++++++++ plugins/mezuro/test/unit/kalibro/error_test.rb | 20 -------------------- plugins/mezuro/test/unit/kalibro/throwable_test.rb | 20 ++++++++++++++++++++ 6 files changed, 61 insertions(+), 61 deletions(-) delete mode 100644 plugins/mezuro/lib/kalibro/error.rb create mode 100644 plugins/mezuro/lib/kalibro/throwable.rb delete mode 100644 plugins/mezuro/test/fixtures/error_fixtures.rb create mode 100644 plugins/mezuro/test/fixtures/throwable_fixtures.rb delete mode 100644 plugins/mezuro/test/unit/kalibro/error_test.rb create mode 100644 plugins/mezuro/test/unit/kalibro/throwable_test.rb diff --git a/plugins/mezuro/lib/kalibro/error.rb b/plugins/mezuro/lib/kalibro/error.rb deleted file mode 100644 index 3c7f95c..0000000 --- a/plugins/mezuro/lib/kalibro/error.rb +++ /dev/null @@ -1,21 +0,0 @@ -class Kalibro::Error < Kalibro::Model - - attr_accessor :error_class, :message, :stack_trace_element, :cause - - def stack_trace_element=(value) - @stack_trace_element = Kalibro::StackTraceElement.to_objects_array value - end - - def stack_trace - @stack_trace_element - end - - def stack_trace=(stack_trace) - @stack_trace_element = stack_trace - end - - def cause=(cause_value) - @cause = Kalibro::Error.to_object cause_value - end - -end diff --git a/plugins/mezuro/lib/kalibro/throwable.rb b/plugins/mezuro/lib/kalibro/throwable.rb new file mode 100644 index 0000000..ca240c3 --- /dev/null +++ b/plugins/mezuro/lib/kalibro/throwable.rb @@ -0,0 +1,21 @@ +class Kalibro::Throwable < Kalibro::Model + + attr_accessor :target_string, :message, :cause, :stack_trace_element + + def stack_trace_element=(value) + @stack_trace_element = Kalibro::StackTraceElement.to_objects_array value + end + + def stack_trace + @stack_trace_element + end + + def stack_trace=(stack_trace) + @stack_trace_element = stack_trace + end + + def cause=(cause_value) + @cause = Kalibro::Throwable.to_object cause_value + end + +end diff --git a/plugins/mezuro/test/fixtures/error_fixtures.rb b/plugins/mezuro/test/fixtures/error_fixtures.rb deleted file mode 100644 index 74fb4b9..0000000 --- a/plugins/mezuro/test/fixtures/error_fixtures.rb +++ /dev/null @@ -1,20 +0,0 @@ -require File.dirname(__FILE__) + '/stack_trace_element_fixtures' - -class ErrorFixtures - - def self.error - Kalibro::Error.new error_hash - end - - def self.error_hash - { - :error_class => 'java.lang.Exception', - :message => 'Error message from ErrorTest', - :stack_trace_element => [ - StackTraceElementFixtures.stack_trace_element_hash('my method 1', 42), - StackTraceElementFixtures.stack_trace_element_hash('my method 2', 84) - ] - } - end - -end diff --git a/plugins/mezuro/test/fixtures/throwable_fixtures.rb b/plugins/mezuro/test/fixtures/throwable_fixtures.rb new file mode 100644 index 0000000..ce1b18d --- /dev/null +++ b/plugins/mezuro/test/fixtures/throwable_fixtures.rb @@ -0,0 +1,20 @@ +require File.dirname(__FILE__) + '/stack_trace_element_fixtures' + +class ThrowableFixtures + + def self.throwable + Kalibro::Throwable.new throwable_hash + end + + def self.throwable_hash + { + :target_string => 'Target String', + :message => 'Throwable message from ThrowableTest', + :stack_trace_element => [ + StackTraceElementFixtures.stack_trace_element_hash('my method 1', 42), + StackTraceElementFixtures.stack_trace_element_hash('my method 2', 84) + ] + } + end + +end diff --git a/plugins/mezuro/test/unit/kalibro/error_test.rb b/plugins/mezuro/test/unit/kalibro/error_test.rb deleted file mode 100644 index 4faf108..0000000 --- a/plugins/mezuro/test/unit/kalibro/error_test.rb +++ /dev/null @@ -1,20 +0,0 @@ -require "test_helper" - -require "#{RAILS_ROOT}/plugins/mezuro/test/fixtures/error_fixtures" - -class ErrorTest < ActiveSupport::TestCase - - def setup - @hash = ErrorFixtures.error_hash - @error = ErrorFixtures.error - end - - should 'create error from hash' do - assert_equal @hash[:message], Kalibro::Error.new(@hash).message - end - - should 'convert error to hash' do - assert_equal @hash, @error.to_hash - end - -end diff --git a/plugins/mezuro/test/unit/kalibro/throwable_test.rb b/plugins/mezuro/test/unit/kalibro/throwable_test.rb new file mode 100644 index 0000000..040805b --- /dev/null +++ b/plugins/mezuro/test/unit/kalibro/throwable_test.rb @@ -0,0 +1,20 @@ +require "test_helper" + +require "#{RAILS_ROOT}/plugins/mezuro/test/fixtures/throwable_fixtures" + +class ThrowableTest < ActiveSupport::TestCase + + def setup + @hash = ThrowableFixtures.throwable_hash + @throwable = ThrowableFixtures.throwable + end + + should 'create throwable from hash' do + assert_equal @hash[:message], Kalibro::Throwable.new(@hash).message + end + + should 'convert throwable to hash' do + assert_equal @hash, @throwable.to_hash + end + +end -- libgit2 0.21.2