diff --git a/plugins/work_assignment/lib/work_assignment_plugin.rb b/plugins/work_assignment/lib/work_assignment_plugin.rb index 8b07132..826f40c 100644 --- a/plugins/work_assignment/lib/work_assignment_plugin.rb +++ b/plugins/work_assignment/lib/work_assignment_plugin.rb @@ -36,8 +36,8 @@ class WorkAssignmentPlugin < Noosfero::Plugin end def content_viewer_controller_filters - block = lambda do - path = params[:page].join('/') + block = proc do + path = params[:page] content = profile.articles.find_by_path(path) if WorkAssignmentPlugin.is_submission?(content) && !WorkAssignmentPlugin.can_download_submission?(user, content) diff --git a/plugins/work_assignment/lib/work_assignment_plugin/work_assignment.rb b/plugins/work_assignment/lib/work_assignment_plugin/work_assignment.rb index b3485c2..fdf01a4 100644 --- a/plugins/work_assignment/lib/work_assignment_plugin/work_assignment.rb +++ b/plugins/work_assignment/lib/work_assignment_plugin/work_assignment.rb @@ -2,6 +2,8 @@ class WorkAssignmentPlugin::WorkAssignment < Folder settings_items :publish_submissions, :type => :boolean, :default => false + attr_accessible :publish_submissions + def self.icon_name(article = nil) 'work-assignment' end @@ -27,7 +29,7 @@ class WorkAssignmentPlugin::WorkAssignment < Folder end def to_html(options = {}) - lambda do + proc do render :file => 'content_viewer/work_assignment.html.erb' end end diff --git a/plugins/work_assignment/test/functional/cms_controller_test.rb b/plugins/work_assignment/test/functional/cms_controller_test.rb index 6766aa3..b6ef00f 100644 --- a/plugins/work_assignment/test/functional/cms_controller_test.rb +++ b/plugins/work_assignment/test/functional/cms_controller_test.rb @@ -22,7 +22,7 @@ class CmsControllerTest < ActionController::TestCase get :upload_files, :profile => organization.identifier, :parent_id => work_assignment.id assert_response :forbidden - assert_template 'access_denied.rhtml' + assert_template 'access_denied' organization.add_member(person) diff --git a/plugins/work_assignment/test/functional/content_viewer_controller_test.rb b/plugins/work_assignment/test/functional/content_viewer_controller_test.rb index dc6b28f..416cb87 100644 --- a/plugins/work_assignment/test/functional/content_viewer_controller_test.rb +++ b/plugins/work_assignment/test/functional/content_viewer_controller_test.rb @@ -29,13 +29,13 @@ class ContentViewerControllerTest < ActionController::TestCase submission = UploadedFile.create!(:uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'), :profile => organization, :parent => folder) WorkAssignmentPlugin.stubs(:can_download_submission?).returns(false) - get :view_page, :profile => organization.identifier, :page => submission.explode_path + get :view_page, :profile => organization.identifier, :page => submission.path assert_response :forbidden - assert_template 'access_denied.rhtml' + assert_template 'access_denied' WorkAssignmentPlugin.stubs(:can_download_submission?).returns(true) - get :view_page, :profile => organization.identifier, :page => submission.explode_path + get :view_page, :profile => organization.identifier, :page => submission.path assert_response :success end diff --git a/plugins/work_assignment/test/unit/work_assingment_plugin/work_assignment_test.rb b/plugins/work_assignment/test/unit/work_assingment_plugin/work_assignment_test.rb index 06a077d..9d283ec 100644 --- a/plugins/work_assignment/test/unit/work_assingment_plugin/work_assignment_test.rb +++ b/plugins/work_assignment/test/unit/work_assingment_plugin/work_assignment_test.rb @@ -35,10 +35,10 @@ class WorkAssignmentTest < ActiveSupport::TestCase organization = fast_create(Organization) author = fast_create(Person) work_assignment = WorkAssignmentPlugin::WorkAssignment.create!(:name => 'Sample Work Assignment', :profile => organization) - submission = UploadedFile.create!(:uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'), :profile => organization, :parent => work_assignment, :last_changed_by => author) + submission = create(UploadedFile, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'), :profile => organization, :parent => work_assignment, :last_changed_by => author) author_folder = work_assignment.find_or_create_author_folder(author) - assert author_folder, submission.parent + assert_equal author_folder, submission.parent end should 'add logged user on cache_key if is a member' do diff --git a/plugins/work_assignment/test/unit/work_assingment_plugin_test.rb b/plugins/work_assignment/test/unit/work_assingment_plugin_test.rb index fd15061..f2ebac5 100644 --- a/plugins/work_assignment/test/unit/work_assingment_plugin_test.rb +++ b/plugins/work_assignment/test/unit/work_assingment_plugin_test.rb @@ -3,7 +3,7 @@ require 'test_helper' class WorkAssignmentPluginTest < ActiveSupport::TestCase should 'verify if a content is a work_assignment submission' do organization = fast_create(Organization) - content = UploadedFile.create!(:uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'), :profile => organization, :last_changed_by => fast_create(Person)) + content = create(UploadedFile, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'), :profile => organization, :last_changed_by => fast_create(Person)) assert !WorkAssignmentPlugin.is_submission?(content) work_assignment = WorkAssignmentPlugin::WorkAssignment.create!(:name => 'Work Assignment', :profile => organization) @@ -49,6 +49,6 @@ class WorkAssignmentPluginTest < ActiveSupport::TestCase organization = fast_create(Organization) work_assignment = WorkAssignmentPlugin::WorkAssignment.create!(:name => 'Work Assignment', :profile => organization) author_folder = work_assignment.find_or_create_author_folder(fast_create(Person)) - UploadedFile.create!(:uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'), :profile => organization, :parent => author_folder, :last_changed_by => author) + create(UploadedFile, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'), :profile => organization, :parent => author_folder, :last_changed_by => author) end end -- libgit2 0.21.2