diff --git a/plugins/people_block/lib/ext/person.rb b/plugins/people_block/lib/ext/person.rb index 03ccddf..c36d34d 100644 --- a/plugins/people_block/lib/ext/person.rb +++ b/plugins/people_block/lib/ext/person.rb @@ -3,7 +3,7 @@ require_dependency 'person' class Person scope :with_role, -> role_id { - select('DISTINCT profiles.*').joins(:role_assignments). + joins(:role_assignments). where("role_assignments.role_id = #{role_id}") } diff --git a/plugins/people_block/test/unit/members_block_test.rb b/plugins/people_block/test/unit/members_block_test.rb index 998d52d..1473ad3 100644 --- a/plugins/people_block/test/unit/members_block_test.rb +++ b/plugins/people_block/test/unit/members_block_test.rb @@ -240,6 +240,10 @@ class MembersBlockTest < ActionView::TestCase assert_includes profiles, profile1 assert_not_includes profiles, profile2 + + profile_list = block.profile_list + assert_includes profile_list, profile1 + assert_not_includes profile_list, profile2 end should 'list only profiles with member role' do @@ -261,6 +265,10 @@ class MembersBlockTest < ActionView::TestCase assert_not_includes profiles, profile1 assert_includes profiles, profile2 + + profile_list = block.profile_list + assert_not_includes profile_list, profile1 + assert_includes profile_list, profile2 end should 'list available roles' do -- libgit2 0.21.2