From 0fff0876bd7b6c71f51fa21c958718e455458eb3 Mon Sep 17 00:00:00 2001 From: Leandro Nunes dos Santos Date: Tue, 17 Mar 2015 23:44:22 -0300 Subject: [PATCH] adding enterprise article endpoint --- lib/api/v1/articles.rb | 41 +++++++++++++++++++++++++++++++++++++++-- test/unit/api/articles_test.rb | 128 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 167 insertions(+), 2 deletions(-) diff --git a/lib/api/v1/articles.rb b/lib/api/v1/articles.rb index 5e0948b..566e011 100644 --- a/lib/api/v1/articles.rb +++ b/lib/api/v1/articles.rb @@ -99,8 +99,6 @@ module API present article, :with => Entities::Article end - # Example Request: - # POST api/v1/communites/:person_id/articles?private_toke=234298743290432&article[name]=title&article[body]=body post do person = environment.people.find(params[:person_id]) return forbidden! unless current_person.can_post_content?(person) @@ -124,6 +122,45 @@ module API end + resource :enterprises do + segment '/:enterprise_id' do + resource :articles do + get do + enterprise = environment.enterprises.find(params[:enterprise_id]) + articles = select_filtered_collection_of(enterprise, 'articles', params) + articles = articles.display_filter(current_person, enterprise) + present articles, :with => Entities::Article + end + + get ':id' do + enterprise = environment.enterprises.find(params[:enterprise_id]) + article = find_article(enterprise.articles, params[:id]) + present article, :with => Entities::Article + end + + post do + enterprise = environment.enterprises.find(params[:enterprise_id]) + return forbidden! unless current_person.can_post_content?(enterprise) + + klass_type= params[:content_type].nil? ? 'TinyMceArticle' : params[:content_type] + return forbidden! unless ARTICLE_TYPES.include?(klass_type) + + article = klass_type.constantize.new(params[:article]) + article.last_changed_by = current_person + article.created_by= current_person + article.profile = enterprise + + if !article.save + render_api_errors!(article.errors.full_messages) + end + present article, :with => Entities::Article + end + + end + end + + end + end end diff --git a/test/unit/api/articles_test.rb b/test/unit/api/articles_test.rb index a406a41..6d57c79 100644 --- a/test/unit/api/articles_test.rb +++ b/test/unit/api/articles_test.rb @@ -314,5 +314,133 @@ class ArticlesTest < ActiveSupport::TestCase assert_equal user.person, Article.last.last_changed_by end + ############################# + # Enterprise Articles # + ############################# + + should 'return article by enterprise' do + enterprise = fast_create(Enterprise) + article = fast_create(Article, :profile_id => enterprise.id, :name => "Some thing") + get "/api/v1/enterprises/#{enterprise.id}/articles/#{article.id}?#{params.to_query}" + json = JSON.parse(last_response.body) + assert_equal article.id, json["article"]["id"] + end + + should 'not return article by enterprise if user has no permission to view it' do + enterprise = fast_create(Enterprise) + article = fast_create(Article, :profile_id => enterprise.id, :name => "Some thing", :published => false) + assert !article.published? + + get "/api/v1/enterprises/#{enterprise.id}/articles/#{article.id}?#{params.to_query}" + assert_equal 403, last_response.status + end + + should 'not list forbidden article when listing articles by enterprise' do + enterprise = fast_create(Enterprise) + article = fast_create(Article, :profile_id => enterprise.id, :name => "Some thing", :published => false) + assert !article.published? + + get "/api/v1/enterprises/#{enterprise.id}/articles?#{params.to_query}" + json = JSON.parse(last_response.body) + assert_not_includes json['articles'].map {|a| a['id']}, article.id + end + + should 'create article in a enterprise' do + enterprise = fast_create(Enterprise) + give_permission(user.person, 'post_content', enterprise) + params[:article] = {:name => "Title"} + post "/api/v1/enterprises/#{enterprise.id}/articles?#{params.to_query}" + json = JSON.parse(last_response.body) + assert_equal "Title", json["article"]["title"] + end + + should 'enterprise: do not create article if user has no permission to post content' do + enterprise = fast_create(Enterprise) + give_permission(user.person, 'invite_members', enterprise) + params[:article] = {:name => "Title"} + post "/api/v1/enterprises/#{enterprise.id}/articles?#{params.to_query}" + assert_equal 403, last_response.status + end + + should 'enterprise: create article with parent' do + enterprise = fast_create(Enterprise) + enterprise.add_member(user.person) + article = fast_create(Article) + + params[:article] = {:name => "Title", :parent_id => article.id} + post "/api/v1/enterprises/#{enterprise.id}/articles?#{params.to_query}" + json = JSON.parse(last_response.body) + assert_equal article.id, json["article"]["parent"]["id"] + end + + should 'enterprise: create article with content type passed as parameter' do + enterprise = fast_create(Enterprise) + enterprise.add_member(user.person) + + Article.delete_all + params[:article] = {:name => "Title"} + params[:content_type] = 'TextArticle' + post "/api/v1/enterprises/#{enterprise.id}/articles?#{params.to_query}" + json = JSON.parse(last_response.body) + + assert_kind_of TextArticle, Article.last + end + + should 'enterprise: create article of TinyMceArticle type if no content type is passed as parameter' do + enterprise = fast_create(Enterprise) + enterprise.add_member(user.person) + + params[:article] = {:name => "Title"} + post "/api/v1/enterprises/#{enterprise.id}/articles?#{params.to_query}" + json = JSON.parse(last_response.body) + + assert_kind_of TinyMceArticle, Article.last + end + + should 'enterprise: not create article with invalid article content type' do + enterprise = fast_create(Enterprise) + enterprise.add_member(user.person) + + params[:article] = {:name => "Title"} + params[:content_type] = 'Person' + post "/api/v1/enterprises/#{enterprise.id}/articles?#{params.to_query}" + json = JSON.parse(last_response.body) + + assert_equal 403, last_response.status + end + + should 'enterprise: create article defining the correct profile' do + enterprise = fast_create(Enterprise) + enterprise.add_member(user.person) + + params[:article] = {:name => "Title"} + post "/api/v1/enterprises/#{enterprise.id}/articles?#{params.to_query}" + json = JSON.parse(last_response.body) + + assert_equal enterprise, Article.last.profile + end + + should 'enterprise: create article defining the created_by' do + enterprise = fast_create(Enterprise) + enterprise.add_member(user.person) + + params[:article] = {:name => "Title"} + post "/api/v1/enterprises/#{enterprise.id}/articles?#{params.to_query}" + json = JSON.parse(last_response.body) + + assert_equal user.person, Article.last.created_by + end + + should 'enterprise: create article defining the last_changed_by' do + enterprise = fast_create(Enterprise) + enterprise.add_member(user.person) + + params[:article] = {:name => "Title"} + post "/api/v1/enterprises/#{enterprise.id}/articles?#{params.to_query}" + json = JSON.parse(last_response.body) + + assert_equal user.person, Article.last.last_changed_by + end + end -- libgit2 0.21.2