From 141aa503ee3d7a4e0652c934e2502927cdf352e8 Mon Sep 17 00:00:00 2001 From: AntonioTerceiro Date: Fri, 6 Jun 2008 21:29:48 +0000 Subject: [PATCH] ActionItem411: fallback to login if name is blank --- app/models/person.rb | 2 +- test/unit/person_test.rb | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/app/models/person.rb b/app/models/person.rb index 2756bac..41accc1 100644 --- a/app/models/person.rb +++ b/app/models/person.rb @@ -100,7 +100,7 @@ class Person < Profile hacked_after_create :insert_default_homepage_and_feed def name - if !self[:name].nil? + if !self[:name].blank? self[:name] else self.user ? self.user.login : nil diff --git a/test/unit/person_test.rb b/test/unit/person_test.rb index 189ee42..1905df3 100644 --- a/test/unit/person_test.rb +++ b/test/unit/person_test.rb @@ -219,6 +219,12 @@ class PersonTest < Test::Unit::TestCase assert_equal 'randomhacker', p.name end + should 'fallback to login when name is blank' do + p = create_user('randomhacker').person + p.name = '' + assert_equal 'randomhacker', p.name + end + should 'have favorite enterprises' do p = create_user('test_person').person e = Enterprise.create!(:name => 'test_ent', :identifier => 'test_ent') -- libgit2 0.21.2