From 31849db7f8d8b4cb72aa6b6b28bd5d75c35523d6 Mon Sep 17 00:00:00 2001
From: JoenioCosta <JoenioCosta@3f533792-8f58-4932-b0fe-aaf55b0a4547>
Date: Wed, 21 May 2008 22:20:44 +0000
Subject: [PATCH] ActionItem252: only categories with more than X entries should show up in the top menu

---
 app/models/category.rb                         |  6 ++++++
 app/views/profile_editor/index.rhtml           |  2 --
 app/views/shared/categories_menu.rhtml         |  2 +-
 test/functional/application_controller_test.rb | 12 ++++++++++++
 test/unit/category_test.rb                     | 12 ++++++++++++
 5 files changed, 31 insertions(+), 3 deletions(-)

diff --git a/app/models/category.rb b/app/models/category.rb
index 9f1c7be..5bd02b0 100644
--- a/app/models/category.rb
+++ b/app/models/category.rb
@@ -47,7 +47,13 @@ class Category < ActiveRecord::Base
   end
 
   def total_items
+    # FIXME this can be SLOW (??)
     articles.count + comments.count + enterprises.count + people.count + communities.count + products.count
   end
 
+  def display_in_menu?
+    # FIXME don't hardcode like this. Should be a setting of the environment, maybe
+    total_items >= 10
+  end
+
 end
diff --git a/app/views/profile_editor/index.rhtml b/app/views/profile_editor/index.rhtml
index 793a5c6..b331bd4 100644
--- a/app/views/profile_editor/index.rhtml
+++ b/app/views/profile_editor/index.rhtml
@@ -14,8 +14,6 @@
 
   <%= file_manager_button(_('Manage Content'), 'icons-app/cms.png', :controller => 'cms') %>
 
-  <%= file_manager_button(_('My Interests'), 'icons-app/categories.png', :controller => 'profile_editor', :action => 'edit_categories')  %>
-
   <%= file_manager_button(_('Change Password'), 'icons-app/change-password.png', :controller => 'account', :action => 'change_password') if profile.person? %>
 
   <%= file_manager_button(_('Manage friends'), 'icons-app/friends.png', :controller => 'friends', :action => 'index') if profile.person? %>
diff --git a/app/views/shared/categories_menu.rhtml b/app/views/shared/categories_menu.rhtml
index 624975d..a79b10c 100644
--- a/app/views/shared/categories_menu.rhtml
+++ b/app/views/shared/categories_menu.rhtml
@@ -4,7 +4,7 @@
     <li id="category<%= item.display_color %>"<%= ' class="active"' if (@category && (@category.top_ancestor == item)) %>>
       <%= item.name %>
       <ul>
-        <% item.all_children.each do |child| %>
+        <% item.all_children.select{|i| i.display_in_menu?}.each do |child| %>
           <% if (@controller.controller_name == 'search') && (@controller.action_name == 'assets') %>
             <li><%= link_to(content_tag('span', child.name), :controller => 'search', :action => 'assets', :asset => params[:asset], :category_path => child.explode_path) %></li>
           <% else %>
diff --git a/test/functional/application_controller_test.rb b/test/functional/application_controller_test.rb
index 4feef02..8d1e7a3 100644
--- a/test/functional/application_controller_test.rb
+++ b/test/functional/application_controller_test.rb
@@ -127,4 +127,16 @@ class ApplicationControllerTest < Test::Unit::TestCase
     assert_no_tag :tag => 'div', :attributes => { :id => 'boxes', :class => 'boxes'  }
   end
 
+  # FIXME why this not work???
+  should 'display categories in menu' do
+    c1 = Category.create!(:name => 'category 1', :environment => Environment.default)
+    c2 = Category.create!(:name => 'category 2', :environment => Environment.default, :parent => c1)
+    c3 = Category.create!(:name => 'category 3', :environment => Environment.default, :parent => c1)
+    c2.expects(:display_in_menu?).returns(true)
+    c3.expects(:display_in_menu?).returns(false)
+    get :index
+    assert_tag :tag => 'a', :attributes => { :content => /category 2/ }
+    assert_no_tag :tag => 'a', :attributes => { :content => /category 3/ }
+  end
+
 end
diff --git a/test/unit/category_test.rb b/test/unit/category_test.rb
index 8de49e3..ac049dd 100644
--- a/test/unit/category_test.rb
+++ b/test/unit/category_test.rb
@@ -385,4 +385,16 @@ class CategoryTest < Test::Unit::TestCase
     end
   end
 
+  should 'display in menu' do
+    c = Category.create!(:name => 'test category1', :environment => Environment.default)
+    c.expects(:total_items).returns(10)
+    assert c.display_in_menu?
+  end
+
+  should 'not display in menu' do
+    c = Category.create!(:name => 'test category1', :environment => Environment.default)
+    c.expects(:total_items).returns(1)
+    assert !c.display_in_menu?
+  end
+
 end
--
libgit2 0.21.2