From 73479a2c7c52e323c027dc83ad06f157d221ca17 Mon Sep 17 00:00:00 2001 From: Rodrigo Souto Date: Thu, 21 Nov 2013 17:25:44 -0300 Subject: [PATCH] application_helper/rolename: improve performance retrieval and readability --- app/helpers/application_helper.rb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 4c40a2a..98d92e5 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -727,7 +727,10 @@ module ApplicationHelper end def rolename_for(profile, resource) - roles = profile.role_assignments.select{ |a| a.resource_id == resource.id }.sort_by{ |s| s.role_id }.map(&:role) + roles = profile.role_assignments. + where(:resource_id => resource.id). + sort_by{ |role_assignment| role_assignment.role_id }. + map(&:role) names = [] roles.each do |role| names << content_tag('span', role.name, :style => "color: #{role_color(role, resource.environment.id)}") -- libgit2 0.21.2