From b87e8539bd89d9e92621b6fd3c00b0579c352197 Mon Sep 17 00:00:00 2001
From: Daniel Cunha <daniel.ccunha@gmail.com>
Date: Fri, 31 Aug 2012 17:19:19 -0300
Subject: [PATCH] Changing acceptable_center_blocks and acceptable_side_blocks instance methods to class methods

---
 app/models/box.rb | 117 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------
 1 file changed, 59 insertions(+), 58 deletions(-)

diff --git a/app/models/box.rb b/app/models/box.rb
index 0ea61ca..a96afcb 100644
--- a/app/models/box.rb
+++ b/app/models/box.rb
@@ -4,73 +4,74 @@ class Box < ActiveRecord::Base
   has_many :blocks, :dependent => :destroy, :order => 'position'
 
   def acceptable_blocks
-    to_css_class_name (position == 1) ? acceptable_center_blocks : acceptable_side_blocks
+    to_css_class_name central?  ? Box.acceptable_center_blocks : Box.acceptable_side_blocks
   end
 
-  private
+  def central?
+    position == 1
+  end
 
-  def acceptable_center_blocks
-    %w{
-      ArticleBlock
-      BlogArchivesBlock
-      CategoriesBlock
-      CommunitiesBlock
-      EnterprisesBlock
-      EnvironmentStatisticsBlock
-      FansBlock
-      FavoriteEnterprisesBlock
-      FeedReaderBlock
-      FriendsBlock
-      HighlightsBlock
-      LinkListBlock
-      LoginBlock
-      MainBlock
-      MembersBlock
-      MyNetworkBlock
-      PeopleBlock
-      ProfileImageBlock
-      RawHTMLBlock
-      RecentDocumentsBlock
-      SellersSearchBlock
-      TagsBlock
-    }
+  def self.acceptable_center_blocks
+    [ ArticleBlock,
+      BlogArchivesBlock,
+      CategoriesBlock,
+      CommunitiesBlock,
+      EnterprisesBlock,
+      EnvironmentStatisticsBlock,
+      FansBlock,
+      FavoriteEnterprisesBlock,
+      FeedReaderBlock,
+      FriendsBlock,
+      HighlightsBlock,
+      LinkListBlock,
+      LoginBlock,
+      MainBlock,
+      MembersBlock,
+      MyNetworkBlock,
+      PeopleBlock,
+      ProfileImageBlock,
+      RawHTMLBlock,
+      RecentDocumentsBlock,
+      SellersSearchBlock,
+      TagsBlock ]
   end
 
-  def acceptable_side_blocks
-    %w{
-      ArticleBlock
-      BlogArchivesBlock
-      CategoriesBlock
-      CommunitiesBlock
-      DisabledEnterpriseMessageBlock
-      EnterprisesBlock
-      EnvironmentStatisticsBlock
-      FansBlock
-      FavoriteEnterprisesBlock
-      FeaturedProductsBlock
-      FeedReaderBlock
-      FriendsBlock
-      HighlightsBlock
-      LinkListBlock
-      LocationBlock
-      LoginBlock
-      MembersBlock
-      MyNetworkBlock
-      PeopleBlock
-      ProductsBlock
-      ProfileImageBlock
-      ProfileInfoBlock
-      ProfileSearchBlock
-      RawHTMLBlock
-      RecentDocumentsBlock
-      SellersSearchBlock
-      SlideshowBlock
+  def self.acceptable_side_blocks
+    [ ArticleBlock,
+      BlogArchivesBlock,
+      CategoriesBlock,
+      CommunitiesBlock,
+      DisabledEnterpriseMessageBlock,
+      EnterprisesBlock,
+      EnvironmentStatisticsBlock,
+      FansBlock,
+      FavoriteEnterprisesBlock,
+      FeaturedProductsBlock,
+      FeedReaderBlock,
+      FriendsBlock,
+      HighlightsBlock,
+      LinkListBlock,
+      LocationBlock,
+      LoginBlock,
+      MembersBlock,
+      MyNetworkBlock,
+      PeopleBlock,
+      ProductsBlock,
+      ProfileImageBlock,
+      ProfileInfoBlock,
+      ProfileSearchBlock,
+      RawHTMLBlock,
+      RecentDocumentsBlock,
+      SellersSearchBlock,
+      SlideshowBlock,
       TagsBlock
-    }
+    ]
   end
 
+  private
+
   def to_css_class_name(blocks)
-    blocks.map{ |block| block.underscore.tr('_', '-') }
+    blocks.map{ |block| block.to_s.underscore.tr('_', '-') }
   end
 
 end
--
libgit2 0.21.2